LaravelRUS / SleepingOwlAdmin

src/Form/Element/NamedFormElement.php

Doc Comments +1 added lines, -1 removed lines

@@ -181,7 +181,7 @@
     }
 
     /**
-     * @param mixed $defaultValue
+     * @param string $defaultValue
      *
      * @return $this
      */

Spacing +7 added lines, -7 removed lines

@@ -85,7 +85,7 @@ 
     {
         $name = array_shift($parts);
 
-        while (! empty($parts)) {
+        while (!empty($parts)) {
             $part = array_shift($parts);
             $name .= "[$part]";
         }
@@ -238,7 +238,7 @@ 
     {
         $this->addValidationRule('_unique');
 
-        if (! is_null($message)) {
+        if (!is_null($message)) {
             $this->addValidationMessage('unique', $message);
         }
 
@@ -346,7 +346,7 @@ 
      */
     public function getValueFromRequest(\Illuminate\Http\Request $request)
     {
-        if ($request->hasSession() && ! is_null($value = $request->old($this->getPath()))) {
+        if ($request->hasSession() && !is_null($value = $request->old($this->getPath()))) {
             return $value;
         }
 
@@ -358,7 +358,7 @@ 
      */
     public function getValueFromModel()
     {
-        if (! is_null($value = $this->getValueFromRequest(request()))) {
+        if (!is_null($value = $this->getValueFromRequest(request()))) {
             return $value;
         }
 
@@ -366,7 +366,7 @@ 
         $path = $this->getPath();
         $value = $this->getDefaultValue();
 
-        if (is_null($model) || ! $model->exists) {
+        if (is_null($model) || !$model->exists) {
             return $value;
         }
 
@@ -396,7 +396,7 @@ 
         if ($count === 1) {
             $attribute = $model->getAttribute($this->getModelAttributeKey());
 
-            if (! empty($attribute) || $attribute === 0 || is_null($value)) {
+            if (!empty($attribute) || $attribute === 0 || is_null($value)) {
                 return $attribute;
             }
         }
@@ -410,7 +410,7 @@ 
             if ($count === 2) {
                 $attribute = $model->getAttribute($relation);
 
-                if (! empty($attribute) || is_null($value)) {
+                if (!empty($attribute) || is_null($value)) {
                     return $attribute;
                 }
             }

src/Templates/Template.php

Spacing +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
      */
     public function assetPath($path = null)
     {
-        return ! is_null($path) ? $this->assetDir().'/'.ltrim($path, '/') : $this->assetDir();
+        return !is_null($path) ? $this->assetDir().'/'.ltrim($path, '/') : $this->assetDir();
     }
 
     /**

src/Model/ModelConfiguration.php

Spacing +6 added lines, -6 removed lines

@@ -204,7 +204,7 @@ 
      */
     public function can($action, Model $model)
     {
-        if (! $this->checkAccess) {
+        if (!$this->checkAccess) {
             return true;
         }
 
@@ -216,7 +216,7 @@ 
      */
     public function isCreatable()
     {
-        if (! is_callable($this->getCreate())) {
+        if (!is_callable($this->getCreate())) {
             return false;
         }
 
@@ -240,7 +240,7 @@ 
      */
     public function isEditable(Model $model)
     {
-        if (! is_callable($this->getEdit())) {
+        if (!is_callable($this->getEdit())) {
             return false;
         }
 
@@ -363,7 +363,7 @@ 
      */
     public function fireDisplay(array $payload = [])
     {
-        if (! is_callable($this->getDisplay())) {
+        if (!is_callable($this->getDisplay())) {
             return;
         }
 
@@ -409,7 +409,7 @@ 
      */
     public function fireCreate()
     {
-        if (! is_callable($this->getCreate())) {
+        if (!is_callable($this->getCreate())) {
             return;
         }
 
@@ -456,7 +456,7 @@ 
      */
     public function fireEdit($id)
     {
-        if (! is_callable($this->getEdit())) {
+        if (!is_callable($this->getEdit())) {
             return;
         }
 

Doc Comments +3 added lines

@@ -108,6 +108,9 @@
 
     protected $breadcrumbs = null;
 
+    /**
+     * @param string $class
+     */
     public function __construct(\Illuminate\Contracts\Foundation\Application $app, $class)
     {
         parent::__construct($app, $class);

src/Model/SectionModelConfiguration.php

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
      */
     public function fireDisplay(array $payload = [])
     {
-        if (! method_exists($this, 'onDisplay')) {
+        if (!method_exists($this, 'onDisplay')) {
             return;
         }
 
@@ -56,7 +56,7 @@ 
      */
     public function fireCreate()
     {
-        if (! method_exists($this, 'onCreate')) {
+        if (!method_exists($this, 'onCreate')) {
             return;
         }
 
@@ -83,7 +83,7 @@ 
      */
     public function fireEdit($id)
     {
-        if (! method_exists($this, 'onEdit')) {
+        if (!method_exists($this, 'onEdit')) {
             return;
         }
 

src/Form/Buttons/Destroy.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      */
     public function canShow()
     {
-        if (is_null($this->getModel()->getKey()) || ! $this->show) {
+        if (is_null($this->getModel()->getKey()) || !$this->show) {
             return false;
         }
 

src/Display/Column/Editable/EditableColumn.php

Doc Comments +3 added lines, -5 removed lines

@@ -40,9 +40,8 @@ 
     }
 
     /**
-     * @param bool $sortable
      *
-     * @return $this
+     * @return string
      */
     public function getTitle()
     {
@@ -54,7 +53,6 @@ 
     }
 
     /**
-     * @param bool $sortable
      *
      * @return $this
      */
@@ -79,7 +77,7 @@ 
 
     /**
      * @param $url
-     * @return string
+     * @return EditableColumn
      */
     public function setUrl($url)
     {
@@ -98,7 +96,7 @@ 
 
     /**
      * @param $url
-     * @return string
+     * @return EditableColumn
      */
     public function setEditableMode($mode)
     {

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SleepingOwl\Admin\Display\Column\Editable;
 
-use Illuminate\Http\Request;
 use SleepingOwl\Admin\Display\Column\NamedColumn;
 
 class EditableColumn extends NamedColumn

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
      */
     public function getUrl()
     {
-        if (! $this->url) {
+        if (!$this->url) {
             return request()->url();
         }
 

src/Display/Column/NamedColumn.php

Doc Comments +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
     /**
      * Get column value from instance.
      *
-     * @param Collection|Model|Closure $instance
+     * @param Model $instance
      * @param string $name
      *
      * @return mixed

Spacing +4 added lines, -4 removed lines

@@ -75,8 +75,8 @@ 
      */
     public function setOrderable($orderable = true)
     {
-        if ($orderable !== false && ! $orderable instanceof OrderByClauseInterface) {
-            if (! is_string($orderable) && ! $orderable instanceof Closure) {
+        if ($orderable !== false && !$orderable instanceof OrderByClauseInterface) {
+            if (!is_string($orderable) && !$orderable instanceof Closure) {
                 $orderable = $this->getName();
             }
         }
@@ -144,11 +144,11 @@ 
             if ($instance === null) {
                 $instance = collect();
             }
-        } elseif (! is_null($instance)) {
+        } elseif (!is_null($instance)) {
             $instance = $instance->getAttribute($part);
         }
 
-        if (! empty($parts) && ! is_null($instance)) {
+        if (!empty($parts) && !is_null($instance)) {
             return $this->getValueFromObject($instance, implode('.', $parts));
         }
 

src/Form/FormDefault.php

Doc Comments +1 added lines, -1 removed lines

@@ -192,7 +192,7 @@
      * @deprecated 4.5.0
      * @see getElements()
      *
-     * @return Collection[]
+     * @return FormElementsCollection
      */
     public function getItems()
     {

Spacing +9 added lines, -9 removed lines

@@ -100,11 +100,11 @@ 
 
         parent::initialize();
 
-        if (! $this->hasHtmlAttribute('enctype')) {
+        if (!$this->hasHtmlAttribute('enctype')) {
             // Try to find upload element
-            $this->getElements()->each(function ($element) {
+            $this->getElements()->each(function($element) {
                 // Try to get nested - will be implemented
-                if ($element instanceof Upload && ! $this->hasHtmlAttribute('enctype')) {
+                if ($element instanceof Upload && !$this->hasHtmlAttribute('enctype')) {
                     $this->setHtmlAttribute('enctype', 'multipart/form-data');
                 }
             });
@@ -209,7 +209,7 @@ 
      */
     public function setItems($items)
     {
-        if (! is_array($items)) {
+        if (!is_array($items)) {
             $items = func_get_args();
         }
 
@@ -236,7 +236,7 @@ 
      */
     public function setId($id)
     {
-        if (is_null($this->id) && ! is_null($id) && ($model = $this->getRepository()->find($id))) {
+        if (is_null($this->id) && !is_null($id) && ($model = $this->getRepository()->find($id))) {
             $this->id = $id;
 
             parent::setModel($model);
@@ -297,7 +297,7 @@ 
      */
     public function saveForm(\Illuminate\Http\Request $request, ModelConfigurationInterface $modelConfiguration = null)
     {
-        if (! $this->validModelConfiguration($modelConfiguration)) {
+        if (!$this->validModelConfiguration($modelConfiguration)) {
             return false;
         }
 
@@ -337,7 +337,7 @@ 
     protected function saveBelongsToRelations(Model $model)
     {
         foreach ($model->getRelations() as $name => $relation) {
-            if ($model->{$name}() instanceof BelongsTo && ! is_null($relation)) {
+            if ($model->{$name}() instanceof BelongsTo && !is_null($relation)) {
                 $relation->save();
                 $model->{$name}()->associate($relation);
             }
@@ -352,7 +352,7 @@ 
     protected function saveHasOneRelations(Model $model)
     {
         foreach ($model->getRelations() as $name => $relation) {
-            if ($model->{$name}() instanceof HasOneOrMany && ! is_null($relation)) {
+            if ($model->{$name}() instanceof HasOneOrMany && !is_null($relation)) {
                 if (is_array($relation) || $relation instanceof \Traversable) {
                     $model->{$name}()->saveMany($relation);
                 } else {
@@ -370,7 +370,7 @@ 
      */
     public function validateForm(\Illuminate\Http\Request $request, ModelConfigurationInterface $modelConfiguration = null)
     {
-        if (! $this->validModelConfiguration($modelConfiguration)) {
+        if (!$this->validModelConfiguration($modelConfiguration)) {
             return;
         }
 

src/Http/Controllers/FormElementController.php

Doc Comments +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
 {
     /**
      * @param ModelConfigurationInterface $model
-     * @param null $id
+     * @param integer|null $id
      * @return JsonResponse|mixed
      */
     public function getModelLogic(ModelConfigurationInterface $model, $id = null)

Spacing +5 added lines, -5 removed lines

@@ -18,9 +18,9 @@ 
      */
     public function getModelLogic(ModelConfigurationInterface $model, $id = null)
     {
-        if (! is_null($id)) {
+        if (!is_null($id)) {
             $item = $model->getRepository()->find($id);
-            if (is_null($item) || ! $model->isEditable($item)) {
+            if (is_null($item) || !$model->isEditable($item)) {
                 return new JsonResponse([
                     'message' => trans('lang.message.access_denied'),
                 ], 403);
@@ -29,7 +29,7 @@ 
             return $model->fireEdit($id);
         }
 
-        if (! $model->isCreatable()) {
+        if (!$model->isCreatable()) {
             return new JsonResponse([
                 'message' => trans('lang.message.access_denied'),
             ], 403);
@@ -74,7 +74,7 @@ 
         }
 
         return new JsonResponse([
-            'output'   => collect($options)->map(function ($value, $key) {
+            'output'   => collect($options)->map(function($value, $key) {
                 return ['id' => $key, 'name' => $value];
             }),
             'selected' => $element->getValueFromModel(),
@@ -126,7 +126,7 @@ 
             return new JsonResponse(
                 $model::where($request->search, 'like', "%{$request->q}%")
                     ->get()
-                    ->map(function (Model $item) use ($field) {
+                    ->map(function(Model $item) use ($field) {
                         return [
                             'tag_name'    => $item->{$field},
                             'id'          => $item->id,