ProvidesScriptVariables - Code Metrics - Inspection of "New release" - LaravelRUS/SleepingOwlAdmin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b2510c...ee0bb8 )

unknown

created 2017-04-04 16:21 UTC

ProvidesScriptVariables A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
dl	0
loc	26
c	0
b	0
f	0
ccs	0
cts	14
cp	0
rs	10
wmc	2
lcom	1
cbo	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	scriptVariables()	0	18	2

<?php

namespace SleepingOwl\Admin\Configuration;

use SleepingOwl\Admin\Contracts\Template\TemplateInterface;

trait ProvidesScriptVariables
{
    /**
     * Получение массива глобальных переменных для JavaScript.
     *
     * @return array
     */
    public function scriptVariables()
    {
        $lang = trans('sleeping_owl::lang');
        if ($lang == 'sleeping_owl::lang') {
            $lang = trans('sleeping_owl::lang', [], 'messages', 'en');

        }

        return [
            'debug' => config('app.debug'),
            'env' => $this->app->environment(),
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'locale' => $this->app['translator']->getLocale(),
            'url' => $this->app['url']->to('/'),
            'lang' => $lang,
            'wysiwyg' => $this->config['wysiwyg'],
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'template' => $this->app[TemplateInterface::class]->toArray(),
            'user_id' => auth()->id(),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        ];
    }
}


GitHub Access Token became invalid

Push — master ( b2510c...ee0bb8 )

ProvidesScriptVariables A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Available Fixes

1			<?php
2
3			namespace SleepingOwl\Admin\Configuration;
4
5			use SleepingOwl\Admin\Contracts\Template\TemplateInterface;
6
7			trait ProvidesScriptVariables
8			{
9			/**
10			* Получение массива глобальных переменных для JavaScript.
11			*
12			* @return array
13			*/
14			public function scriptVariables()
15			{
16			$lang = trans('sleeping_owl::lang');
17			if ($lang == 'sleeping_owl::lang') {
18			$lang = trans('sleeping_owl::lang', [], 'messages', 'en');
			0 ignored issues – show Unused Code introduced 2017-02-11 08:58 UTC by Report Bug Copy Issue Report The call to `trans()` has too many arguments starting with `'en'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
19			}
20
21			return [
22			'debug' => config('app.debug'),
23			'env' => $this->app->environment(),
			0 ignored issues – show Bug introduced 2017-03-11 08:40 UTC by Report Bug Copy Issue Report The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			'locale' => $this->app['translator']->getLocale(),
25			'url' => $this->app['url']->to('/'),
26			'lang' => $lang,
27			'wysiwyg' => $this->config['wysiwyg'],
			0 ignored issues – show Bug introduced 2017-03-11 08:40 UTC by Report Bug Copy Issue Report The property `config` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28			'template' => $this->app[TemplateInterface::class]->toArray(),
29			'user_id' => auth()->id(),
			0 ignored issues – show Bug introduced 2017-03-11 08:40 UTC by Report Bug Copy Issue Report The method `id` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
30			];
31			}
32			}
33

LaravelRUS / SleepingOwlAdmin

GitHub Access Token became invalid

Push — master ( b2510c...ee0bb8 )

ProvidesScriptVariables A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Available Fixes

Duplication Side-by-Side

Filter issues like