SleepingOwl\Admin\Display\Column\NamedColumn

Complexity

Total Complexity

27

Size/Duplication

Total Lines	173
Duplicated Lines	2.89 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

68.97%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	2
A	getName()	0	4	1
A	setName()	0	6	1
A	getSmall()	0	4	1
A	setSmall()	0	6	1
A	getModelValue()	0	4	1
A	getModelSmallValue()	0	4	1
B	setOrderable()	0	10	5
A	toArray()	0	6	1
C	getValueFromObject()	5	50	13

<?php

namespace SleepingOwl\Admin\Display\Column;

use Closure;
use Illuminate\Support\Arr;
use Illuminate\Database\Eloquent\Model;
use SleepingOwl\Admin\Display\TableColumn;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Support\Collection as SuportCollection;
use SleepingOwl\Admin\Contracts\Display\NamedColumnInterface;
use SleepingOwl\Admin\Contracts\Display\OrderByClauseInterface;

abstract class NamedColumn extends TableColumn implements NamedColumnInterface
{
    /**
     * Column field name.
     * @var string
     */
    protected $name;

    /**
     * @var bool
     */
    protected $orderable = true;

    /**
     * @param Closure|null|string $name
     * @param null|string $label
     */
    public function __construct($name, $label = null, $small = null)
    {
        parent::__construct($label);
        $this->setName($name);

It seems like $name defined by parameter $name on line 31 can also be of type null or object<Closure>; however, SleepingOwl\Admin\Display\Column\NamedColumn::setName() does only seem to accept string, maybe add an additional type check?

        $this->setSmall($small);

        $this->setHtmlAttribute('class', 'row-'.strtolower(class_basename(get_called_class())));

        if ($this->orderable) {
            $this->setOrderable();

The method SleepingOwl\Admin\Display\Column\NamedColumn::setOrderable() has been deprecated.

        }
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @param string $name
     *
     * @return $this
     */
    public function setName($name)
    {
        $this->name = $name;

        return $this;
    }

    /**
     * @return string
     */
    public function getSmall()
    {
        return $this->small;

The property small does not exist. Did you maybe forget to declare it?

    }

    /**
     * @param string $small
     *
     * @return $this
     */
    public function setSmall($small)
    {
        $this->small = $small;

        return $this;
    }

    /**
     * @return mixed
     */
    public function getModelValue()
    {
        return $this->getValueFromObject($this->getModel(), $this->getName());
    }

    /**
     * @return mixed
     */
    public function getModelSmallValue()
    {
        return $this->getValueFromObject($this->getModel(), $this->getSmall());
    }

    /**
     * @param OrderByClauseInterface|bool $orderable
     * @deprecated
     * @return TableColumn
     */
    public function setOrderable($orderable = true)
    {
        if ($orderable !== false && ! $orderable instanceof OrderByClauseInterface) {
            if (! is_string($orderable) && ! $orderable instanceof Closure) {
                $orderable = $this->getName();
            }
        }

        return parent::setOrderable($orderable);

The method SleepingOwl\Admin\Display\TableColumn::setOrderable() has been deprecated.

    }

    /**
     * Get the instance as an array.
     *
     * @return array
     */
    public function toArray()
    {
        return parent::toArray() + [
                'name' => $this->getName(),
            ];
    }

    /**
     * Get column value from instance.
     *
     * @param Collection|Model|Closure $instance
     * @param string $name
     *
     * @return mixed
     */
    protected function getValueFromObject($instance, $name)
    {
        if ($name instanceof Closure) {
            return $name($instance);
        }

        /*
         * Implement json parsing
         */
        if (strpos($name, '.') === false && strpos($name, '->') !== false) {
            $casts = collect($instance->getCasts());

The method getCasts does only exist in Illuminate\Database\Eloquent\Model, but not in Closure and Illuminate\Database\Eloquent\Collection.

            $jsonParts = collect(explode('->', $name));

            $jsonAttr = $instance->{$jsonParts->first()};

            $cast = $casts->get($jsonParts->first(), false);

            if ($cast == 'object') {

This code seems to be duplicated across your project.

                $jsonAttr = json_decode(json_encode($jsonAttr), true);
            } elseif ($cast != 'array') {
                $jsonAttr = json_decode($jsonAttr);
            }

            return Arr::get($jsonAttr, $jsonParts->slice(1)->implode('.'));
        }

        $parts = explode('.', $name);
        $part = array_shift($parts);

        if ($instance instanceof Collection) {
            $instance = $instance->pluck($part);
        } elseif ($instance instanceof SuportCollection) {
            $instance = $instance->first();
            if ($instance instanceof Collection) {
                $instance = $instance->pluck($part);
            }

            if ($instance === null) {
                $instance = collect();
            }
        } elseif (! is_null($instance)) {
            $instance = $instance->getAttribute($part);
        }

        if (! empty($parts) && ! is_null($instance)) {
            return $this->getValueFromObject($instance, implode('.', $parts));
        }

        return $instance;
    }
}