Page::getModelConfiguration() - Code Metrics - Inspection of "hehey" - LaravelRUS/SleepingOwlAdmin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#688)

unknown

created 2017-08-07 13:46 UTC

Page::getModelConfiguration() A

↳ Parent: Page

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	0
dl	0
loc	8
ccs	3
cts	4
cp	0.75
crap	2.0625
rs	9.4285
c	0
b	0
f	0

<?php

namespace SleepingOwl\Admin\Navigation;

use SleepingOwl\Admin\Contracts\Navigation\PageInterface;
use SleepingOwl\Admin\Contracts\ModelConfigurationInterface;

class Page extends \KodiComponents\Navigation\Page implements PageInterface
{
    /**
     * Menu item related model class.
     * @var string
     */
    protected $model;

    /**
     * Menu item by url id.
     * @var string
     */
    protected $aliasId;

    /**
     * @param string|null $modelClass
     */
    public function __construct($modelClass = null)
    {
        parent::__construct();

        $this->setModel($modelClass);

        if ($this->hasModel()) {
            $this->setIcon($this->getModelConfiguration()->getIcon());
        }
    }

    /**
     * Set Alias Id.
     */
    public function setAliasId()
    {
        $url = parse_url($this->getUrl(), PHP_URL_PATH);
        if ($url) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->aliasId = md5($url);
        }
    }

    /**
     * @return string
     */
    public function getAliasId()
    {
        return $this->aliasId;
    }

    /**
     * @return ModelConfigurationInterface
     */
    public function getModelConfiguration()
    {
        if (! $this->hasModel()) {
            return;
        }

        return app('sleeping_owl')->getModel($this->model);
    }

    /**
     * @return bool
     */
    public function hasModel()
    {
        return ! is_null($this->model) && class_exists($this->model);
    }

    /**
     * @return string
     */
    public function getId()
    {
        if (is_null($this->id) && $this->hasModel()) {
            return $this->model;
        }

        return parent::getId();
    }

    /**
     * @return string
     */
    public function getTitle()
    {
        if (is_null($this->title) && $this->hasModel()) {
            return $this->getModelConfiguration()->getTitle();
        }

        return parent::getTitle();
    }

    /**
     * @return string
     */
    public function getUrl()
    {
        if (is_null($this->url) && $this->hasModel()) {
            return $this->getModelConfiguration()->getDisplayUrl();
        }

        return parent::getUrl();
    }

    /**
     * @return \Closure
     */
    public function getAccessLogic()
    {
        if (! is_callable($this->accessLogic)) {
            if ($this->hasModel()) {
                return function () {
                    return $this->getModelConfiguration()->isDisplayable();
                };
            }
        }

        return parent::getAccessLogic();
    }

    /**
     * @param string|null $view
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function render($view = null)
    {
        $data = $this->toArray();

        if (! is_null($view)) {
            return view($view, $data)->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        return app('sleeping_owl.template')->view('_partials.navigation.page', $data)->render();
    }

    /**
     * @param string $model
     *
     * @return $this
     */
    protected function setModel($model)
    {
        $this->model = $model;

        return $this;
    }
}


1		<?php
2
3		namespace SleepingOwl\Admin\Navigation;
4
5		use SleepingOwl\Admin\Contracts\Navigation\PageInterface;
6		use SleepingOwl\Admin\Contracts\ModelConfigurationInterface;
7
8		class Page extends \KodiComponents\Navigation\Page implements PageInterface
9		{
10		/**
11		* Menu item related model class.
12		* @var string
13		*/
14		protected $model;
15
16		/**
17		* Menu item by url id.
18		* @var string
19		*/
20		protected $aliasId;
21
22		/**
23		* @param string\|null $modelClass
24		*/
25	1	public function __construct($modelClass = null)
26		{
27	1	parent::__construct();
28
29	1	$this->setModel($modelClass);
30
31	1	if ($this->hasModel()) {
32	1	$this->setIcon($this->getModelConfiguration()->getIcon());
33	1	}
34	1	}
35
36		/**
37		* Set Alias Id.
38		*/
39		public function setAliasId()
40		{
41		$url = parse_url($this->getUrl(), PHP_URL_PATH);
42		if ($url) {
		0 ignored issues – show Bug Best Practice introduced 2017-08-07 14:04 UTC by Report Bug Copy Issue Report The expression `$url` of type `string\|false` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
43		$this->aliasId = md5($url);
44		}
45		}
46
47		/**
48		* @return string
49		*/
50		public function getAliasId()
51		{
52		return $this->aliasId;
53		}
54
55		/**
56		* @return ModelConfigurationInterface
57		*/
58	1	public function getModelConfiguration()
59		{
60	1	if (! $this->hasModel()) {
61		return;
62		}
63
64	1	return app('sleeping_owl')->getModel($this->model);
65		}
66
67		/**
68		* @return bool
69		*/
70	1	public function hasModel()
71		{
72	1	return ! is_null($this->model) && class_exists($this->model);
73		}
74
75		/**
76		* @return string
77		*/
78		public function getId()
79		{
80		if (is_null($this->id) && $this->hasModel()) {
81		return $this->model;
82		}
83
84		return parent::getId();
85		}
86
87		/**
88		* @return string
89		*/
90		public function getTitle()
91		{
92		if (is_null($this->title) && $this->hasModel()) {
93		return $this->getModelConfiguration()->getTitle();
94		}
95
96		return parent::getTitle();
97		}
98
99		/**
100		* @return string
101		*/
102		public function getUrl()
103		{
104		if (is_null($this->url) && $this->hasModel()) {
105		return $this->getModelConfiguration()->getDisplayUrl();
106		}
107
108		return parent::getUrl();
109		}
110
111		/**
112		* @return \Closure
113		*/
114		public function getAccessLogic()
115		{
116		if (! is_callable($this->accessLogic)) {
117		if ($this->hasModel()) {
118		return function () {
119		return $this->getModelConfiguration()->isDisplayable();
120		};
121		}
122		}
123
124		return parent::getAccessLogic();
125		}
126
127		/**
128		* @param string\|null $view
129		*
130		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
131		*/
132		public function render($view = null)
133		{
134		$data = $this->toArray();
135
136		if (! is_null($view)) {
137		return view($view, $data)->render();
		0 ignored issues – show Bug introduced 2016-07-15 12:17 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
138		}
139
140		return app('sleeping_owl.template')->view('_partials.navigation.page', $data)->render();
141		}
142
143		/**
144		* @param string $model
145		*
146		* @return $this
147		*/
148	1	protected function setModel($model)
149		{
150	1	$this->model = $model;
151
152	1	return $this;
153		}
154		}
155

LaravelRUS / SleepingOwlAdmin

GitHub Access Token became invalid

Pull Request — master (#688)

Page::getModelConfiguration() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like