LaravelRUS / SleepingOwlAdmin

src/Repository/TreeRepository.php

Doc Comments +7 added lines, -7 removed lines

@@ -203,7 +203,7 @@ 
      *
      * @param $id
      * @param $parentId
-     * @param $left
+     * @param integer $left
      * @param $right
      */
     protected function move($id, $parentId, $left, $right)
@@ -300,7 +300,7 @@ 
      * Call several methods and get first result.
      *
      * @param $instance
-     * @param $methods
+     * @param string[] $methods
      *
      * @return mixed
      * @throws Exception
@@ -320,9 +320,9 @@ 
      *
      * @param $root
      * @param $parentId
-     * @param $left
+     * @param integer $left
      *
-     * @return mixed
+     * @return integer
      */
     protected function recursiveReorder($root, $parentId, $left)
     {
@@ -341,7 +341,7 @@ 
      * Recursive reoder simple tree type.
      *
      * @param $data
-     * @param $parentId
+     * @param string|null $parentId
      */
     protected function recursiveReorderSimple(array $data, $parentId)
     {
@@ -363,7 +363,7 @@ 
      * Get children for simple tree type structure.
      *
      * @param $collection
-     * @param $id
+     * @param string|null $id
      *
      * @return Collection
      */
@@ -385,7 +385,7 @@ 
 
     /**
      * Create simple tree type structure.
-     * @return static
+     * @return Collection
      */
     protected function createSimpleTree()
     {

src/Display/Filter/FilterField.php

Spacing +2 added lines, -2 removed lines

@@ -38,8 +38,8 @@
             $relationName = implode('.', $parts);
         }
 
-        if (! is_null($relationName)) {
-            $query->whereHas($relationName, function ($q) use ($name, $value) {
+        if (!is_null($relationName)) {
+            $query->whereHas($relationName, function($q) use ($name, $value) {
                 $this->buildQuery($q, $name, $value);
             });
         } else {

src/Display/Filter/FilterCustom.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      */
     public function __construct(Closure $callback = null)
     {
-        if (! is_null($callback)) {
+        if (!is_null($callback)) {
             $this->setCallback($callback);
         }
 

src/Form/FormButtons.php

Spacing +4 added lines, -4 removed lines

@@ -313,11 +313,11 @@ 
      */
     public function isShowDeleteButton()
     {
-        if (is_null($this->getModel()->getKey()) || ! $this->showDeleteButton) {
+        if (is_null($this->getModel()->getKey()) || !$this->showDeleteButton) {
             return false;
         }
 
-        $this->showDeleteButton = ! $this->isTrashed() && $this->getModelConfiguration()->isDeletable($this->getModel());
+        $this->showDeleteButton = !$this->isTrashed() && $this->getModelConfiguration()->isDeletable($this->getModel());
 
         return $this->showDeleteButton;
     }
@@ -337,7 +337,7 @@ 
      */
     public function isShowDestroyButton()
     {
-        if (is_null($this->getModel()->getKey()) || ! $this->showDestroyButton) {
+        if (is_null($this->getModel()->getKey()) || !$this->showDestroyButton) {
             return false;
         }
 
@@ -362,7 +362,7 @@ 
      */
     public function isShowRestoreButton()
     {
-        if (is_null($this->getModel()->getKey()) || ! $this->showRestoreButton) {
+        if (is_null($this->getModel()->getKey()) || !$this->showRestoreButton) {
             return false;
         }
 

src/Display/DisplayDatatablesAsync.php

Doc Comments +3 added lines, -3 removed lines

@@ -163,7 +163,7 @@ 
     }
 
     /**
-     * @param mixed $distinct
+     * @param string|null $distinct
      *
      * @return $this
      */
@@ -206,7 +206,7 @@ 
     /**
      * Apply offset and limit to the query.
      *
-     * @param $query
+     * @param Builder $query
      */
     protected function applyOffset($query)
     {
@@ -267,7 +267,7 @@ 
     /**
      * Convert collection to the datatables structure.
      *
-     * @param array|Collection $collection
+     * @param Collection $collection
      * @param int $totalCount
      * @param int $filteredCount
      *

Unused Use Statements -3 removed lines

@@ -4,16 +4,13 @@
 
 use Request;
 use Illuminate\Routing\Router;
-use Illuminate\Http\JsonResponse;
 use Illuminate\Support\Collection;
 use Illuminate\Database\Eloquent\Builder;
 use SleepingOwl\Admin\Display\Column\Link;
 use SleepingOwl\Admin\Display\Column\Text;
 use SleepingOwl\Admin\Display\Column\Email;
 use SleepingOwl\Admin\Display\Column\Control;
-use Illuminate\Contracts\Foundation\Application;
 use SleepingOwl\Admin\Contracts\WithRoutesInterface;
-use SleepingOwl\Admin\Contracts\ModelConfigurationInterface;
 
 class DisplayDatatablesAsync extends DisplayDatatables implements WithRoutesInterface
 {

Spacing +4 added lines, -4 removed lines

@@ -27,7 +27,7 @@ 
     public static function registerRoutes(Router $router)
     {
         $routeName = 'admin.display.async';
-        if (! $router->has($routeName)) {
+        if (!$router->has($routeName)) {
             $router->get('{adminModel}/async/{adminDisplayName?}', [
                 'as' => $routeName,
                 'uses' => 'SleepingOwl\Admin\Http\Controllers\DisplayController@async'
@@ -35,7 +35,7 @@ 
         }
 
         $routeName = 'admin.display.async.inlineEdit';
-        if (! $router->has($routeName)) {
+        if (!$router->has($routeName)) {
             $router->post('{adminModel}/async/{adminDisplayName?}', [
                 'as' => $routeName,
                 'uses' => 'SleepingOwl\Admin\Http\Controllers\AdminController@inlineEdit'
@@ -145,7 +145,7 @@ 
         $totalCount = $query->count();
         $filteredCount = 0;
 
-        if (! is_null($this->distinct)) {
+        if (!is_null($this->distinct)) {
             $filteredCount = $query->distinct()->count($this->getDistinct());
         }
 
@@ -193,7 +193,7 @@ 
             return;
         }
 
-        $query->where(function ($query) use ($search) {
+        $query->where(function($query) use ($search) {
             $columns = $this->getColumns()->all();
             foreach ($columns as $column) {
                 if (in_array(get_class($column), $this->searchableColumns)) {

src/Display/TableColumn.php

Doc Comments +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
     }
 
     /**
-     * @return int
+     * @return string
      */
     public function getWidth()
     {

Spacing +3 added lines, -3 removed lines

@@ -64,7 +64,7 @@ 
     {
         $this->header = app(TableHeaderColumnInterface::class);
 
-        if (! is_null($label)) {
+        if (!is_null($label)) {
             $this->setLabel($label);
         }
 
@@ -206,7 +206,7 @@ 
             $orderable = new OrderByClause($orderable);
         }
 
-        if ($orderable !== false && ! $orderable instanceof OrderByClauseInterface) {
+        if ($orderable !== false && !$orderable instanceof OrderByClauseInterface) {
             throw new \InvalidArgumentException('Argument must be instance of SleepingOwl\Admin\Contracts\Display\OrderByClauseInterface interface');
         }
 
@@ -233,7 +233,7 @@ 
      */
     public function orderBy(Builder $query, $direction)
     {
-        if (! $this->isOrderable()) {
+        if (!$this->isOrderable()) {
             throw new \InvalidArgumentException('Argument must be instance of SleepingOwl\Admin\Contracts\Display\OrderByClauseInterface interface');
         }
 

src/Widgets/WidgetsRegistry.php

Doc Comments +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
     }
 
     /**
-     * @param $widget
+     * @param string $widget
      *
      * @return \Closure
      */

Spacing +5 added lines, -5 removed lines

@@ -54,22 +54,22 @@
         }
 
         $groupedBlocks = $this->widgets
-            ->map(function ($class) {
+            ->map(function($class) {
                 return $this->makeWidget($class);
             })
-            ->filter(function (WidgetInterface $block) {
+            ->filter(function(WidgetInterface $block) {
                 return $block->active();
             })
-            ->groupBy(function (WidgetInterface $block) {
+            ->groupBy(function(WidgetInterface $block) {
                 return $block->template();
             });
 
         foreach ($groupedBlocks as $template => $widgets) {
-            $factory->composer($template, function (View $view) use ($widgets) {
+            $factory->composer($template, function(View $view) use ($widgets) {
                 $factory = $view->getFactory();
 
                 /** @var Collection|WidgetInterface[] $widgets */
-                $widgets = $widgets->sortBy(function (WidgetInterface $block) {
+                $widgets = $widgets->sortBy(function(WidgetInterface $block) {
                     return $block->position();
                 });
 

src/Form/Element/DateRange.php

Spacing +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@ 
      */
     public function getDefaultFrom()
     {
-        if (! $this->defaultFrom) {
+        if (!$this->defaultFrom) {
             $this->defaultFrom = Carbon::now();
         }
 
@@ -53,7 +53,7 @@ 
      */
     public function getDefaultTo()
     {
-        if (! $this->defaultTo) {
+        if (!$this->defaultTo) {
             $this->defaultTo = Carbon::now();
         }
 
@@ -81,7 +81,7 @@ 
      */
     public function setValue(Model $model, $attribute, $value)
     {
-        $value = ! empty($value) ? array_map(function ($date) {
+        $value = !empty($value) ? array_map(function($date) {
             return Carbon::createFromFormat($this->getPickerFormat(), $date);
         }, explode('::', $value)) : null;
 

src/Display/Extension/Filters.php

Spacing +4 added lines, -4 removed lines

@@ -40,7 +40,7 @@ 
      */
     public function set($filters)
     {
-        if (! is_array($filters)) {
+        if (!is_array($filters)) {
             $filters = func_get_args();
         }
 
@@ -78,7 +78,7 @@ 
      */
     public function getActive()
     {
-        return $this->filters->filter(function (FilterInterface $filter) {
+        return $this->filters->filter(function(FilterInterface $filter) {
             return $filter->isActive();
         });
     }
@@ -124,7 +124,7 @@ 
      */
     public function modifyQuery(\Illuminate\Database\Eloquent\Builder $query)
     {
-        $this->getActive()->each(function (FilterInterface $filter) use ($query) {
+        $this->getActive()->each(function(FilterInterface $filter) use ($query) {
             $filter->apply($query);
         });
     }
@@ -134,7 +134,7 @@ 
      */
     public function initialize()
     {
-        $this->filters->each(function (FilterInterface $filter) {
+        $this->filters->each(function(FilterInterface $filter) {
             $filter->initialize();
         });
     }