SleepingOwl\Admin\Traits\VisibleCondition

Complexity

Total Complexity

5

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setVisibilityCondition()	0	5	1
A	setVisible()	0	5	1
A	isVisible()	0	11	3

<?php

namespace SleepingOwl\Admin\Traits;

use Closure;

trait VisibleCondition
{
    /**
     * @var Closure|null
     */
    protected $visibleCondition;

    /**
     * @return bool
     */
    public function isVisible()
    {
        if (is_bool($this->visibleCondition)) {

The condition is_bool($this->visibleCondition) is always false.

            return $this->visibleCondition;
        }

        if (is_callable($this->visibleCondition)) {
            return (bool) call_user_func($this->visibleCondition, $this->getModel());

It seems like getModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return true;
    }

    /**
     * @param Closure|bool $visibleCondition
     *
     * @return $this
     */
    public function setVisible($visibleCondition)
    {
        $this->visibleCondition = $visibleCondition;

It seems like $visibleCondition can also be of type boolean. However, the property $visibleCondition is declared as type Closure|null. Maybe add an additional type check?

        return $this;
    }

    /**
     * @param Closure $condition
     *
     * @return $this
     */
    public function setVisibilityCondition(Closure $condition)
    {
        $this->visibleCondition = $condition;

        return $this;
    }
}