SleepingOwl\Admin\Traits\EditableReadonlyTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getReadonly()	0	3	2
A	setReadonly()	0	5	1

<?php

namespace SleepingOwl\Admin\Traits;

trait EditableReadonlyTrait
{
    /**
     * @var bool
     */
    protected $readonlyEditable = false;

    /**
     * @return mixed
     */
    public function getReadonly()
    {
        return $this->getModelConfiguration()->isEditable($this->getModel()) && ! $this->readonlyEditable;

It seems like getModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like getModelConfiguration() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param Closure|bool $readonlyEditable

The type SleepingOwl\Admin\Traits\Closure was not found. Did you mean Closure? If so, make sure to prefix the type with \.

     *
     * @return $this
     */
    public function setReadonly($readonlyEditable)
    {
        $this->readonlyEditable = $readonlyEditable;

It seems like $readonlyEditable can also be of type SleepingOwl\Admin\Traits\Closure. However, the property $readonlyEditable is declared as type boolean. Maybe add an additional type check?

        return $this;
    }
}