LaravelRUS / SleepingOwlAdmin

src/Display/Extension/ColumnFilters.php

Spacing +4 added lines, -4 removed lines

@@ -35,7 +35,7 @@ 
      */
     public function set($columnFilters)
     {
-        if (! is_array($columnFilters)) {
+        if (!is_array($columnFilters)) {
             $columnFilters = func_get_args();
         }
 
@@ -173,13 +173,13 @@ 
 
         $display = $this->getDisplay();
 
-        if (! $display->getExtensions()->has('columns')) {
+        if (!$display->getExtensions()->has('columns')) {
             return;
         }
 
         $columns = $display->getColumns()->all();
 
-        if (! is_int(key($search))) {
+        if (!is_int(key($search))) {
             $search = [$search];
         }
 
@@ -216,7 +216,7 @@ 
 
     protected function prepareView()
     {
-        if (! in_array($this->getPlacement(), ['table.footer', 'table.header']) && $this->view == 'display.extensions.columns_filters_table') {
+        if (!in_array($this->getPlacement(), ['table.footer', 'table.header']) && $this->view == 'display.extensions.columns_filters_table') {
             $this->view = 'display.extensions.columns_filters';
             $this->setHtmlAttribute('class', 'table table-default');
         }

src/Display/DisplayTable.php

Spacing +3 added lines, -3 removed lines

@@ -70,7 +70,7 @@ 
         parent::initialize();
 
         if ($this->getModelConfiguration()->isRestorableModel()) {
-            $this->setApply(function ($q) {
+            $this->setApply(function($q) {
                 return $q->withTrashed();
             });
         }
@@ -192,11 +192,11 @@ 
      */
     public function getCollection()
     {
-        if (! $this->isInitialized()) {
+        if (!$this->isInitialized()) {
             throw new \Exception('Display is not initialized');
         }
 
-        if (! is_null($this->collection)) {
+        if (!is_null($this->collection)) {
             return $this->collection;
         }
 

Indentation -1 removed lines

@@ -12,7 +12,6 @@
 
 /**
  * Class DisplayTable.
-
  * @method Columns getColumns()
  * @method $this setColumns(ColumnInterface|ColumnInterface[] $column)
  *

src/Display/ExtensionCollection.php

Spacing +5 added lines, -5 removed lines

@@ -15,7 +15,7 @@ 
      */
     public function placable()
     {
-        return $this->filter(function (DisplayExtensionInterface $extension) {
+        return $this->filter(function(DisplayExtensionInterface $extension) {
             return $extension instanceof Placable;
         });
     }
@@ -42,7 +42,7 @@ 
      */
     public function renderable()
     {
-        return $this->filter(function (DisplayExtensionInterface $extension) {
+        return $this->filter(function(DisplayExtensionInterface $extension) {
             return $extension instanceof Renderable;
         });
     }
@@ -52,7 +52,7 @@ 
      */
     public function sortByOrder()
     {
-        return $this->sortBy(function (DisplayExtensionInterface $extension) {
+        return $this->sortBy(function(DisplayExtensionInterface $extension) {
             return $extension->getOrder();
         });
     }
@@ -62,7 +62,7 @@ 
      */
     public function initialize()
     {
-        $this->each(function (DisplayExtensionInterface $extension) {
+        $this->each(function(DisplayExtensionInterface $extension) {
             if ($extension instanceof Initializable) {
                 $extension->initialize();
             }
@@ -76,7 +76,7 @@ 
      */
     public function modifyQuery(\Illuminate\Database\Eloquent\Builder $query)
     {
-        $this->each(function (DisplayExtensionInterface $extension) use ($query) {
+        $this->each(function(DisplayExtensionInterface $extension) use ($query) {
             $extension->modifyQuery($query);
         });
 

src/Traits/FormElements.php

Spacing +8 added lines, -8 removed lines

@@ -23,7 +23,7 @@ 
      */
     public function initializeElements()
     {
-        $this->getElements()->each(function ($element) {
+        $this->getElements()->each(function($element) {
             if ($element instanceof Initializable) {
                 $element->initialize();
             }
@@ -41,7 +41,7 @@ 
 
         foreach ($this->getElements() as $element) {
             if ($element instanceof ElementsInterface) {
-                if (! is_null($found = $element->getElement($path))) {
+                if (!is_null($found = $element->getElement($path))) {
                     return $found;
                 }
             }
@@ -145,7 +145,7 @@ 
      */
     protected function setModelForElements(Model $model)
     {
-        $this->getElements()->each(function ($element) use ($model) {
+        $this->getElements()->each(function($element) use ($model) {
             $element = $this->getElementContainer($element);
 
             if ($element instanceof WithModel) {
@@ -163,7 +163,7 @@ 
      */
     protected function getValidationRulesFromElements(array $rules = [])
     {
-        $this->getElements()->onlyActive()->each(function ($element) use (&$rules) {
+        $this->getElements()->onlyActive()->each(function($element) use (&$rules) {
             $element = $this->getElementContainer($element);
 
             if ($element instanceof Validable) {
@@ -181,7 +181,7 @@ 
      */
     protected function getValidationMessagesForElements(array $messages = [])
     {
-        $this->getElements()->onlyActive()->each(function ($element) use (&$messages) {
+        $this->getElements()->onlyActive()->each(function($element) use (&$messages) {
             $element = $this->getElementContainer($element);
 
             if ($element instanceof Validable) {
@@ -199,7 +199,7 @@ 
      */
     protected function getValidationLabelsForElements(array $labels = [])
     {
-        $this->getElements()->onlyActive()->each(function ($element) use (&$labels) {
+        $this->getElements()->onlyActive()->each(function($element) use (&$labels) {
             $element = $this->getElementContainer($element);
 
             if ($element instanceof Validable) {
@@ -217,7 +217,7 @@ 
      */
     protected function saveElements(\Illuminate\Http\Request $request)
     {
-        $this->getElements()->onlyActive()->each(function ($element) use ($request) {
+        $this->getElements()->onlyActive()->each(function($element) use ($request) {
             $element = $this->getElementContainer($element);
 
             if ($element instanceof FormElementInterface) {
@@ -233,7 +233,7 @@ 
      */
     protected function afterSaveElements(\Illuminate\Http\Request $request)
     {
-        $this->getElements()->onlyActive()->each(function ($element) use ($request) {
+        $this->getElements()->onlyActive()->each(function($element) use ($request) {
             $element = $this->getElementContainer($element);
 
             if ($element instanceof FormElementInterface) {

src/Display/DisplayDatatablesAsync.php

Doc Comments +3 added lines, -3 removed lines

@@ -118,7 +118,7 @@ 
     }
 
     /**
-     * @param mixed $distinct
+     * @param string|null $distinct
      *
      * @return $this
      */
@@ -162,7 +162,7 @@ 
     /**
      * Apply offset and limit to the query.
      *
-     * @param $query
+     * @param Builder $query
      * @param \Illuminate\Http\Request $request
      */
     protected function applyOffset($query, \Illuminate\Http\Request $request)
@@ -204,7 +204,7 @@ 
      * Convert collection to the datatables structure.
      *
      * @param \Illuminate\Http\Request $request
-     * @param array|Collection $collection
+     * @param Collection $collection
      * @param int $totalCount
      * @param int $filteredCount
      *

Spacing +4 added lines, -4 removed lines

@@ -26,7 +26,7 @@ 
     public static function registerRoutes(Router $router)
     {
         $routeName = 'admin.display.async';
-        if (! $router->has($routeName)) {
+        if (!$router->has($routeName)) {
             $router->get('{adminModel}/async/{adminDisplayName?}', [
                 'as'   => $routeName,
                 'uses' => 'SleepingOwl\Admin\Http\Controllers\DisplayController@async',
@@ -34,7 +34,7 @@ 
         }
 
         $routeName = 'admin.display.async.inlineEdit';
-        if (! $router->has($routeName)) {
+        if (!$router->has($routeName)) {
             $router->post('{adminModel}/async/{adminDisplayName?}', [
                 'as'   => $routeName,
                 'uses' => 'SleepingOwl\Admin\Http\Controllers\AdminController@inlineEdit',
@@ -175,7 +175,7 @@ 
         $totalCount = $query->count();
         $filteredCount = 0;
 
-        if (! is_null($this->distinct)) {
+        if (!is_null($this->distinct)) {
             $filteredCount = $query->distinct()->count($this->getDistinct());
         }
 
@@ -223,7 +223,7 @@ 
             return;
         }
 
-        $query->where(function ($query) use ($search) {
+        $query->where(function($query) use ($search) {
             $columns = $this->getColumns()->all();
 
             foreach ($columns as $column) {

src/Http/Controllers/AdminController.php

Doc Comments +2 added lines, -2 removed lines

@@ -311,7 +311,7 @@ 
      * @param ModelConfigurationInterface $model
      * @param Request $request
      *
-     * @return bool
+     * @return boolean|null
      *
      * @throws \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
      */
@@ -534,7 +534,7 @@ 
     /**
      * @param Request $request
      *
-     * @return null|string
+     * @return string
      */
     protected function getBackUrl(Request $request)
     {

Spacing +21 added lines, -21 removed lines

@@ -54,8 +54,8 @@ 
 
         $admin->navigation()->setCurrentUrl($request->getUri());
 
-        if (! $this->breadcrumbs->exists('home')) {
-            $this->breadcrumbs->register('home', function ($breadcrumbs) {
+        if (!$this->breadcrumbs->exists('home')) {
+            $this->breadcrumbs->register('home', function($breadcrumbs) {
                 $breadcrumbs->push(trans('sleeping_owl::lang.dashboard'), route('admin.dashboard'));
             });
         }
@@ -76,8 +76,8 @@ 
         }
 
         foreach ($breadcrumbs as  $breadcrumb) {
-            if (! $this->breadcrumbs->exists($breadcrumb['id'])) {
-                $this->breadcrumbs->register($breadcrumb['id'], function ($breadcrumbs) use ($breadcrumb) {
+            if (!$this->breadcrumbs->exists($breadcrumb['id'])) {
+                $this->breadcrumbs->register($breadcrumb['id'], function($breadcrumbs) use ($breadcrumb) {
                     $breadcrumbs->parent($breadcrumb['parent']);
                     $breadcrumbs->push($breadcrumb['title'], $breadcrumb['url']);
                 });
@@ -121,7 +121,7 @@ 
      */
     public function getDisplay(ModelConfigurationInterface $model)
     {
-        if (! $model->isDisplayable()) {
+        if (!$model->isDisplayable()) {
             abort(404);
         }
 
@@ -137,7 +137,7 @@ 
      */
     public function getCreate(ModelConfigurationInterface $model)
     {
-        if (! $model->isCreatable()) {
+        if (!$model->isCreatable()) {
             abort(404);
         }
 
@@ -156,7 +156,7 @@ 
      */
     public function postStore(ModelConfigurationInterface $model, Request $request)
     {
-        if (! $model->isCreatable()) {
+        if (!$model->isCreatable()) {
             abort(404);
         }
 
@@ -194,7 +194,7 @@ 
             $redirectPolicy = $model->getRedirect();
 
             /* Make redirect when use in model config && Fix editable redirect */
-            if ($redirectPolicy->get('create') == 'display' || ! $model->isEditable($newModel)) {
+            if ($redirectPolicy->get('create') == 'display' || !$model->isEditable($newModel)) {
                 $redirectUrl = $model->getDisplayUrl();
             }
 
@@ -233,7 +233,7 @@ 
     {
         $item = $model->getRepository()->find($id);
 
-        if (is_null($item) || ! $model->isEditable($item)) {
+        if (is_null($item) || !$model->isEditable($item)) {
             abort(404);
         }
 
@@ -257,7 +257,7 @@ 
         $editForm = $model->fireEdit($id);
         $item = $editForm->getModel();
 
-        if (is_null($item) || ! $model->isEditable($item)) {
+        if (is_null($item) || !$model->isEditable($item)) {
             abort(404);
         }
 
@@ -336,7 +336,7 @@ 
 
         /* @var ColumnEditableInterface|null $column */
         if (is_callable([$display, 'getColumns'])) {
-            $column = $display->getColumns()->all()->filter(function ($column) use ($field) {
+            $column = $display->getColumns()->all()->filter(function($column) use ($field) {
                 return ($column instanceof ColumnEditableInterface) and $field == $column->getName();
             })->first();
         } else {
@@ -345,7 +345,7 @@ 
                     $content = $tab->getContent();
 
                     if ($content instanceof DisplayTable) {
-                        $column = $content->getColumns()->all()->filter(function ($column) use ($field) {
+                        $column = $content->getColumns()->all()->filter(function($column) use ($field) {
                             return ($column instanceof ColumnEditableInterface) and $field == $column->getName();
                         })->first();
                     }
@@ -354,7 +354,7 @@ 
 
                             //Return data-table if inside FormElements
                             if ($element instanceof DisplayTable) {
-                                $column = $element->getColumns()->all()->filter(function ($column) use ($field) {
+                                $column = $element->getColumns()->all()->filter(function($column) use ($field) {
                                     return ($column instanceof ColumnEditableInterface) and $field == $column->getName();
                                 })->first();
                             }
@@ -363,7 +363,7 @@ 
                             if ($element instanceof Column) {
                                 foreach ($element->getElements() as $columnElement) {
                                     if ($columnElement instanceof DisplayTable) {
-                                        $column = $columnElement->getColumns()->all()->filter(function ($column) use ($field) {
+                                        $column = $columnElement->getColumns()->all()->filter(function($column) use ($field) {
                                             return ($column instanceof ColumnEditableInterface) and $field == $column->getName();
                                         })->first();
                                     }
@@ -382,7 +382,7 @@ 
         $repository = $model->getRepository();
         $item = $repository->find($id);
 
-        if (is_null($item) || ! $model->isEditable($item)) {
+        if (is_null($item) || !$model->isEditable($item)) {
             abort(404);
         }
 
@@ -409,7 +409,7 @@ 
     {
         $item = $model->getRepository()->find($id);
 
-        if (is_null($item) || ! $model->isDeletable($item)) {
+        if (is_null($item) || !$model->isDeletable($item)) {
             abort(404);
         }
 
@@ -438,13 +438,13 @@ 
      */
     public function deleteDestroy(ModelConfigurationInterface $model, Request $request, $id)
     {
-        if (! $model->isRestorableModel()) {
+        if (!$model->isRestorableModel()) {
             abort(404);
         }
 
         $item = $model->getRepository()->findOnlyTrashed($id);
 
-        if (is_null($item) || ! $model->isRestorable($item)) {
+        if (is_null($item) || !$model->isRestorable($item)) {
             abort(404);
         }
 
@@ -473,13 +473,13 @@ 
      */
     public function postRestore(ModelConfigurationInterface $model, Request $request, $id)
     {
-        if (! $model->isRestorableModel()) {
+        if (!$model->isRestorableModel()) {
             abort(404);
         }
 
         $item = $model->getRepository()->findOnlyTrashed($id);
 
-        if (is_null($item) || ! $model->isRestorable($item)) {
+        if (is_null($item) || !$model->isRestorable($item)) {
             abort(404);
         }
 
@@ -564,7 +564,7 @@ 
      */
     protected function registerBreadcrumb($title, $parent)
     {
-        $this->breadcrumbs->register('render', function ($breadcrumbs) use ($title, $parent) {
+        $this->breadcrumbs->register('render', function($breadcrumbs) use ($title, $parent) {
             $breadcrumbs->parent($parent);
             $breadcrumbs->push($title);
         });

src/Templates/Breadcrumbs.php

Spacing +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
             list($name, $params) = $this->currentRoute->get();
         }
 
-        if (! $this->exists($name)) {
+        if (!$this->exists($name)) {
             return '';
         }
 
@@ -60,7 +60,7 @@ 
      */
     public function renderIfExistsArray($name, $params = [])
     {
-        if (! $this->exists($name)) {
+        if (!$this->exists($name)) {
             return '';
         }
 

src/Display/Filter/FilterCustom.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
     {
         parent::__construct($name, $title);
 
-        if (! is_null($callback)) {
+        if (!is_null($callback)) {
             $this->setCallback($callback);
         }
     }

src/Display/Column/Custom.php

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
     public function __construct($label = null, Closure $callback = null)
     {
         parent::__construct($label);
-        if (! is_null($callback)) {
+        if (!is_null($callback)) {
             $this->setCallback($callback);
         }
     }
@@ -66,7 +66,7 @@ 
      */
     public function getModelValue()
     {
-        if (! is_callable($callback = $this->getCallback())) {
+        if (!is_callable($callback = $this->getCallback())) {
             throw new \Exception('Invalid custom column callback');
         }