Total Lines | 63 |
Code Lines | 40 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
5 | $router->group(['as' => 'admin.', 'namespace' => 'SleepingOwl\Admin\Http\Controllers'], function (Router $router) { |
||
6 | 285 | if (! $router->has('admin.dashboard')) { |
|
7 | 285 | $router->get('', ['as' => 'dashboard', 'uses' => 'AdminController@getDashboard']); |
|
|
|||
8 | 285 | } |
|
9 | |||
10 | 285 | $router->get('{adminModel}', [ |
|
11 | 285 | 'as' => 'model', |
|
12 | 285 | 'uses' => 'AdminController@getDisplay', |
|
13 | 285 | ]); |
|
14 | |||
15 | 285 | $router->post('{adminModel}', [ |
|
16 | 285 | 'as' => 'model', |
|
17 | 285 | 'uses' => 'AdminController@inlineEdit', |
|
18 | 285 | ]); |
|
19 | |||
20 | 285 | $router->get('{adminModel}/create', [ |
|
21 | 285 | 'as' => 'model.create', |
|
22 | 285 | 'uses' => 'AdminController@getCreate', |
|
23 | 285 | ]); |
|
24 | |||
25 | 285 | $router->post('{adminModel}/create', [ |
|
26 | 285 | 'as' => 'model.store', |
|
27 | 285 | 'uses' => 'AdminController@postStore', |
|
28 | 285 | ]); |
|
29 | |||
30 | 285 | $router->get('{adminModel}/{adminModelId?}/edit', [ |
|
31 | 285 | 'as' => 'model.edit', |
|
32 | 285 | 'uses' => 'AdminController@getEdit', |
|
33 | 285 | ]); |
|
34 | |||
35 | 285 | $router->post('{adminModel}/{adminModelId?}/edit', [ |
|
36 | 285 | 'as' => 'model.update', |
|
37 | 285 | 'uses' => 'AdminController@postUpdate', |
|
38 | 285 | ]); |
|
39 | |||
40 | 285 | $router->delete('{adminModel}/{adminModelId?}/delete', [ |
|
41 | 285 | 'as' => 'model.delete', |
|
42 | 285 | 'uses' => 'AdminController@deleteDelete', |
|
43 | 285 | ]); |
|
44 | |||
45 | 285 | $router->delete('{adminModel}/{adminModelId?}/destroy', [ |
|
46 | 285 | 'as' => 'model.destroy', |
|
47 | 285 | 'uses' => 'AdminController@deleteDestroy', |
|
48 | 285 | ]); |
|
49 | |||
50 | 285 | $router->post('{adminModel}/{adminModelId?}/restore', [ |
|
51 | 285 | 'as' => 'model.restore', |
|
52 | 285 | 'uses' => 'AdminController@postRestore', |
|
53 | 285 | ]); |
|
54 | |||
55 | 285 | $router->get('{adminWildcard}', [ |
|
56 | 285 | 'as' => 'wildcard', |
|
57 | 285 | 'uses' => 'AdminController@getWildcard', |
|
58 | 285 | ]); |
|
59 | 285 | ||
60 | $router->group(['middleware' => config('sleeping_owl.env_editor_middlewares')], function (Router $router) { |
||
61 | $router->get(config('sleeping_owl.env_editor_url'), [ |
||
62 | 'as' => 'env.editor', |
||
63 | 'uses' => 'AdminController@getEnvEditor', |
||
64 | ]); |
||
65 | $router->post(config('sleeping_owl.env_editor_url'), [ |
||
66 | 'as' => 'env.editor.post', |
||
67 | 'uses' => 'AdminController@postEnvEditor', |
||
68 | ]); |
||
71 |
If there is a route defined but the controller class cannot be found there are two options: 1. the controller class needs to be implemented or 2. the route is outdated and can be removed.
If ?FooController? was found and ?BarController? is missing for the following example, either the controller should be implemented or the route should be removed: