RelatedLink::setModel() - Code Metrics - LaravelRUS/SleepingOwlAdmin - Measure and Improve Code Quality continuously with Scrutinizer

RelatedLink::setModel() A
last analyzed 2020-05-02 17:28 UTC

↳ Parent: RelatedLink

Complexity

Conditions	4
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
cc	4
eloc	10
nc	2
nop	1
dl	0
loc	18
ccs	0
cts	14
cp	0
crap	20
rs	9.9332
c	0
b	0
f	0

<?php

namespace SleepingOwl\Admin\Display\Column;

use Illuminate\Database\Eloquent\Model;

class RelatedLink extends Link
{
    /**
     * @var string
     */
    protected $view = 'column.link';

    /**
     * @var string
     */
    protected $originalName;

    /**
     * @var bool
     */
    protected $orderable = false;

    /**
     * @param \Closure|null|string $name
     * @param null|string $label
     */
    public function __construct($name, $label = null, $small = null)
    {
        parent::__construct($name, $label, $small);
        $this->originalName = $name;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * @param Model $model
     *
     * @return Link
     */
    public function setModel(Model $model)
    {
        if (strpos($this->originalName, '.') !== false) {
            $parts = explode('.', $this->originalName);
            $name = array_pop($parts);

            while ($parts) {
                $part = array_shift($parts);
                $relation = $model->getAttribute($part);

                if ($relation instanceof Model) {
                    $model = $relation;
                    $this->setName($name);
                }
            }
        }

        return parent::setModel($model);
    }
}


1			<?php
2
3			namespace SleepingOwl\Admin\Display\Column;
4
5			use Illuminate\Database\Eloquent\Model;
6
7			class RelatedLink extends Link
8			{
9			/**
10			* @var string
11			*/
12			protected $view = 'column.link';
13
14			/**
15			* @var string
16			*/
17			protected $originalName;
18
19			/**
20			* @var bool
21			*/
22			protected $orderable = false;
23
24			/**
25			* @param \Closure\|null\|string $name
26			* @param null\|string $label
27			*/
28			public function __construct($name, $label = null, $small = null)
29			{
30			parent::__construct($name, $label, $small);
31			$this->originalName = $name;
			0 ignored issues – show Documentation Bug introduced 2018-05-21 21:05 UTC by Report Bug Copy Issue Report It seems like `$name` can also be of type `Closure`. However, the property `$originalName` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
32			}
33
34			/**
35			* @param Model $model
36			*
37			* @return Link
38			*/
39			public function setModel(Model $model)
40			{
41			if (strpos($this->originalName, '.') !== false) {
42			$parts = explode('.', $this->originalName);
43			$name = array_pop($parts);
44
45			while ($parts) {
46			$part = array_shift($parts);
47			$relation = $model->getAttribute($part);
48
49			if ($relation instanceof Model) {
50			$model = $relation;
51			$this->setName($name);
52			}
53			}
54			}
55
56			return parent::setModel($model);
57			}
58			}
59

LaravelRUS / SleepingOwlAdmin

GitHub Access Token became invalid

RelatedLink::setModel() A last analyzed 2020-05-02 17:28 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RelatedLink::setModel() A
last analyzed 2020-05-02 17:28 UTC