Fetch::getIterator() - Code Metrics - Inspection of "Improve sources" - LaravelRUS/GitterBot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 74c577...c1ce98 )

by Kirill

created 2016-04-09 11:54 UTC

Fetch::getIterator() A

↳ Parent: Fetch

Complexity

Conditions	3
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	15
rs	9.4285
cc	3
eloc	10
nc	2
nop	0

<?php
declare(strict_types = 1);
/**
 * This file is part of Ai package.
 *
 * @author Serafim <[email protected]>
 * @date 28.03.2016 14:02
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */


namespace Core\Lazy;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Builder;

/**
 * Class Fetch
 * @package Core\Lazy
 */
class Fetch implements \IteratorAggregate
{
    const DEFAULT_CHUNK_SIZE = 1000;

    /**
     * @var int
     */
    private $chunk = self::DEFAULT_CHUNK_SIZE;

    /**
     * @var Builder
     */
    private $builder;

    /**
     * Fetch constructor.
     * @param Builder $builder
     * @param int $chunk
     */
    public function __construct(Builder $builder, $chunk = self::DEFAULT_CHUNK_SIZE)
    {
        $this->builder = $builder;
        $this->chunk = $chunk;
    }

    /**
     * @return \Generator
     */
    public function getIterator()
    {
        /** @var Builder|\Illuminate\Database\Query\Builder|Model $query */
        $query = clone $this->builder;

        $skip  = 0;
        $count = $query->count();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        do {
            $items = $query->skip($skip)->take($this->chunk)->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            foreach ($items as $item) {
                yield $item;
            }
            $skip += $this->chunk;
        } while ($skip < $count + $this->chunk);
    }
}


Push — master ( 74c577...c1ce98 )

Fetch::getIterator() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2			declare(strict_types = 1);
3			/**
4			* This file is part of Ai package.
5			*
6			* @author Serafim <[email protected]>
7			* @date 28.03.2016 14:02
8			*
9			* For the full copyright and license information, please view the LICENSE
10			* file that was distributed with this source code.
11			*/
12
13
14			namespace Core\Lazy;
15
16			use Illuminate\Database\Eloquent\Model;
17			use Illuminate\Database\Eloquent\Builder;
18
19			/**
20			* Class Fetch
21			* @package Core\Lazy
22			*/
23			class Fetch implements \IteratorAggregate
24			{
25			const DEFAULT_CHUNK_SIZE = 1000;
26
27			/**
28			* @var int
29			*/
30			private $chunk = self::DEFAULT_CHUNK_SIZE;
31
32			/**
33			* @var Builder
34			*/
35			private $builder;
36
37			/**
38			* Fetch constructor.
39			* @param Builder $builder
40			* @param int $chunk
41			*/
42			public function __construct(Builder $builder, $chunk = self::DEFAULT_CHUNK_SIZE)
43			{
44			$this->builder = $builder;
45			$this->chunk = $chunk;
46			}
47
48			/**
49			* @return \Generator
50			*/
51			public function getIterator()
52			{
53			/** @var Builder\|\Illuminate\Database\Query\Builder\|Model $query */
54			$query = clone $this->builder;
55
56			$skip = 0;
57			$count = $query->count();
			0 ignored issues – show Bug introduced 2016-04-09 12:00 UTC by Report Bug Copy Issue Report The method `count` does only exist in `Illuminate\Database\Query\Builder`, but not in `Illuminate\Database\Eloquent\Builder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
58			do {
59			$items = $query->skip($skip)->take($this->chunk)->get();
			0 ignored issues – show Bug introduced 2016-04-09 12:00 UTC by Report Bug Copy Issue Report The method `skip` does only exist in `Illuminate\Database\Query\Builder`, but not in `Illuminate\Database\Eloquent\Builder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
60			foreach ($items as $item) {
61			yield $item;
62			}
63			$skip += $this->chunk;
64			} while ($skip < $count + $this->chunk);
65			}
66			}
67

LaravelRUS / GitterBot

Push — master ( 74c577...c1ce98 )

Fetch::getIterator() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like