AbstractRoom::createSubscribersStorage() - Code Metrics - Inspection of "Merge pull request #78 from butschster/feature/bot..." - LaravelRUS/GitterBot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d56647...5f1d83 )

by Kirill

created 2016-07-21 19:52 UTC

AbstractRoom::createSubscribersStorage() A

↳ Parent: AbstractRoom

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	7
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	13
rs	9.4285

<?php
/**
 * This file is part of GitterBot package.
 *
 * @author butschster <[email protected]>
 * @date   20.07.2016 15:27
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Domains\Room;

use Domains\Bot\ClientInterface;
use Illuminate\Foundation\Application;
use Interfaces\Gitter\Client;

abstract class AbstractRoom implements RoomInterface
{
    /**
     * @var string
     */
    protected $id;

    /**
     * @var string
     */
    protected $alias;

    /**
     * @var array
     */
    protected $groups;

    /**
     * @var \Domains\Middleware\Storage
     */
    protected $middleware;

    /**
     * @var ClientInterface
     */
    protected $client;

    /**
     * @var Application
     */
    protected $app;

    public function __construct()
    {
        $this->app = \App::make('app');

        $this->middleware = new \Domains\Middleware\Storage(
            $this->app
        );

        $this->client = app('bot.manager')->driver($this->driver());

        $this->createSubscribersStorage();
    }

    /**
     * @return string
     */
    public function id()
    {
        return $this->id;
    }

    /**
     * @return string
     */
    public function alias()
    {
        return $this->alias;
    }

    /**
     * @return array
     */
    public function groups()
    {
        return (array) $this->groups;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return ClientInterface
     */
    public function client()
    {
        return $this->client;
    }

    /**
     * @return \Domains\Middleware\Storage
     */
    public function middleware()
    {
        return $this->middleware;
    }

    /**
     * Create subscribers storage
     */
    protected function createSubscribersStorage()
    {
        $subscribers = \Config::get('gitter.subscribers');

        $storage = new \Domains\Subscriber\Storage(
            $this->app,
            $this
        );

        foreach ($subscribers as $subscriber) {
            $storage->add($subscriber);
        }
    }

    /**
     * Create middleware storage
     *
     * @param array $groups
     */
    protected function setMiddleware(array $groups)
    {
        $registerAll = in_array('*', $this->groups());

        foreach ($groups as $group => $middleware) {
            if (is_array($middleware)) {
                if ($registerAll or in_array($group, $this->groups())) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                    foreach ($middleware as $class) {
                        $this->middleware->add($class);
                    }
                }
            } else {

                $this->middleware->add($group);
            }
        }
    }

    /**
     * @return Client
     */
    public function listen()
    {
        $this->client()->listen($this);
    }

    /**
     * @param string $message
     * @return $this
     */
    public function sendMessage($message)
    {
        $this->client()->sendMessage($this, $message);
    }
}

LaravelRUS / GitterBot

Push — master ( d56647...5f1d83 )

AbstractRoom::createSubscribersStorage() A

Complexity

Size

Duplication

Importance

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like