NewGoogleSearchMiddleware::__construct() - Code Metrics - Inspection of "Feature/bots integration" - LaravelRUS/GitterBot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#78)

by butschster

created 2016-07-21 14:39 UTC

NewGoogleSearchMiddleware::__construct() A

↳ Parent: NewGoogleSearchMiddleware

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	4
rs	10

<?php
namespace Domains\Bot\Middlewares;

use Domains\Message;
use Domains\Middleware\MiddlewareInterface;
use Illuminate\Config\Repository;
use Illuminate\Support\Collection;
use Interfaces\Google\GoogleSearch;

/**
 * Class GoogleSearchMiddleware
 */
class NewGoogleSearchMiddleware implements MiddlewareInterface
{
    /**
     * @var GoogleSearch
     */
    private $search;

    /**
     * GoogleSearchMiddleware constructor.
     *
     * @param Repository $config
     */
    public function __construct(Repository $config)
    {
        $this->search = new GoogleSearch($config);
    }

    /**
     * @param Message $message
     *
     * @return array
     */
    public function handle(Message $message)
    {
        $query = $this->getGoogleQuery($message);
        if ($query) {
            $search = '';
            try {
                $search = $this->search->searchGetMessage($query);
            } catch (\Throwable $e) {

            }

            $hasMentions = count($message->mentions);
            $mention = null;

            if ($hasMentions) {

                $mention = $message->mentions[0]->login === \Auth::user()->login ? $message->user : $message->mentions[0];
            }

            if (count($message->mentions)) {
                $answerTo = $message->user;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

                $message->answer(trans('google.personal', [
                    'user' => $mention->login,
                    'query' => urlencode($query),
                ]).PHP_EOL.$search);
            }

            $message->answer(trans('google.common', [
                'query' => urlencode($query),
            ]).PHP_EOL.$search);
        }

        return $message;
    }

    /**
     * @param Message $message
     *
     * @return string
     */
    private function getGoogleQuery(Message $message) : string
    {
        $words = (new Collection(trans('google.queries')))->map('preg_quote')->implode('|');
        $pattern = sprintf('/^(?:@.*?\s)?(?:%s)\s(.*?)$/isu', $words);
        $found = preg_match($pattern, $message->text, $matches);
        if ($found) {
            return trim($matches[1]);
        }

        return '';
    }
}


1		<?php
2		namespace Domains\Bot\Middlewares;
3
4		use Domains\Message;
5		use Domains\Middleware\MiddlewareInterface;
6		use Illuminate\Config\Repository;
7		use Illuminate\Support\Collection;
8		use Interfaces\Google\GoogleSearch;
9
10		/**
11		* Class GoogleSearchMiddleware
12		*/
13		class NewGoogleSearchMiddleware implements MiddlewareInterface
14		{
15		/**
16		* @var GoogleSearch
17		*/
18		private $search;
19
20		/**
21		* GoogleSearchMiddleware constructor.
22		*
23		* @param Repository $config
24		*/
25		public function __construct(Repository $config)
26		{
27		$this->search = new GoogleSearch($config);
28		}
29
30		/**
31		* @param Message $message
32		*
33		* @return array
34		*/
35		public function handle(Message $message)
36		{
37		$query = $this->getGoogleQuery($message);
38		if ($query) {
39		$search = '';
40		try {
41		$search = $this->search->searchGetMessage($query);
42		} catch (\Throwable $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-07-21 14:52 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
43		}
44
45		$hasMentions = count($message->mentions);
46		$mention = null;
47
48	View Code Duplication	if ($hasMentions) {
		0 ignored issues – show Duplication introduced 2016-07-21 14:52 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		$mention = $message->mentions[0]->login === \Auth::user()->login ? $message->user : $message->mentions[0];
50		}
51
52		if (count($message->mentions)) {
53		$answerTo = $message->user;
		0 ignored issues – show Unused Code introduced 2016-07-21 14:52 UTC by Report Bug Copy Issue Report `$answerTo` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
54
55		$message->answer(trans('google.personal', [
56		'user' => $mention->login,
57		'query' => urlencode($query),
58		]).PHP_EOL.$search);
59		}
60
61		$message->answer(trans('google.common', [
62		'query' => urlencode($query),
63		]).PHP_EOL.$search);
64		}
65
66		return $message;
67		}
68
69		/**
70		* @param Message $message
71		*
72		* @return string
73		*/
74		private function getGoogleQuery(Message $message) : string
75		{
76		$words = (new Collection(trans('google.queries')))->map('preg_quote')->implode('\|');
77		$pattern = sprintf('/^(?:@.?\s)?(?:%s)\s(.?)$/isu', $words);
78		$found = preg_match($pattern, $message->text, $matches);
79		if ($found) {
80		return trim($matches[1]);
81		}
82
83		return '';
84		}
85		}
86

LaravelRUS / GitterBot

Pull Request — master (#78)

NewGoogleSearchMiddleware::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like