Thanks10Karma0Achieve::handle() - Code Metrics - Inspection of "Improve achievements" - LaravelRUS/GitterBot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c1ce98...b3e799 )

by Kirill

created 2016-04-11 09:23 UTC

Thanks10Karma0Achieve::handle() A

↳ Parent: Thanks10Karma0Achieve

Complexity

Conditions	3
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	3
eloc	6
nc	1
nop	0

<?php
/**
 * This file is part of GitterBot package.
 *
 * @author Serafim <[email protected]>
 * @date 11.10.2015 6:07
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Domains\Bot\Achievements;

use Domains\Karma;
use Interfaces\Gitter\Achieve\AbstractAchieve;

/**
 * Class Thanks10Karma0Achieve
 */
class Thanks10Karma0Achieve extends AbstractAchieve
{
    /**
     * @var string
     */
    public $title = 'Полный паразец!';

    /**
     * @var string
     */
    public $description = 'Сказать 10 раз "спасибо" не имея ни единой благодарности.';

    /**
     * @var string
     */
    public $image = '//karma.laravel.su/img/achievements/thanks-10-karma-0.gif';

    /**
     * @throws \LogicException
     */
    public function handle()
    {
        Karma::created(function (Karma $karma) {
            $userThanks = $karma->user->thanks->count();

            $userKarma = $karma->user->karma->count();


            if ($userThanks === 10 && $userKarma === 0) {
                $this->create($karma->user, $karma->created_at);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
        });
    }
}


1			<?php
2			/**
3			* This file is part of GitterBot package.
4			*
5			* @author Serafim <[email protected]>
6			* @date 11.10.2015 6:07
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11			namespace Domains\Bot\Achievements;
12
13			use Domains\Karma;
14			use Interfaces\Gitter\Achieve\AbstractAchieve;
15
16			/**
17			* Class Thanks10Karma0Achieve
18			*/
19			class Thanks10Karma0Achieve extends AbstractAchieve
20			{
21			/**
22			* @var string
23			*/
24			public $title = 'Полный паразец!';
25
26			/**
27			* @var string
28			*/
29			public $description = 'Сказать 10 раз "спасибо" не имея ни единой благодарности.';
30
31			/**
32			* @var string
33			*/
34			public $image = '//karma.laravel.su/img/achievements/thanks-10-karma-0.gif';
35
36			/**
37			* @throws \LogicException
38			*/
39			public function handle()
40			{
41			Karma::created(function (Karma $karma) {
42			$userThanks = $karma->user->thanks->count();
			0 ignored issues – show Bug introduced 2016-04-08 23:47 UTC by Report Bug Copy Issue Report The method `count` cannot be called on `$karma->user->thanks` (of type `array<integer,object<Domains\Karma>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
43			$userKarma = $karma->user->karma->count();
			0 ignored issues – show Bug introduced 2016-04-08 23:47 UTC by Report Bug Copy Issue Report The method `count` cannot be called on `$karma->user->karma` (of type `array<integer,object<Domains\Karma>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
44
45			if ($userThanks === 10 && $userKarma === 0) {
46			$this->create($karma->user, $karma->created_at);
			0 ignored issues – show Documentation introduced 2016-04-06 16:55 UTC by Report Bug Copy Issue Report `$karma->created_at` is of type `string`, but the function expects a `null\|object<Carbon\Carbon>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
47			}
48			});
49			}
50			}
51

LaravelRUS / GitterBot

Push — master ( c1ce98...b3e799 )

Thanks10Karma0Achieve::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like