GetGitterRoomId::handle() - Code Metrics - Inspection of "Merge pull request #77 from butschster/master" - LaravelRUS/GitterBot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( baf846...d56647 )

by Kirill

created 2016-07-20 20:07 UTC

GetGitterRoomId::handle() A

↳ Parent: GetGitterRoomId

Complexity

Conditions	2
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	2
eloc	7
c	1
b	0
f	1
nc	3
nop	0
dl	0
loc	11
rs	9.4285

<?php

/**
 * This file is part of GitterBot package.
 *
 * @author butschster <[email protected]>
 * @date 20.07.2016 14:44
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Interfaces\Console\Commands;

use Gitter\Client;
use Illuminate\Console\Command;

/**
 * Class StartGitterBot
 */
class GetGitterRoomId extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'gitter:get-room-id {room}';


    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Get gitter room id by name.';

    public function handle()
    {
        $client = new Client(\Config::get('gitter.token'));

        try {
            $result = $client->http->getRoomByUri($this->argument('room'))->wait();

            $this->info("Room ID: {$result->id}");
        } catch (\Exception $e) {
            $this->info('Room not found');
        }
    }
}

1			<?php
2
3			/**
4			* This file is part of GitterBot package.
5			*
6			* @author butschster <[email protected]>
7			* @date 20.07.2016 14:44
8			*
9			* For the full copyright and license information, please view the LICENSE
10			* file that was distributed with this source code.
11			*/
12
13			namespace Interfaces\Console\Commands;
14
15			use Gitter\Client;
16			use Illuminate\Console\Command;
17
18			/**
19			* Class StartGitterBot
20			*/
21			class GetGitterRoomId extends Command
22			{
23			/**
24			* The name and signature of the console command.
25			*
26			* @var string
27			*/
28			protected $signature = 'gitter:get-room-id {room}';
29
30
31			/**
32			* The console command description.
33			*
34			* @var string
35			*/
36			protected $description = 'Get gitter room id by name.';
37
38			public function handle()
39			{
40			$client = new Client(\Config::get('gitter.token'));
41
42			try {
43			$result = $client->http->getRoomByUri($this->argument('room'))->wait();
			0 ignored issues – show Bug introduced 2016-07-20 12:03 UTC by Report Bug Copy Issue Report It seems like `$this->argument('room')` targeting `Illuminate\Console\Command::argument()` can also be of type `array`; however, `Gitter\Bus\HttpBus::getRoomByUri()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
44			$this->info("Room ID: {$result->id}");
45			} catch (\Exception $e) {
46			$this->info('Room not found');
47			}
48			}
49			}

LaravelRUS / GitterBot

Push — master ( baf846...d56647 )

GetGitterRoomId::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like