Message::getUrlsAttribute() - Code Metrics - Inspection of "Improve api" - LaravelRUS/GitterBot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( b4fba5...9773af )

by Kirill

created 2016-01-26 02:39 UTC

Message::getUrlsAttribute() A

↳ Parent: Message

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	9
rs	9.6666
cc	2
eloc	5
nc	2
nop	1

<?php
namespace App;

use Carbon\Carbon;
use Gitter\Models\Message as GitterMessage;
use Illuminate\Database\Eloquent\ { Builder, Collection };

/**
 * Class Message
 * @package App
 *
 * @property int $id
 * @property string $gitter_id
 * @property string $user_id
 * @property string $room_id
 * @property Text $text
 * @property array $sentences
 * @property string $html
 * @property array $urls
 * @property Carbon $created_at
 * @property Carbon $updated_at
 *
 * @property-read Mention[]|Collection $mentions
 * @property-read User $user
 *
 * @method Message forRoom(Room $room)
 */
class Message extends \Eloquent
{
    /**
     * @var string
     */
    protected $primaryKey = 'id';

    /**
     * @var string
     */
    protected $table = 'messages';

    /**
     * @var array
     */
    protected $fillable = ['gitter_id', 'user_id', 'room_id', 'text', 'html', 'urls', 'created_at', 'updated_at'];

    /**
     * @param GitterMessage $gitter
     * @return Message
     */
    public static function createFromGitterMessage(GitterMessage $gitter)
    {
        // Mentions
        foreach ($gitter->mentions as $mention) {
            Mention::firstOrCreate([
                'user_id'    => $mention,
                'message_id' => $gitter->id,
            ]);
        }

        /** @var Message $message */
        $message = Message::where(['gitter_id' => $gitter->id])->first();
        if (!$message) {
            $message = Message::create([
                'gitter_id' => $gitter->id,
                'user_id'   => $gitter->fromUser->id,
                'room_id'   => $gitter->room->id,
                'text'      => $gitter->text,
                'html'      => $gitter->html,
                'urls'      => json_encode($gitter->urls),

                'created_at' => (new Carbon($gitter->sent ?? date('Y-m-d H:i:s', 0)))
                    ->setTimezone('Europe/Moscow')
                    ->timestamp,

                'updated_at' => (new Carbon($gitter->editedAt ?? date('Y-m-d H:i:s', 0)))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    ->setTimezone('Europe/Moscow')
                    ->timestamp,
            ]);
        }

        return $message;
    }

    /**
     * @param Builder $builder
     * @return $this
     */
    public static function scopeOwn(Builder $builder)
    {
        /** @var User $user */
        $user = app(Client::class)->getUser();

        return $builder->where('user_id', $user->gitter_id);
    }

    /**
     * @param Builder $builder
     * @param Room|string $room
     * @return $this
     */
    public static function scopeForRoom(Builder $builder, $room)
    {
        $roomId = $room;
        if ($room instanceof Room) {
            $roomId = $room->gitter_id;
        }

        return $builder->where('room_id', $roomId);
    }

    /**
     * @return \Illuminate\Database\Eloquent\Relations\HasMany
     */
    public function mentions()
    {
        return $this->hasMany(Mention::class, 'message_id', 'gitter_id');
    }

    /**
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function user()
    {
        return $this->belongsTo(User::class, 'user_id', 'gitter_id');
    }

    /**
     * @outputs
     * @param $message
     * @return mixed
     */
    public function answer($message)
    {
        // Break while output breaks
        if (!app('config')->get('gitter.output')) {
            return null;
        }

        /** @var Client $client */
        $client = app(Client::class);

        return await($client

            ->request('message.send')
            ->where('roomId', $this->room_id)
            ->fetch([
                'method' => 'POST',
                'body'   => ['text' => $message],
            ]));
    }

    /**
     * @param $content
     * @return Text
     */
    public function getTextAttribute($content)
    {
        return new Text($content);
    }

    /**
     * @param array $urls
     */
    public function setUrlsAttribute($urls = [])
    {
        $this->attributes['urls'] = json_encode($urls);
    }

    /**
     * @param $urls
     * @return array|mixed
     */
    public function getUrlsAttribute($urls)
    {
        $result = json_decode($urls);
        if (json_last_error() !== JSON_ERROR_NONE) {
            return [];
        }

        return $result;
    }
}


1			<?php
2			namespace App;
3
4			use Carbon\Carbon;
5			use Gitter\Models\Message as GitterMessage;
6			use Illuminate\Database\Eloquent\ { Builder, Collection };
7
8			/**
9			* Class Message
10			* @package App
11			*
12			* @property int $id
13			* @property string $gitter_id
14			* @property string $user_id
15			* @property string $room_id
16			* @property Text $text
17			* @property array $sentences
18			* @property string $html
19			* @property array $urls
20			* @property Carbon $created_at
21			* @property Carbon $updated_at
22			*
23			* @property-read Mention[]\|Collection $mentions
24			* @property-read User $user
25			*
26			* @method Message forRoom(Room $room)
27			*/
28			class Message extends \Eloquent
29			{
30			/**
31			* @var string
32			*/
33			protected $primaryKey = 'id';
34
35			/**
36			* @var string
37			*/
38			protected $table = 'messages';
39
40			/**
41			* @var array
42			*/
43			protected $fillable = ['gitter_id', 'user_id', 'room_id', 'text', 'html', 'urls', 'created_at', 'updated_at'];
44
45			/**
46			* @param GitterMessage $gitter
47			* @return Message
48			*/
49			public static function createFromGitterMessage(GitterMessage $gitter)
50			{
51			// Mentions
52			foreach ($gitter->mentions as $mention) {
53			Mention::firstOrCreate([
54			'user_id' => $mention,
55			'message_id' => $gitter->id,
56			]);
57			}
58
59			/** @var Message $message */
60			$message = Message::where(['gitter_id' => $gitter->id])->first();
61			if (!$message) {
62			$message = Message::create([
63			'gitter_id' => $gitter->id,
64			'user_id' => $gitter->fromUser->id,
65			'room_id' => $gitter->room->id,
66			'text' => $gitter->text,
67			'html' => $gitter->html,
68			'urls' => json_encode($gitter->urls),
69
70			'created_at' => (new Carbon($gitter->sent ?? date('Y-m-d H:i:s', 0)))
71			->setTimezone('Europe/Moscow')
72			->timestamp,
73
74			'updated_at' => (new Carbon($gitter->editedAt ?? date('Y-m-d H:i:s', 0)))
			0 ignored issues – show Bug introduced 2016-01-26 02:51 UTC by Report Bug Copy Issue Report It seems like `$gitter->editedAt ?? date('Y-m-d H:i:s', 0)` can also be of type `object<Carbon\Carbon>`; however, `Carbon\Carbon::__construct()` does only seem to accept `string\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
75			->setTimezone('Europe/Moscow')
76			->timestamp,
77			]);
78			}
79
80			return $message;
81			}
82
83			/**
84			* @param Builder $builder
85			* @return $this
86			*/
87			public static function scopeOwn(Builder $builder)
88			{
89			/** @var User $user */
90			$user = app(Client::class)->getUser();
91
92			return $builder->where('user_id', $user->gitter_id);
93			}
94
95			/**
96			* @param Builder $builder
97			* @param Room\|string $room
98			* @return $this
99			*/
100			public static function scopeForRoom(Builder $builder, $room)
101			{
102			$roomId = $room;
103			if ($room instanceof Room) {
104			$roomId = $room->gitter_id;
105			}
106
107			return $builder->where('room_id', $roomId);
108			}
109
110			/**
111			* @return \Illuminate\Database\Eloquent\Relations\HasMany
112			*/
113			public function mentions()
114			{
115			return $this->hasMany(Mention::class, 'message_id', 'gitter_id');
116			}
117
118			/**
119			* @return \Illuminate\Database\Eloquent\Relations\BelongsTo
120			*/
121			public function user()
122			{
123			return $this->belongsTo(User::class, 'user_id', 'gitter_id');
124			}
125
126			/**
127			* @outputs
128			* @param $message
129			* @return mixed
130			*/
131			public function answer($message)
132			{
133			// Break while output breaks
134			if (!app('config')->get('gitter.output')) {
135			return null;
136			}
137
138			/** @var Client $client */
139			$client = app(Client::class);
140
141			return await($client
			0 ignored issues – show Bug introduced 2016-01-26 02:51 UTC by Report Bug Copy Issue Report The method `request()` does not exist on `App\Client`. Did you maybe mean `createRequest()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
142			->request('message.send')
143			->where('roomId', $this->room_id)
144			->fetch([
145			'method' => 'POST',
146			'body' => ['text' => $message],
147			]));
148			}
149
150			/**
151			* @param $content
152			* @return Text
153			*/
154			public function getTextAttribute($content)
155			{
156			return new Text($content);
157			}
158
159			/**
160			* @param array $urls
161			*/
162			public function setUrlsAttribute($urls = [])
163			{
164			$this->attributes['urls'] = json_encode($urls);
165			}
166
167			/**
168			* @param $urls
169			* @return array\|mixed
170			*/
171			public function getUrlsAttribute($urls)
172			{
173			$result = json_decode($urls);
174			if (json_last_error() !== JSON_ERROR_NONE) {
175			return [];
176			}
177
178			return $result;
179			}
180			}
181

LaravelRUS / GitterBot

Push — develop ( b4fba5...9773af )

Message::getUrlsAttribute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like