GitterRoomListenCommand::onMessageFallback() - Code Metrics - Inspection of "Improve core" - LaravelRUS/GitterBot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 0a4bcc...0131cc )

by Kirill

created 2016-01-27 15:23 UTC

GitterRoomListenCommand::onMessageFallback() B

↳ Parent: GitterRoomListenCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	25
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	0
loc	25
rs	8.8571
cc	2
eloc	17
nc	2
nop	3

<?php
/**
 * This file is part of GitterBot package.
 *
 * @author Serafim <[email protected]>
 * @date 26.01.2016 4:57
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace App\Console\Commands;

use App\Gitter\Extensions\MiddlewareBuilder;
use App\Message;
use App\Room;
use App\User;
use Carbon\Carbon;
use Gitter\Client;
use Gitter\Iterators\PromiseIterator\Controls;
use Gitter\Models\Message as GitterMessage;
use Gitter\Models\Room as GitterRoom;
use Gitter\Models\User as GitterUser;
use Illuminate\Contracts\Config\Repository;
use Illuminate\Contracts\Container\Container;
use React\EventLoop\LoopInterface;


/**
 * Class GitterRoomListenCommand
 * @package App\Console\Commands
 *
 * Прослушивание сообщений требуемой комнаты
 */
class GitterRoomListenCommand extends AbstractCommand
{
    /**
     * @var string
     */
    protected $signature = 'gitter:listen {room}';

    /**
     * @var string
     */
    protected $description = 'Listen gitter room';

    /**
     * Execute the console command.
     *
     * @param Repository $config
     * @param Container $container
     *
     * @return mixed
     */
    public function handle(Repository $config, Container $container)
    {
        /** @var Client $client */
        $client = $this->createClient($container, $config->get('gitter.token'));

        $this->auth($client, function (User $user) use ($client) {


            $this->findRoom($client, $this->argument('room'), function (GitterRoom $room) {

                try {
                    $this->listen($room, true);

                } catch (\Throwable $e) {

                    $this->error($e->getMessage());
                }
            });

        });

        /** @var LoopInterface $loop */
        $loop = $container->make(LoopInterface::class);
        $loop->run();
    }

    /**
     * @param Client $client
     * @param \Closure $callback
     */
    protected function auth(Client $client, \Closure $callback)
    {
        GitterUser::current($client)
            ->then(function (GitterUser $gitterUser) use ($callback) {
                $user = User::make($gitterUser);
                \Auth::setUser($user);

                $callback($user);
            }, function(\Throwable $e) {
                $this->onError($e);
            });
    }

    /**
     * @param GitterRoom $gitter
     * @param bool $startup
     * @return $this
     */
    protected function listen(GitterRoom $gitter, $startup = false)
    {
        /** @var Room $room */
        $room = Room::make($gitter, function (Room $room) {
            $this->call('gitter:sync', [
                'room'       => $room->gitter_id,
                '--users'    => true,
                '--messages' => true,
            ]);
        });

        /** @var LoopInterface $loop */
        $loop = app(LoopInterface::class);

        if ($startup) {
            $this->info('Fetching last messages...');
            $this->onMessageFallback($loop, $gitter, 1);

            return $this;
        }

        $this->info(sprintf(
            'Startup gitter listener for %s at [%s]',
            $room->url,
            Carbon::now()->toDateTimeString()
        ));

        $gitter->onMessage(function (GitterMessage $msg) {
            app(Client::class)->setFallbackMode(false);
            $this->onMessage($msg);

        }, function (\Throwable $e) use ($loop, $gitter) {
            $this->onError($e);
            $this->warn('Stream not available. Use message fallback fetch mode.');

            app(Client::class)->setFallbackMode(true);
            $this->onMessageFallback($loop, $gitter);
        });

        return $this;
    }

    /**
     * @param LoopInterface $loop
     * @param GitterRoom $gitter
     * @param int $timeout
     */
    protected function onMessageFallback(LoopInterface $loop, GitterRoom $gitter, $timeout = 10)
    {
        /** @var Message $lastMessage */
        $lastMessage = Message::where('room_id', $gitter->id)
            ->latest('created_at')
            ->first();

        if ($lastMessage) {
            $loop->addTimer($timeout, function () use ($gitter, $lastMessage) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $gitter->getMessages($lastMessage->gitter_id, GitterRoom::MESSAGE_FETCH_ASC)
                    ->fetch(function (GitterMessage $message, Controls $controls) {
                        $this->onMessage($message);
                        $controls->next();
                    })
                    ->then(function () use ($gitter) {
                        $this->warn('Connection...');
                        $this->listen($gitter);
                    }, function(\Throwable $e) {
                        $this->onError($e);
                    });
            });
        } else {
            $this->listen($gitter);
        }
    }

    /**
     * @param GitterMessage $gitter
     */
    protected function onMessage(GitterMessage $gitter)
    {
        try {
            /** @var MiddlewareBuilder $builder */
            $builder = app(MiddlewareBuilder::class);
            $builder->fire($gitter->room, Message::make($gitter));

        } catch (\Throwable $e) {
            $this->onError($e);
        }
    }

    /**
     * @param \Throwable $e
     */
    protected function onError(\Throwable $e)
    {
        $this->line('');
        $this->error('> ' . get_class($e));
        $this->error('> ' . $e->getMessage());
        $this->error('> ' . $e->getFile() . ':' . $e->getLine());
        $this->line('');
    }
}







1			<?php
2			/**
3			* This file is part of GitterBot package.
4			*
5			* @author Serafim <[email protected]>
6			* @date 26.01.2016 4:57
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11			namespace App\Console\Commands;
12
13			use App\Gitter\Extensions\MiddlewareBuilder;
14			use App\Message;
15			use App\Room;
16			use App\User;
17			use Carbon\Carbon;
18			use Gitter\Client;
19			use Gitter\Iterators\PromiseIterator\Controls;
20			use Gitter\Models\Message as GitterMessage;
21			use Gitter\Models\Room as GitterRoom;
22			use Gitter\Models\User as GitterUser;
23			use Illuminate\Contracts\Config\Repository;
24			use Illuminate\Contracts\Container\Container;
25			use React\EventLoop\LoopInterface;
26
27
28			/**
29			* Class GitterRoomListenCommand
30			* @package App\Console\Commands
31			*
32			* Прослушивание сообщений требуемой комнаты
33			*/
34			class GitterRoomListenCommand extends AbstractCommand
35			{
36			/**
37			* @var string
38			*/
39			protected $signature = 'gitter:listen {room}';
40
41			/**
42			* @var string
43			*/
44			protected $description = 'Listen gitter room';
45
46			/**
47			* Execute the console command.
48			*
49			* @param Repository $config
50			* @param Container $container
51			*
52			* @return mixed
53			*/
54			public function handle(Repository $config, Container $container)
55			{
56			/** @var Client $client */
57			$client = $this->createClient($container, $config->get('gitter.token'));
58
59			$this->auth($client, function (User $user) use ($client) {
			0 ignored issues – show Unused Code introduced 2016-01-26 14:47 UTC by Report Bug Copy Issue Report The parameter `$user` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
60
61			$this->findRoom($client, $this->argument('room'), function (GitterRoom $room) {
			0 ignored issues – show Bug introduced 2016-01-26 02:51 UTC by Report Bug Copy Issue Report It seems like `$this->argument('room')` targeting `Illuminate\Console\Command::argument()` can also be of type `array`; however, `App\Console\Commands\AbstractCommand::findRoom()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
62			try {
63			$this->listen($room, true);
64
65			} catch (\Throwable $e) {
66
67			$this->error($e->getMessage());
68			}
69			});
70
71			});
72
73			/** @var LoopInterface $loop */
74			$loop = $container->make(LoopInterface::class);
75			$loop->run();
76			}
77
78			/**
79			* @param Client $client
80			* @param \Closure $callback
81			*/
82			protected function auth(Client $client, \Closure $callback)
83			{
84			GitterUser::current($client)
85			->then(function (GitterUser $gitterUser) use ($callback) {
86			$user = User::make($gitterUser);
87			\Auth::setUser($user);
88
89			$callback($user);
90			}, function(\Throwable $e) {
91			$this->onError($e);
92			});
93			}
94
95			/**
96			* @param GitterRoom $gitter
97			* @param bool $startup
98			* @return $this
99			*/
100			protected function listen(GitterRoom $gitter, $startup = false)
101			{
102			/** @var Room $room */
103			$room = Room::make($gitter, function (Room $room) {
104			$this->call('gitter:sync', [
105			'room' => $room->gitter_id,
106			'--users' => true,
107			'--messages' => true,
108			]);
109			});
110
111			/** @var LoopInterface $loop */
112			$loop = app(LoopInterface::class);
113
114			if ($startup) {
115			$this->info('Fetching last messages...');
116			$this->onMessageFallback($loop, $gitter, 1);
117
118			return $this;
119			}
120
121			$this->info(sprintf(
122			'Startup gitter listener for %s at [%s]',
123			$room->url,
124			Carbon::now()->toDateTimeString()
125			));
126
127			$gitter->onMessage(function (GitterMessage $msg) {
128			app(Client::class)->setFallbackMode(false);
129			$this->onMessage($msg);
130
131			}, function (\Throwable $e) use ($loop, $gitter) {
132			$this->onError($e);
133			$this->warn('Stream not available. Use message fallback fetch mode.');
134
135			app(Client::class)->setFallbackMode(true);
136			$this->onMessageFallback($loop, $gitter);
137			});
138
139			return $this;
140			}
141
142			/**
143			* @param LoopInterface $loop
144			* @param GitterRoom $gitter
145			* @param int $timeout
146			*/
147			protected function onMessageFallback(LoopInterface $loop, GitterRoom $gitter, $timeout = 10)
148			{
149			/** @var Message $lastMessage */
150			$lastMessage = Message::where('room_id', $gitter->id)
151			->latest('created_at')
152			->first();
153
154			if ($lastMessage) {
155			$loop->addTimer($timeout, function () use ($gitter, $lastMessage) {
			0 ignored issues – show Documentation introduced 2016-01-26 14:47 UTC by Report Bug Copy Issue Report `$timeout` is of type `integer`, but the function expects a `object<React\EventLoop\numeric>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
156			$gitter->getMessages($lastMessage->gitter_id, GitterRoom::MESSAGE_FETCH_ASC)
157			->fetch(function (GitterMessage $message, Controls $controls) {
158			$this->onMessage($message);
159			$controls->next();
160			})
161			->then(function () use ($gitter) {
162			$this->warn('Connection...');
163			$this->listen($gitter);
164			}, function(\Throwable $e) {
165			$this->onError($e);
166			});
167			});
168			} else {
169			$this->listen($gitter);
170			}
171			}
172
173			/**
174			* @param GitterMessage $gitter
175			*/
176			protected function onMessage(GitterMessage $gitter)
177			{
178			try {
179			/** @var MiddlewareBuilder $builder */
180			$builder = app(MiddlewareBuilder::class);
181			$builder->fire($gitter->room, Message::make($gitter));
182
183			} catch (\Throwable $e) {
184			$this->onError($e);
185			}
186			}
187
188			/**
189			* @param \Throwable $e
190			*/
191			protected function onError(\Throwable $e)
192			{
193			$this->line('');
194			$this->error('> ' . get_class($e));
195			$this->error('> ' . $e->getMessage());
196			$this->error('> ' . $e->getFile() . ':' . $e->getLine());
197			$this->line('');
198			}
199			}
200
201
202
203
204
205

LaravelRUS / GitterBot

Push — develop ( 0a4bcc...0131cc )

GitterRoomListenCommand::onMessageFallback() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like