Core\Providers\GitterClientServiceProvider

Complexity

Total Complexity

8

Size/Duplication

Total Lines	64
Duplicated Lines	37.5 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	5
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	register()	0	12	1
A	boot()	0	15	1
A	registerGitterRooms()	12	12	3
A	registerSlackRooms()	12	12	3

<?php
/**
 * This file is part of GitterBot package.
 *
 * @author Serafim <nesk@xakep.ru>
 * @author butschster <butschster@gmail.com>
 * @date 09.04.2016 3:09
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Core\Providers;

use Domains\BotManager;
use Domains\RoomManager;
use Gitter\Client;
use Illuminate\Container\Container;
use Illuminate\Support\ServiceProvider;
use Interfaces\Gitter\StandartGitterRoom;
use Interfaces\Slack\StandartSlackRoom;

/**
 * Class GitterClientServiceProvider
 * @package Core\Providers
 */
class GitterClientServiceProvider extends ServiceProvider
{

    public function register()
    {
        $this->app->singleton(Client::class, function (Container $app) {
            return new Client($app['config']->get('gitter.token'));
        });

        $this->app->singleton('bot', function (Container $app) {
            /** @var Client $client */
            $client = $app->make(Client::class);
            return $client->http->getCurrentUser()->wait();
        });
    }

    public function boot()
    {
        $this->app->singleton('bot.manager', function (Container $app) {
            return new BotManager($app);

$app of type object<Illuminate\Container\Container> is not a sub-type of object<Illuminate\Foundation\Application>. It seems like you assume a child class of the class Illuminate\Container\Container to be always present.

        });

        $this->app->singleton('room.manager', function (Container $app) {

The parameter $app is not used and could be removed.

            $manager = new RoomManager();

            $this->registerGitterRooms($manager);
            $this->registerSlackRooms($manager);

            return $manager;
        });
    }

    /**
     * @param RoomManager $manager
     */
    protected function registerGitterRooms(RoomManager $manager)

This method seems to be duplicated in your project.

    {
        foreach ((array) $this->app['config']->get('gitter.rooms') as $room => $groups) {
            if (empty($room)) {
                continue;
            }

            $manager->register(
                new StandartGitterRoom($room, $groups, \Config::get('gitter.middlewares'))
            );
        }
    }

    /**
     * @param RoomManager $manager
     */
    protected function registerSlackRooms(RoomManager $manager)

This method seems to be duplicated in your project.

    {
        foreach ((array) $this->app['config']->get('slack.rooms') as $roomId => $groups) {
            if (empty($roomId)) {
                continue;
            }

            $manager->register(
                new StandartSlackRoom($roomId, $groups, \Config::get('slack.middlewares'))
            );
        }
    }
}