LaravelFreelancerNL / laravel-arangodb

src/Schema/Concerns/TableCommands.php

<?php

declare(strict_types=1);

namespace LaravelFreelancerNL\Aranguent\Schema\Concerns;

use Illuminate\Support\Fluent;

trait TableCommands
{
    /**
     * Indicate that the table needs to be created.
     *
     * @param  array  $options
     * @return Fluent
     */
    public function create($options = [])
    {
        $parameters = [];
        $parameters['options'] = $options;
        $parameters['explanation'] = "Create '{$this->table}' table.";
        $parameters['handler'] = 'table';

        return $this->addCommand('create', $parameters);

It seems like addCommand() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param string $command
     * @param mixed[] $args
     * @return void
     */
    public function handleKeyCommands($command, $args)
    {
        $acceptedKeyFields = ['id', '_id', '_key'];

        $columns = ($command === 'autoIncrement') ? end($this->columns) : $args;
        $columns = (is_array($columns)) ? $columns : [$columns];

        if (count($columns) !== 1 || ! in_array($columns[0], $acceptedKeyFields)) {
            return;
        }

        if ($command === 'uuid') {
            $this->keyGenerator = 'uuid';

The property keyGenerator does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return;
        }

        if (config('arangodb.schema.key_handling.use_traditional_over_autoincrement') === false) {
            $this->keyGenerator = 'autoincrement';

            return;
        }

        $this->keyGenerator = 'traditional';
    }

    public function executeCreateCommand($command)
    {
        if ($this->connection->pretending()) {
            $this->connection->logQuery('/* ' . $command->explanation . " */\n", []);

            return;
        }

        $options = $command->options;
        $options['keyOptions'] = $this->setKeyOptions($options['keyOptions'] ?? []);

It seems like setKeyOptions() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (!$this->schemaManager->hasCollection($this->table)) {
            $this->schemaManager->createCollection($this->table, $options);
        }
    }
}