LaravelFreelancerNL / laravel-arangodb

src/Query/Concerns/CompilesGroups.php

<?php

namespace LaravelFreelancerNL\Aranguent\Query\Concerns;

use Illuminate\Database\Query\Builder as IlluminateQueryBuilder;
use Illuminate\Database\Query\Expression;
use LaravelFreelancerNL\Aranguent\Query\Builder;

trait CompilesGroups
{
    /**
     * Compile the "group by" portions of the query.
     *
     * @param IlluminateQueryBuilder $query
     * @param array<mixed> $groups
     * @return string
     * @throws \Exception
     */
    protected function compileGroups(IlluminateQueryBuilder $query, $groups): string
    {
        assert($query instanceof Builder);

        $aql = "COLLECT ";

        $aqlGroups = [];
        foreach ($groups as $group) {
            if ($group instanceof Expression) {
                $groupVariable = $this->extractGroupVariable($group);
                ;
                $query->registerTableAlias($groupVariable, $groupVariable);

                $aqlGroups[] = $group->getValue($this);

$this of type LaravelFreelancerNL\Aranguent\Query\Concerns\CompilesGroups is incompatible with the type Illuminate\Database\Grammar expected by parameter $grammar of Illuminate\Database\Query\Expression::getValue().

                continue;
            }

            $aqlGroups[] = $group . " = " . $this->normalizeColumn($query, $group);

It seems like normalizeColumn() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $query->registerTableAlias($group, $group);
            $query->groupVariables[] = $group;
        }

        $aql .= implode(", ", $aqlGroups);

        $variablesToKeep = $this->keepColumns($query, $groups);

        if (!empty($variablesToKeep)) {
            $query->registerTableAlias('groupsVariable', 'groupsVariable');
            $query->groupVariables[] = 'groupsVariable';

            $aql .= ' INTO groupsVariable = ' . $this->generateAqlObject($variablesToKeep);

It seems like generateAqlObject() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
        return $aql;
    }

    /**
     * @param IlluminateQueryBuilder $query
     * @param array<mixed> $groups
     * @return array<string>
     * @throws \Exception
     */
    protected function keepColumns(IlluminateQueryBuilder $query, $groups)
    {
        if (is_null($query->columns)) {
            return [];
        }
        $tempGroups = [];
        foreach ($groups as $group) {
            if ($group instanceof Expression) {
                $tempGroups[] = $this->extractGroupVariable($group);
                continue;
            }
            $tempGroups[] = $group;
        }

        $diff = array_diff_assoc($query->columns, $tempGroups);

        $results = [];
        foreach ($diff as $key => $value) {
            if (is_numeric($key)) {
                $results[$value] = $this->normalizeColumn($query, $value);
                continue;
            }
            $results[$key] = $this->normalizeColumn($query, $value);
        }

        return $results;
    }

    protected function extractGroupVariable(Expression $group): string
    {
        return explode(' = ', (string) $group->getValue($this))[0];

$this of type LaravelFreelancerNL\Aranguent\Query\Concerns\CompilesGroups is incompatible with the type Illuminate\Database\Grammar expected by parameter $grammar of Illuminate\Database\Query\Expression::getValue().

    }
}