LaravelFreelancerNL /
laravel-arangodb
| Conditions | 2 |
| Paths | 2 |
| Total Lines | 54 |
| Code Lines | 4 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 15 | public function run() |
||
| 16 | { |
||
| 17 | $taggables = '[ |
||
| 18 | { |
||
| 19 | "tag_id":"A", |
||
| 20 | "taggable_id":"winterfell", |
||
| 21 | "taggable_type":"TestSetup\\\Models\\\Location" |
||
| 22 | }, |
||
| 23 | { |
||
| 24 | "tag_id":"S", |
||
| 25 | "taggable_id":"beyond-the-wall", |
||
| 26 | "taggable_type":"TestSetup\\\Models\\\Location" |
||
| 27 | }, |
||
| 28 | { |
||
| 29 | "tag_id":"E", |
||
| 30 | "taggable_id":"PetyrBaelish", |
||
| 31 | "taggable_type":"TestSetup\\\Models\\\Character" |
||
| 32 | }, |
||
| 33 | { |
||
| 34 | "tag_id":"F", |
||
| 35 | "taggable_id":"PetyrBaelish", |
||
| 36 | "taggable_type":"TestSetup\\\Models\\\Character" |
||
| 37 | }, |
||
| 38 | { |
||
| 39 | "tag_id":"G", |
||
| 40 | "taggable_id":"PetyrBaelish", |
||
| 41 | "taggable_type":"TestSetup\\\Models\\\Character" |
||
| 42 | }, |
||
| 43 | { |
||
| 44 | "tag_id":"A", |
||
| 45 | "taggable_id":"SandorClegane", |
||
| 46 | "taggable_type":"TestSetup\\\Models\\\Character" |
||
| 47 | }, |
||
| 48 | { |
||
| 49 | "tag_id":"F", |
||
| 50 | "taggable_id":"SandorClegane", |
||
| 51 | "taggable_type":"TestSetup\\\Models\\\Character" |
||
| 52 | }, |
||
| 53 | { |
||
| 54 | "tag_id":"K", |
||
| 55 | "taggable_id":"SandorClegane", |
||
| 56 | "taggable_type":"TestSetup\\\Models\\\Character" |
||
| 57 | }, |
||
| 58 | { |
||
| 59 | "tag_id":"P", |
||
| 60 | "taggable_id":"SandorClegane", |
||
| 61 | "taggable_type":"TestSetup\\\Models\\\Character" |
||
| 62 | } |
||
| 63 | ]'; |
||
| 64 | |||
| 65 | $taggables = json_decode($taggables, JSON_OBJECT_AS_ARRAY); |
||
|
Bug
introduced
by
|
|||
| 66 | |||
| 67 | foreach ($taggables as $taggable) { |
||
| 68 | Taggable::insertOrIgnore($taggable); |
||
| 69 | } |
||
| 72 |
Loading history...