LaravelFreelancerNL\Aranguent\Eloquent\Concerns\QueriesAranguentRelationships::withAggregate()

Complexity

Conditions	13
Paths	149

Size

Total Lines	97
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	14.3519

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function withAggregate($relations, $column, $function = null)
    {
        if (empty($relations)) {
            return $this;
        }

        if (is_null($this->query->columns)) {
            $this->query->select([$this->query->from . '.*']);
        }

        $relations = is_array($relations) ? $relations : [$relations];

        foreach ($this->parseWithRelations($relations) as $name => $constraints) {

It seems like parseWithRelations() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            // First we will determine if the name has been aliased using an "as" clause on the name
            // and if it has we will extract the actual relationship name and the desired name of
            // the resulting column. This allows multiple aggregates on the same relationships.
            $segments = explode(' ', $name);

            unset($alias);

            if (count($segments) === 3 && Str::lower($segments[1]) === 'as') {
                [$name, $alias] = [$segments[0], $segments[2]];
            }

            $relation = $this->getRelationWithoutConstraints($name);

It seems like getRelationWithoutConstraints() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if ($function) {
                $hashedColumn = $this->getRelationHashedColumn($column, $relation);

It seems like getRelationHashedColumn() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $wrappedColumn = $this->getQuery()->getGrammar()->wrap(
                    $column === '*' ? $column : $relation->getRelated()->qualifyColumn($hashedColumn)
                );

                $expression = $function === 'exists' ? $wrappedColumn : sprintf('%s(%s)', $function, $wrappedColumn);
            } else {
                $expression = $column;
            }

            // Here, we will grab the relationship sub-query and prepare to add it to the main query
            // as a sub-select. First, we'll get the "has" query and use that to get the relation
            // sub-query. We'll format this relationship name and append this column if needed.
            $query = $relation->getRelationExistenceQuery(
                $relation->getRelated()->newQuery(),
                $this,
                new Expression($expression)
            )->setBindings([], 'select');

            $query->callScope($constraints);

            $query = $query->mergeConstraintsFrom($relation->getQuery())->toBase();

            // If the query contains certain elements like orderings / more than one column selected
            // then we will remove those elements from the query so that it will execute properly
            // when given to the database. Otherwise, we may receive SQL errors or poor syntax.
            $query->orders = null;
            $query->setBindings([], 'order');

            if (count($query->columns) > 1) {
                $query->columns = [$query->columns[0]];
                $query->bindings['select'] = [];
            }

            // Finally, we will make the proper column alias to the query and run this sub-select on
            // the query builder. Then, we will return the builder instance back to the developer
            // for further constraint chaining that needs to take place on the query as needed.
            $alias ??= Str::snake(

The variable $alias seems to be defined later in this foreach loop on line 93. Are you sure it is defined here?

                preg_replace('/[^[:alnum:][:space:]_]/u', '', "$name $function $column")
            );

            if ($function === 'exists') {
                [$subquery] = $this->getQuery()->createSub($query);

                $expression = new Expression(sprintf('(COUNT(%s)) > 0 ? true : false ', $subquery));

                $this->getQuery()->set(
                    $alias,
                    $expression,
                    'postIterationVariables'
                )
                    ->addSelect($alias);
            } else {
                if ($function === null) {
                    $query->limit(1);
                }

                [$subquery] = $this->getQuery()->createSub($query);

                $this->getQuery()->set(
                    $alias,
                    new Expression(strtoupper($function) . '(' . $subquery . ')'),
                    'postIterationVariables'
                );
                $this->addSelect($alias);

It seems like addSelect() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        }

        return $this;
    }