LaravelFreelancerNL\Aranguent\Query\Concerns\CompilesGroups::compileGroups()

Complexity

Conditions	4
Paths	6

Size

Total Lines	34
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function compileGroups(IlluminateQueryBuilder $query, $groups): string
    {
        assert($query instanceof Builder);

        $aql = "COLLECT ";

        $aqlGroups = [];
        foreach ($groups as $group) {
            if ($group instanceof Expression) {
                $groupVariable = $this->extractGroupVariable($group);
                ;
                $query->registerTableAlias($groupVariable, $groupVariable);

                $aqlGroups[] = $group->getValue($this);

$this of type LaravelFreelancerNL\Aranguent\Query\Concerns\CompilesGroups is incompatible with the type Illuminate\Database\Grammar expected by parameter $grammar of Illuminate\Database\Query\Expression::getValue().

                continue;
            }

            $aqlGroups[] = $group . " = " . $this->normalizeColumn($query, $group);

It seems like normalizeColumn() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $query->registerTableAlias($group, $group);
            $query->groupVariables[] = $group;
        }

        $aql .= implode(", ", $aqlGroups);

        $variablesToKeep = $this->keepColumns($query, $groups);

        if (!empty($variablesToKeep)) {
            $query->registerTableAlias('groupsVariable', 'groupsVariable');
            $query->groupVariables[] = 'groupsVariable';

            $aql .= ' INTO groupsVariable = ' . $this->generateAqlObject($variablesToKeep);

It seems like generateAqlObject() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
        return $aql;
    }