LaravelFreelancerNL /
laravel-arangodb
| Conditions | 9 |
| Paths | 9 |
| Total Lines | 68 |
| Code Lines | 25 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 23 |
| CRAP Score | 9.0414 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 22 | 55 | public function where($column, $operator = null, $value = null, $boolean = 'and') |
|
| 23 | { |
||
| 24 | // If the column is an array, we will assume it is an array of key-value pairs |
||
| 25 | // and can add them each as a where clause. We will maintain the boolean we |
||
| 26 | // received when the method was called and pass it into the nested where. |
||
| 27 | 55 | if (is_array($column)) { |
|
| 28 | return $this->addArrayOfWheres($column, $boolean); |
||
|
Bug
introduced
by
|
|||
| 29 | } |
||
| 30 | |||
| 31 | // Here we will make some assumptions about the operator. If only 2 values are |
||
| 32 | // passed to the method, we will assume that the operator is an equals sign |
||
| 33 | // and keep going. Otherwise, we'll require the operator to be passed in. |
||
| 34 | 55 | [$value, $operator] = $this->prepareValueAndOperator( |
|
| 35 | 55 | $value, |
|
| 36 | $operator, |
||
| 37 | 55 | func_num_args() === 2 |
|
| 38 | ); |
||
| 39 | |||
| 40 | // If the columns is actually a Closure instance, we will assume the developer |
||
| 41 | // wants to begin a nested where statement which is wrapped in parenthesis. |
||
| 42 | // We'll add that Closure to the query then return back out immediately. |
||
| 43 | 55 | if ($column instanceof Closure && is_null($operator)) { |
|
| 44 | 1 | return $this->whereNested($column, $boolean); |
|
| 45 | } |
||
| 46 | |||
| 47 | // If the column is a Closure instance and there is an operator value, we will |
||
| 48 | // assume the developer wants to run a subquery and then compare the result |
||
| 49 | // of that subquery with the given value that was provided to the method. |
||
| 50 | 55 | if ($this->isQueryable($column) && ! is_null($operator)) { |
|
| 51 | 1 | $sub = $this->createSub($column); |
|
| 52 | 1 | return $this->where($sub, $operator, $value, $boolean); |
|
| 53 | } |
||
| 54 | |||
| 55 | // If the given operator is not found in the list of valid operators we will |
||
| 56 | // assume that the developer is just short-cutting the '=' operators and |
||
| 57 | // we will set the operators to '==' and set the values appropriately. |
||
| 58 | 55 | if ($this->invalidOperator($operator)) { |
|
| 59 | [$value, $operator] = [$operator, '==']; |
||
| 60 | } |
||
| 61 | |||
| 62 | // If the value is a Closure, it means the developer is performing an entire |
||
| 63 | // sub-select within the query and we will need to compile the sub-select |
||
| 64 | // within the where clause to get the appropriate query record results. |
||
| 65 | 55 | if ($value instanceof Closure) { |
|
| 66 | 1 | return $this->whereSub($column, $operator, $value, $boolean); |
|
| 67 | } |
||
| 68 | |||
| 69 | // If the value is "null", we will just assume the developer wants to add a |
||
| 70 | // where null clause to the query. So, we will allow a short-cut here to |
||
| 71 | // that method for convenience so the developer doesn't have to check. |
||
| 72 | 55 | if (is_null($value)) { |
|
| 73 | 12 | return $this->whereNull($column, $boolean, $operator !== '='); |
|
| 74 | } |
||
| 75 | |||
| 76 | 53 | $type = 'Basic'; |
|
| 77 | |||
| 78 | // Now that we are working with just a simple query we can put the elements |
||
| 79 | // in our array and add the query binding to our array of bindings that |
||
| 80 | // will be bound to each SQL statements when it is finally executed. |
||
| 81 | 53 | $this->wheres[] = compact( |
|
| 82 | 53 | 'type', |
|
| 83 | 53 | 'column', |
|
| 84 | 53 | 'operator', |
|
| 85 | 53 | 'value', |
|
| 86 | 53 | 'boolean' |
|
| 87 | ); |
||
| 88 | |||
| 89 | 53 | return $this; |
|
| 90 | } |
||
| 214 |
Loading history...