LaravelFreelancerNL\Aranguent\Query\Concerns\CompilesUnions::compileUnions()

Complexity

Conditions	7
Paths	25

Size

Total Lines	39
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	7.0061

Importance

Changes	2
Bugs	0	Features	0

<?php
    protected function compileUnions(IlluminateBuilder $query, $firstQuery = '')
    {
        if (!is_array($query->unions)) {
            return '';
        }

        $unionResultsId = 'union' . $query->getQueryId() . 'Results';
        $unionDocId = 'union' . $query->getQueryId() . 'Result';

        $query->registerTableAlias($unionResultsId, $unionDocId);

        $firstQuery = $this->wrapSubquery($firstQuery);

It seems like wrapSubquery() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $unions = '';

        foreach ($query->unions as $union) {
            $prefix = ($unions !== '') ? $unions : $firstQuery;
            $unions = $this->compileUnion($union, $prefix);
        }

        $aql = 'LET ' . $unionResultsId . ' = ' . $unions
            . ' FOR ' . $unionDocId . ' IN ' . $unionResultsId;

        // Union groups

        if (!empty($query->unionOrders)) {
            $aql .= ' ' . $this->compileOrders($query, $query->unionOrders, $unionResultsId);

It seems like compileOrders() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        if ($query->unionOffset) {

The expression $query->unionOffset of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $aql .= ' ' . $this->compileOffset($query, $query->unionOffset);

It seems like compileOffset() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        if ($query->unionLimit) {

The expression $query->unionLimit of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $aql .= ' ' . $this->compileLimit($query, $query->unionLimit);

The method compileLimit() does not exist on LaravelFreelancerNL\Aranguent\Query\Concerns\CompilesUnions. Did you maybe mean compileUnion()?

        }

        // Union aggregates?
        return $aql . ' RETURN ' . $unionDocId;
    }