CompilesColumns::prepareColumns() - Code Metrics - Inspection of "Merge pull request #181 from LaravelFreelancerNL/1..." - LaravelFreelancerNL/laravel-arangodb - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — next ( bea07e...b4e6e6 )

by Bas
created 2024-12-25 14:56 UTC
CompilesColumns::prepareColumns() B

↳ Parent: CompilesColumns
Complexity

Conditions	11
Paths	6
Size

Total Lines	40
Code Lines	22
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	18
CRAP Score	12.2432
Importance

Changes
Metric	Value
cc	11
eloc	22
c	0
b	0
f	0
nc	6
nop	2
dl	0
loc	40
ccs	18
cts	23
cp	0.7826
crap	12.2432
rs	7.3166
How to fix Complexity

<?php

declare(strict_types=1);

namespace LaravelFreelancerNL\Aranguent\Query\Concerns;

use Exception;
use Illuminate\Database\Query\Builder as IlluminateQueryBuilder;
use Illuminate\Database\Query\Expression;
use LaravelFreelancerNL\Aranguent\Query\Builder;

trait CompilesColumns
{
    /**
     * Compile the "select *" portion of the query.
     *
     * @param IlluminateQueryBuilder $query
     * @param array<mixed> $columns
     * @return string|null
     * @throws Exception
     */
    protected function compileColumns(IlluminateQueryBuilder $query, $columns)
    {
        assert($query instanceof Builder);

        $columns = $this->convertJsonFields($columns);
        $columns = $this->convertJsonFields($columns);

        [$returnAttributes, $returnDocs] = $this->prepareColumns($query, $columns);

        $returnValues = $this->determineReturnValues($query, $returnAttributes, $returnDocs);

        $return = 'RETURN ';
        if ($query->distinct) {
            $return .= 'DISTINCT ';
        }

        return $return . $returnValues;
    }

    /**
     * @param IlluminateQueryBuilder $query
     * @param array<mixed> $columns
     * @return array<mixed>
     * @throws Exception
     *
     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
     */
    protected function prepareColumns(IlluminateQueryBuilder $query, array $columns)
    {
        assert($query instanceof Builder);

        $returnDocs = [];
        $returnAttributes = [];

        foreach ($columns as $key => $column) {
            // Extract complete documents
            if (is_string($column) && substr($column, strlen($column) - 2)  === '.*') {
                $table = substr($column, 0, strlen($column) - 2);
                $returnDocs[] = $query->getTableAlias($table);

                continue;
            }

            // Extract groups
            if (is_array($query->groups) && in_array($column, $query->groups)) {
                $returnAttributes[$column] = $this->normalizeColumn($query, $column);

                continue;
            }

            if (is_string($column) && $column != null && $column != '*') {
                [$column, $alias] = $this->normalizeStringColumn($query, $key, $column);

                if (isset($returnAttributes[$alias]) && is_array($column)) {
                    $returnAttributes[$alias] = array_merge_recursive(
                        $returnAttributes[$alias],
                        $this->normalizeColumn($query, $column),
                    );
                    continue;
                }
                $returnAttributes[$alias] = $column;
            }
        }

        return [
            $returnAttributes,
            $returnDocs,
        ];
    }

    /**
     * @throws Exception
     */
    protected function normalizeColumn(IlluminateQueryBuilder $query, mixed $column, ?string $table = null): mixed
    {
        assert($query instanceof Builder);

        if ($column instanceof Expression) {
            return $column;
        }

        if (
            is_array($query->groups)
            && in_array($column, $query->groups)
            && debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT)[1]['function'] !== "compileGroups"
        ) {
            return $this->wrap($query->convertIdToKey($column));
            return $this->/** @scrutinizer ignore-call */ wrap($query->convertIdToKey($column));
        }

        if (is_array($column)) {
            $column = $this->convertJsonFields($column);

            foreach ($column as $key => $value) {
                $column[$key] = $this->normalizeColumn($query, $value, $table);
            }
            return $column;
        }

        if ($query->isVariable($column)) {
            return $this->wrap($column);
        }


        $column = $this->convertJsonFields($column);
        $column = $query->convertIdToKey($column);

        //We check for an existing alias to determine of the first reference is a table.
        // In which case we replace it with the alias.
        return $this->wrap($this->normalizeColumnReferences($query, $column, $table));
    }

    /**
     * @param Builder $query
     * @param int|string $key
     * @param string $column
     * @param string|null $table
     * @return array<mixed>
     * @throws Exception
     */
    protected function normalizeStringColumn(Builder $query, int|string $key, string $column, ?string $table = null): array
    {
        [$column, $alias] = $query->extractAlias($column, $key);

        $column = $query->convertIdToKey($column);

        $column = $this->wrap($this->normalizeColumnReferences($query, $column, $table));

        /** @phpstan-ignore-next-line */
        $alias = $this->cleanAlias($query, $alias);

        return [$column, $alias];
    }


    /**
     * @param IlluminateQueryBuilder $query
     * @param string $column
     * @param string|null $table
     * @return string
     */
    protected function normalizeColumnReferences(IlluminateQueryBuilder $query, string $column, ?string $table = null): string
    {
        assert($query instanceof Builder);

        if ($query->isReference($column)) {
            return $column;
        }

        if ($table == null) {

            $table = (string) $this->getValue($query->from);
            $table = (string) $this->/** @scrutinizer ignore-call */ getValue($query->from);
        }

        $references = explode('.', $column);


        $tableAlias = $query->getTableAlias($references[0]);

        if (isset($tableAlias)) {
            $references[0] = $tableAlias;
        }

        if (array_key_exists('groupsVariable', $query->tableAliases)) {
            $tableAlias = 'groupsVariable';
            array_unshift($references, $tableAlias);
        }

        if ($tableAlias === null  && array_key_exists($table, $query->tableAliases)) {
            array_unshift($references, $query->tableAliases[$table]);
        }

        if ($tableAlias === null && !$query->isReference($references[0])) {
            $tableAlias = $query->generateTableAlias($table);
            array_unshift($references, $tableAlias);
        }

        /** @phpstan-ignore-next-line */
        return implode('.', $references);
    }

    protected function cleanAlias(IlluminateQueryBuilder $query, int|null|string $alias): int|string|null
    {
        assert($query instanceof Builder);

        if (!is_string($alias)) {
            return $alias;
        }

        if (!str_contains($alias, '.')) {
            return $alias;
        }

        $elements = explode('.', $alias);

        if (
            !$query->isTable($elements[0])
            && !$query->isVariable($elements[0])
        ) {
            return $alias;
        }

        array_shift($elements);

        return implode($elements);
    }


    /**
     * @param IlluminateQueryBuilder $query
     * @param array<string> $returnAttributes
     * @param array<string>  $returnDocs
     * @return string
     */
    protected function determineReturnValues(IlluminateQueryBuilder $query, $returnAttributes = [], $returnDocs = []): string
    {
        assert($query instanceof Builder);

        // If nothing was specifically requested, we return everything.
        if (empty($returnAttributes) && empty($returnDocs)) {
            $returnDocs[] = (string) $query->getTableAlias($query->from);

            if ($query->joins !== null) {
                $returnDocs = $this->mergeJoinResults($query, $returnDocs);
            }
        }

        // Aggregate functions only return the aggregate, so we can clear out everything else.
        if ($query->aggregate !== null) {
            $returnDocs = [];
            $returnAttributes = ['aggregate' => 'aggregateResult'];
        }

        // Return a single value for certain subqueries
        if (
            $query->returnSingleValue === true
            && count($returnAttributes) === 1
            && empty($returnDocs)
        ) {
            return reset($returnAttributes);
        }

        if (!empty($returnAttributes)) {
            $returnDocs[] = $this->generateAqlObject($returnAttributes);
            $returnDocs[] = $this->generateAqlObject($returnAttributes);
        }

        $values = $this->mergeReturnDocs($returnDocs);

        return $values;
    }

    /**
     * @param array<string> $returnDocs
     * @return string
     */
    protected function mergeReturnDocs($returnDocs)
    {
        if (sizeOf($returnDocs) > 1) {
            return 'MERGE(' . implode(', ', $returnDocs) . ')';
        }

        return $returnDocs[0];
    }

    /**
     * @param IlluminateQueryBuilder $query
     * @param array<string> $returnDocs
     * @return array<string>
     */
    protected function mergeJoinResults(IlluminateQueryBuilder $query, $returnDocs = []): array
    {
        assert($query instanceof Builder);

        if (!is_array($query->joins)) {
            return $returnDocs;
        }

        foreach ($query->joins as $join) {
            $tableAlias = $query->getTableAlias($join->table);

            if (!isset($tableAlias)) {
                $tableAlias = $query->generateTableAlias($join->table);
            }
            $returnDocs[] = (string) $tableAlias;
        }

        return $returnDocs;
    }
}

LaravelFreelancerNL / laravel-arangodb

Push — next ( bea07e...b4e6e6 )

CompilesColumns::prepareColumns() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like
