LaravelFreelancerNL\Aranguent\Query\Concerns\BuildsSubqueries

Complexity

Total Complexity

10

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Test Coverage

Coverage

73.68%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	selectSub()	0	14	1
B	parseSub()	0	25	9

<?php

namespace LaravelFreelancerNL\Aranguent\Query\Concerns;

use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
use Illuminate\Database\Eloquent\Relations\Relation;
use InvalidArgumentException;
use LaravelFreelancerNL\Aranguent\Query\Builder;
use LaravelFreelancerNL\FluentAQL\Expressions\FunctionExpression;
use LaravelFreelancerNL\FluentAQL\QueryBuilder;

trait BuildsSubqueries
{
    /**
     * Add a subselect expression to the query.
     *
     * @param  Builder  $query
     * @param  string  $as
     * @return $this
     */
    public function selectSub($query, $as)
    {
        $query = $this->createSub($query);

It seems like createSub() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // Register $as as attribute alias
        $this->grammar->registerColumnAlias($as, $as);

        // Set $as as return value
        $this->columns[] = $as;

The property columns does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        // let alias = query
        $this->variables[$as] = $query;

The property variables does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $query;
    }

    /**
     * Parse the subquery into SQL and bindings.
     *
     * @param  Builder|EloquentBuilder|Relation|QueryBuilder|FunctionExpression|string  $query
     * @return array|QueryBuilder
     *
     * @throws \InvalidArgumentException
     */
    protected function parseSub($query)
    {
        if ($query instanceof self || $query instanceof EloquentBuilder || $query instanceof Relation) {
            $query = $this->prependDatabaseNameIfCrossDatabaseQuery($query);

It seems like prependDatabaseNameIfCrossDatabaseQuery() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $query->grammar->compileSelect($query);

            if (isset($query->limit) && $query->limit == 1) {
                //Return the value, not an array of values
                /** @phpstan-ignore-next-line */
                return $query->aqb->first($query->aqb);
            }

            return $query->aqb;
        }

        if ($query instanceof QueryBuilder || $query instanceof FunctionExpression) {
            return $query;

The expression return $query also could return the type LaravelFreelancerNL\FluentAQL\Expressions\FunctionExpression which is incompatible with the documented return type LaravelFreelancerNL\FluentAQL\QueryBuilder|array.

        }

        if (is_string($query)) {

The condition is_string($query) is always true.

            return $query;

The expression return $query returns the type string which is incompatible with the documented return type LaravelFreelancerNL\FluentAQL\QueryBuilder|array.

        }

        throw new InvalidArgumentException(
            'A subquery must be a query builder instance, a Closure, or a string.'
        );
    }
}