Passed
Push — refactor/improve-static-analys... ( ed4ce4 )
by Bas
15:29
created

Processor::processSelect()   A

Complexity

Conditions 4
Paths 3

Size

Total Lines 10
Code Lines 6

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 7
CRAP Score 4

Importance

Changes 0
Metric Value
eloc 6
dl 0
loc 10
ccs 7
cts 7
cp 1
rs 10
c 0
b 0
f 0
cc 4
nc 3
nop 2
crap 4
1
<?php
2
3
namespace LaravelFreelancerNL\Aranguent\Query;
4
5
use Illuminate\Database\Query\Builder;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, LaravelFreelancerNL\Aranguent\Query\Builder. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
6
use Illuminate\Database\Query\Processors\Processor as IlluminateProcessor;
7
8
class Processor extends IlluminateProcessor
9
{
10
    /**
11
     * Process the results of a "select" query.
12
     *
13
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
14
     *
15
     * @param Builder $query
16
     * @param  array<mixed>  $results
17
     * @return array<mixed>
18
     */
19 109
    public function processSelect(Builder $query, $results)
20
    {
21 109
        foreach ($results as &$val) {
22 105
            if (is_object($val) && isset($val->_key)) {
23 81
                $val = (array) $val;
24 81
                renameArrayKey($val, '_key', 'id');
25 81
                $val = (object) $val;
26
            }
27
        }
28 109
        return $results;
29
    }
30
}
31