LaravelFreelancerNL\Aranguent\Query\Concerns\BuildsJoinClauses::join()

Complexity

Conditions	4
Paths	6

Size

Total Lines	24
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4.1755

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function join($table, $first, $operator = null, $second = null, $type = 'inner', $where = false): Builder
    {
        $join = $this->newJoinClause($this, $type, $table);

$this of type LaravelFreelancerNL\Aranguent\Query\Concerns\BuildsJoinClauses is incompatible with the type Illuminate\Database\Query\Builder expected by parameter $parentQuery of LaravelFreelancerNL\Aranguent\Query\Concerns\BuildsJoinClauses::newJoinClause().

        // If the first "column" of the join is really a Closure instance the developer
        // is trying to build a join with a complex "on" clause containing more than
        // one condition, so we'll add the join and call a Closure with the query.
        if ($first instanceof Closure) {
            $first($join);

            $this->joins[] = $join;

The property joins does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }
        if (! $first instanceof Closure) {
            // If the column is simply a string, we can assume the join simply has a basic
            // "on" clause with a single condition. So we will just build the join with
            // this simple join clauses attached to it. There is not a join callback.

            //where and on are the same for aql
            $method = $where ? 'where' : 'on';

            $this->joins[] = $join->$method($first, $operator, $second);
        }

        return $this;

The expression return $this returns the type LaravelFreelancerNL\Aranguent\Query\Concerns\BuildsJoinClauses which includes types incompatible with the type-hinted return LaravelFreelancerNL\Aranguent\Query\Builder.

    }