LaravelFreelancerNL\Aranguent\Query\Concerns\GeneratesTableAlias

Complexity

Total Complexity

3

Size/Duplication

Total Lines	13
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	generateTableAlias()	0	11	3

<?php

namespace LaravelFreelancerNL\Aranguent\Query\Concerns;

use Illuminate\Database\Query\Expression;
use Illuminate\Support\Str;

trait GeneratesTableAlias
{
    public function generateTableAlias(string|Expression $table, string $postfix = 'Doc'): string
    {
        if (Str::startsWith($table, 'laravel_')) {

It seems like $table can also be of type Illuminate\Database\Query\Expression; however, parameter $haystack of Illuminate\Support\Str::startsWith() does only seem to accept string, maybe add an additional type check?

            return $table;

The expression return $table could return the type Illuminate\Database\Query\Expression which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

        }

        if ($table instanceof Expression) {
            return 'laravel_expression_' . spl_object_id($table);
        }

        return Str::camel(Str::singular($table)) . $postfix;
    }
}