LaravelFreelancerNL\Aranguent\Query\Concerns\BuildsWheres::where()

Complexity

Conditions	10
Paths	7

Size

Total Lines	77
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	29
CRAP Score	10.0822

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function where($column, $operator = null, $value = null, $boolean = 'and')
    {
        if ($column instanceof ConditionExpression) {
            $type = 'Expression';

            $this->wheres[] = compact('type', 'column', 'boolean');

The property wheres does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return $this;

The expression return $this returns the type LaravelFreelancerNL\Aranguent\Query\Concerns\BuildsWheres which is incompatible with the documented return type Illuminate\Database\Query\Builder.

        }

        // If the column is an array, we will assume it is an array of key-value pairs
        // and can add them each as a where clause. We will maintain the boolean we
        // received when the method was called and pass it into the nested where.
        if (is_array($column) && !array_is_list($column)) {
            return $this->addArrayOfWheres($column, $boolean);
        }

        // Here we will make some assumptions about the operator. If only 2 values are
        // passed to the method, we will assume that the operator is an equals sign
        // and keep going. Otherwise, we'll require the operator to be passed in.
        [$value, $operator] = $this->prepareValueAndOperator(
            $value,
            $operator,
            func_num_args() === 2,
        );

        // If the column is actually a Closure instance, we will assume the developer
        // wants to begin a nested where statement which is wrapped in parentheses.
        // We will add that Closure to the query and return back out immediately.
        if ($column instanceof Closure && is_null($operator)) {
            return $this->whereNested($column, $boolean);
        }

        // If the column is a Closure instance and there is an operator value, we will
        // assume the developer wants to run a subquery and then compare the result
        // of that subquery with the given value that was provided to the method.
        if ($this->isQueryable($column) && !is_null($operator)) {

It seems like isQueryable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            /** @phpstan-ignore-next-line  */
            [$subquery] = $this->createSub($column, true);

It seems like createSub() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $this->where(new Expression($subquery), $operator, $value, $boolean);
        }

        list($value, $operator) = $this->validateOperator($operator, $value);

        // If the value is a Closure, it means the developer is performing an entire
        // sub-select within the query and we will need to compile the sub-select
        // within the where clause to get the appropriate query record results.
        if ($this->isQueryable($value)) {
            /** @phpstan-ignore-next-line  */
            return $this->whereSub($column, $operator, $value, $boolean);
        }

        // If the value is "null", we will just assume the developer wants to add a
        // where null clause to the query. So, we will allow a short-cut here to
        // that method for convenience so the developer doesn't have to check.
        if (is_null($value)) {
            /** @phpstan-ignore-next-line  */
            return $this->whereNull($column, $boolean, $operator !== '==');

It seems like $column can also be of type Closure and Illuminate\Database\Eloquent\Builder and Illuminate\Database\Query\Builder; however, parameter $columns of LaravelFreelancerNL\Aranguent\Query\Concerns\BuildsWheres::whereNull() does only seem to accept Illuminate\Contracts\Database\Query\Expression|array<mixed,mixed>|string, maybe add an additional type check?

The expression return $this->whereNull($column, $boolean, $operator !== '==') returns the type LaravelFreelancerNL\Aranguent\Query\Concerns\BuildsWheres which is incompatible with the documented return type Illuminate\Database\Query\Builder.

        }

        $type = $this->getType($operator);

        $value = $this->bindValue($value);

        // Now that we are working with just a simple query we can put the elements
        // in our array and add the query binding to our array of bindings that
        // will be bound to each SQL statements when it is finally executed.
        $this->wheres[] = compact(
            'type',
            'column',
            'operator',
            'value',
            'boolean',
        );

        return $this;

The expression return $this returns the type LaravelFreelancerNL\Aranguent\Query\Concerns\BuildsWheres which is incompatible with the documented return type Illuminate\Database\Query\Builder.

    }