LaravelFreelancerNL /
laravel-arangodb
| Conditions | 2 |
| Paths | 2 |
| Total Lines | 311 |
| Code Lines | 4 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 15 | public function run() |
||
| 16 | { |
||
| 17 | $characters = '[ |
||
| 18 | { |
||
| 19 | "_key":"NedStark", |
||
| 20 | "name":"Ned", |
||
| 21 | "surname":"Stark", |
||
| 22 | "alive":true, |
||
| 23 | "age":41, |
||
| 24 | "residence_id":"winterfell", |
||
| 25 | "location_id":"king-s-landing" |
||
| 26 | }, |
||
| 27 | { |
||
| 28 | "_key":"RobertBaratheon", |
||
| 29 | "name":"Robert", |
||
| 30 | "surname":"Baratheon", |
||
| 31 | "alive":false, |
||
| 32 | "residence_id":"winterfell", |
||
| 33 | "location_id":"dragonstone" |
||
| 34 | }, |
||
| 35 | { |
||
| 36 | "_key":"JaimeLannister", |
||
| 37 | "name":"Jaime", |
||
| 38 | "surname":"Lannister", |
||
| 39 | "alive":true, |
||
| 40 | "age":36, |
||
| 41 | "residence_id":"the-red-keep" |
||
| 42 | }, |
||
| 43 | { |
||
| 44 | "_key":"CatelynStark", |
||
| 45 | "name":"Catelyn", |
||
| 46 | "surname":"Stark", |
||
| 47 | "alive":false, |
||
| 48 | "age":40, |
||
| 49 | "residence_id":"winterfell" |
||
| 50 | }, |
||
| 51 | { |
||
| 52 | "_key":"CerseiLannister", |
||
| 53 | "name":"Cersei", |
||
| 54 | "surname":"Lannister", |
||
| 55 | "alive":true, |
||
| 56 | "age":36, |
||
| 57 | "residence_id":"the-red-keep" |
||
| 58 | }, |
||
| 59 | { |
||
| 60 | "_key":"DaenerysTargaryen", |
||
| 61 | "name":"Daenerys", |
||
| 62 | "surname":"Targaryen", |
||
| 63 | "alive":true, |
||
| 64 | "age":16, |
||
| 65 | "residence_id":"winterfell" |
||
| 66 | }, |
||
| 67 | { |
||
| 68 | "_key":"JorahMormont", |
||
| 69 | "name":"Jorah", |
||
| 70 | "surname":"Mormont", |
||
| 71 | "alive":false, |
||
| 72 | "residence_id":"winterfell" |
||
| 73 | }, |
||
| 74 | { |
||
| 75 | "_key":"PetyrBaelish", |
||
| 76 | "name":"Petyr", |
||
| 77 | "surname":"Baelish", |
||
| 78 | "alive":false, |
||
| 79 | "residence_id":"the-red-keep" |
||
| 80 | }, |
||
| 81 | { |
||
| 82 | "_key":"ViserysTargaryen", |
||
| 83 | "name":"Viserys", |
||
| 84 | "surname":"Targaryen", |
||
| 85 | "alive":false, |
||
| 86 | "residence_id":null |
||
| 87 | }, |
||
| 88 | { |
||
| 89 | "_key":"JonSnow", |
||
| 90 | "name":"Jon", |
||
| 91 | "surname":"Snow", |
||
| 92 | "alive":true, |
||
| 93 | "age":16, |
||
| 94 | "residence_id":"winterfell" |
||
| 95 | }, |
||
| 96 | { |
||
| 97 | "_key":"SansaStark", |
||
| 98 | "name":"Sansa", |
||
| 99 | "surname":"Stark", |
||
| 100 | "alive":true, |
||
| 101 | "age":13, |
||
| 102 | "residence_id":"winterfell", |
||
| 103 | "location_id":"winterfell" |
||
| 104 | }, |
||
| 105 | { |
||
| 106 | "_key":"AryaStark", |
||
| 107 | "name":"Arya", |
||
| 108 | "surname":"Stark", |
||
| 109 | "alive":true, |
||
| 110 | "age":11, |
||
| 111 | "residence_id":"winterfell" |
||
| 112 | }, |
||
| 113 | { |
||
| 114 | "_key":"RobbStark", |
||
| 115 | "name":"Robb", |
||
| 116 | "surname":"Stark", |
||
| 117 | "alive":false, |
||
| 118 | "residence_id":"winterfell" |
||
| 119 | }, |
||
| 120 | { |
||
| 121 | "_key":"TheonGreyjoy", |
||
| 122 | "name":"Theon", |
||
| 123 | "surname":"Greyjoy", |
||
| 124 | "alive":true, |
||
| 125 | "age":16, |
||
| 126 | "residence_id":"winterfell" |
||
| 127 | }, |
||
| 128 | { |
||
| 129 | "_key":"BranStark", |
||
| 130 | "name":"Bran", |
||
| 131 | "surname":"Stark", |
||
| 132 | "alive":true, |
||
| 133 | "age":10, |
||
| 134 | "residence_id":"winterfell" |
||
| 135 | }, |
||
| 136 | { |
||
| 137 | "_key":"JoffreyBaratheon", |
||
| 138 | "name":"Joffrey", |
||
| 139 | "surname":"Baratheon", |
||
| 140 | "alive":false, |
||
| 141 | "age":19, |
||
| 142 | "residence_id":"the-red-keep" |
||
| 143 | }, |
||
| 144 | { |
||
| 145 | "_key":"SandorClegane", |
||
| 146 | "name":"Sandor", |
||
| 147 | "surname":"Clegane", |
||
| 148 | "alive":true, |
||
| 149 | "residence_id":"the-red-keep" |
||
| 150 | }, |
||
| 151 | { |
||
| 152 | "_key":"TyrionLannister", |
||
| 153 | "name":"Tyrion", |
||
| 154 | "surname":"Lannister", |
||
| 155 | "alive":true, |
||
| 156 | "age":32, |
||
| 157 | "residence_id":"the-red-keep" |
||
| 158 | }, |
||
| 159 | { |
||
| 160 | "_key":"KhalDrogo", |
||
| 161 | "name":"Khal", |
||
| 162 | "surname":"Drogo", |
||
| 163 | "alive":false, |
||
| 164 | "residence_id":"winterfell" |
||
| 165 | }, |
||
| 166 | { |
||
| 167 | "_key":"TywinLannister", |
||
| 168 | "name":"Tywin", |
||
| 169 | "surname":"Lannister", |
||
| 170 | "alive":false, |
||
| 171 | "residence_id":"the-red-keep" |
||
| 172 | }, |
||
| 173 | { |
||
| 174 | "_key":"DavosSeaworth", |
||
| 175 | "name":"Davos", |
||
| 176 | "surname":"Seaworth", |
||
| 177 | "alive":true, |
||
| 178 | "age":49, |
||
| 179 | "residence_id":"winterfell" |
||
| 180 | }, |
||
| 181 | { |
||
| 182 | "_key":"SamwellTarly", |
||
| 183 | "name":"Samwell", |
||
| 184 | "surname":"Tarly", |
||
| 185 | "alive":true, |
||
| 186 | "age":17, |
||
| 187 | "residence_id":"winterfell" |
||
| 188 | }, |
||
| 189 | { |
||
| 190 | "_key":"StannisBaratheon", |
||
| 191 | "name":"Stannis", |
||
| 192 | "surname":"Baratheon", |
||
| 193 | "alive":false, |
||
| 194 | "residence_id":"dragonstone" |
||
| 195 | }, |
||
| 196 | { |
||
| 197 | "_key":"Melisandre", |
||
| 198 | "name":"Melisandre", |
||
| 199 | "alive":true, |
||
| 200 | "residence_id":"dragonstone" |
||
| 201 | }, |
||
| 202 | { |
||
| 203 | "_key":"MargaeryTyrell", |
||
| 204 | "name":"Margaery", |
||
| 205 | "surname":"Tyrell", |
||
| 206 | "alive":false, |
||
| 207 | "residence_id":"winterfell" |
||
| 208 | }, |
||
| 209 | { |
||
| 210 | "_key":"JeorMormont", |
||
| 211 | "name":"Jeor", |
||
| 212 | "surname":"Mormont", |
||
| 213 | "alive":false, |
||
| 214 | "residence_id":null |
||
| 215 | }, |
||
| 216 | { |
||
| 217 | "_key":"Bronn", |
||
| 218 | "name":"Bronn", |
||
| 219 | "alive":true, |
||
| 220 | "residence_id":"king-s-landing" |
||
| 221 | }, |
||
| 222 | { |
||
| 223 | "_key":"Varys", |
||
| 224 | "name":"Varys", |
||
| 225 | "alive":true, |
||
| 226 | "residence_id":"the-red-keep" |
||
| 227 | }, |
||
| 228 | { |
||
| 229 | "_key":"Shae", |
||
| 230 | "name":"Shae", |
||
| 231 | "alive":false, |
||
| 232 | "residence_id":"the-red-keep" |
||
| 233 | }, |
||
| 234 | { |
||
| 235 | "_key":"TalisaMaegyr", |
||
| 236 | "name":"Talisa", |
||
| 237 | "surname":"Maegyr", |
||
| 238 | "alive":false |
||
| 239 | }, |
||
| 240 | { |
||
| 241 | "_key":"Gendry", |
||
| 242 | "name":"Gendry", |
||
| 243 | "alive":false, |
||
| 244 | "residence_id":"king-s-landing" |
||
| 245 | }, |
||
| 246 | { |
||
| 247 | "_key":"Ygritte", |
||
| 248 | "name":"Ygritte", |
||
| 249 | "alive":false, |
||
| 250 | "residence_id":"beyond-the-wall" |
||
| 251 | }, |
||
| 252 | { |
||
| 253 | "_key":"TormundGiantsbane", |
||
| 254 | "name":"Tormund", |
||
| 255 | "surname":"Giantsbane", |
||
| 256 | "alive":true, |
||
| 257 | "residence_id":"beyond-the-wall" |
||
| 258 | }, |
||
| 259 | { |
||
| 260 | "_key":"Gilly", |
||
| 261 | "name":"Gilly", |
||
| 262 | "alive":true, |
||
| 263 | "residence_id":"beyond-the-wall" |
||
| 264 | }, |
||
| 265 | { |
||
| 266 | "_key":"BrienneTarth", |
||
| 267 | "name":"Brienne", |
||
| 268 | "surname":"Tarth", |
||
| 269 | "alive":true, |
||
| 270 | "age":32 |
||
| 271 | }, |
||
| 272 | { |
||
| 273 | "_key":"RamsayBolton", |
||
| 274 | "name":"Ramsay", |
||
| 275 | "surname":"Bolton", |
||
| 276 | "alive":true |
||
| 277 | }, |
||
| 278 | { |
||
| 279 | "_key":"EllariaSand", |
||
| 280 | "name":"Ellaria", |
||
| 281 | "surname":"Sand", |
||
| 282 | "alive":true |
||
| 283 | }, |
||
| 284 | { |
||
| 285 | "_key":"DaarioNaharis", |
||
| 286 | "name":"Daario", |
||
| 287 | "surname":"Naharis", |
||
| 288 | "alive":true |
||
| 289 | }, |
||
| 290 | { |
||
| 291 | "_key":"Missandei", |
||
| 292 | "name":"Missandei", |
||
| 293 | "alive":true |
||
| 294 | }, |
||
| 295 | { |
||
| 296 | "_key":"TommenBaratheon", |
||
| 297 | "name":"Tommen", |
||
| 298 | "surname":"Baratheon", |
||
| 299 | "alive":true, |
||
| 300 | "residence_id":"the-red-keep" |
||
| 301 | }, |
||
| 302 | { |
||
| 303 | "_key":"JaqenHghar", |
||
| 304 | "name":"Jaqen", |
||
| 305 | "surname":"H\'ghar", |
||
| 306 | "alive":true |
||
| 307 | }, |
||
| 308 | { |
||
| 309 | "_key":"RooseBolton", |
||
| 310 | "name":"Roose", |
||
| 311 | "surname":"Bolton", |
||
| 312 | "alive":true |
||
| 313 | }, |
||
| 314 | { |
||
| 315 | "_key":"TheHighSparrow", |
||
| 316 | "name":"The High Sparrow", |
||
| 317 | "alive":true, |
||
| 318 | "residence_id":"king-s-landing" |
||
| 319 | } |
||
| 320 | ]'; |
||
| 321 | |||
| 322 | $characters = json_decode($characters, JSON_OBJECT_AS_ARRAY); |
||
|
Bug
introduced
by
|
|||
| 323 | |||
| 324 | foreach ($characters as $character) { |
||
| 325 | Character::insertOrIgnore($character); |
||
| 326 | } |
||
| 329 |
Loading history...