LaravelFreelancerNL\FluentAQL\Traits\CompilesPredicates

Complexity

Total Complexity

11

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Test Coverage

Coverage

48%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	compilePredicates()	0	18	5
A	compilePredicateGroup()	0	15	4
A	compilePredicate()	0	7	2

<?php

namespace LaravelFreelancerNL\FluentAQL\Traits;

use LaravelFreelancerNL\FluentAQL\Expressions\PredicateExpression;

/**
 * Trait hasFunctions.
 *
 * AQL Function API calls.
 */
trait CompilesPredicates
{
    /**
     * @param PredicateExpression|array $predicates
     * @return string
     */
    public function compilePredicates($predicates)
    {
        if (! is_array($predicates)) {
            $predicates = [$predicates];
        }

        $compiledPredicates = [];
        for ($i = 0; $i < count($predicates); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            if ($predicates[$i] instanceof PredicateExpression) {
                $compiledPredicates[] = $this->compilePredicate($predicates[$i], $i);
            }

            if (is_array($predicates[$i])) {
                $compiledPredicates[] = $this->compilePredicateGroup($predicates[$i], $i);
            }
        }

        return implode(' ', $compiledPredicates);
    }

    protected function compilePredicate(PredicateExpression $predicate, $position = 0)
    {
        $compiledPredicate = '';
        if ($position > 0) {
            $compiledPredicate = $predicate->logicalOperator . ' ' ;
        }
        return $compiledPredicate . $predicate->compile($this);
    }

    protected function compilePredicateGroup(array $predicates, $position = 0)
    {
        $compiledPredicates = [];
        if ($predicates[0] instanceof PredicateExpression) {
            $logicalOperator = $predicates[0]->logicalOperator;
        }
        for ($i = 0; $i < count($predicates); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $compiledPredicates[] = $this->compilePredicate($predicates[$i], $i);
        }

        $groupCompilation = '';
        if ($position > 0) {
            $groupCompilation = $logicalOperator.' ';

The variable $logicalOperator does not seem to be defined for all execution paths leading up to this point.

Expected at least 1 space before "."; 0 found

Expected at least 1 space after "."; 0 found

        }
        return $groupCompilation . '(' . implode(' ', $compiledPredicates) . ')';
    }
}