HttpClientConfig - Code Metrics - Inspection of "corrected build step" - LaravelFreelancerNL/arangodb-php-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — remanufacture/json-object-deco... ( 07d964...ba9553 )

by Bas

created 2021-04-27 05:43 UTC

HttpClientConfig A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	22
c	1
b	0
f	0
dl	0
loc	44
ccs	12
cts	12
cp	1
rs	10
wmc	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	mapGuzzleHttpClientConfig()	0	16	1

<?php

declare(strict_types=1);

namespace ArangoClient\Http;

use Spatie\DataTransferObject\DataTransferObject;

/**
 * Class HttpClientConfig
 *
 * @SuppressWarnings(PHPMD.CamelCasePropertyName)
 * (Guzzle uses snake_case for its configuration options)
 *
 * @package ArangoClient\Http
 */
class HttpClientConfig extends DataTransferObject
{
    public string $endpoint = 'http://localhost:8529';

    public ?string $host = null;

    public string|int|null $port = null;
filter:
    dependency_paths: ["lib/*"]

    public int|float $version = 1.1;

    public string $connection = 'Keep-Alive';

    /**
     * @var array<mixed>|false
     */
    public $allow_redirects = false;

    public float $connect_timeout = 0;

    public ?string $username = null;

    public ?string $password = null;

    public string $database = '_system';

    /**
     * @return array<array<mixed>|string|numeric|bool|null>
     */
    public function mapGuzzleHttpClientConfig(): array
    {
        $config = [];
        $config['base_uri'] = $this->endpoint;
        $config['version'] = $this->version;
        $config['allow_redirects'] = $this->allow_redirects;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $config['connect_timeout'] = $this->connect_timeout;

        $config['auth'] = [
            $this->username,
            $this->password,
        ];
        $config['headers'] = [
            'Connection' => $this->connection
        ];
        return $config;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace ArangoClient\Http;
6
7		use Spatie\DataTransferObject\DataTransferObject;
8
9		/**
10		* Class HttpClientConfig
11		*
12		* @SuppressWarnings(PHPMD.CamelCasePropertyName)
13		* (Guzzle uses snake_case for its configuration options)
14		*
15		* @package ArangoClient\Http
16		*/
17		class HttpClientConfig extends DataTransferObject
18		{
19		public string $endpoint = 'http://localhost:8529';
20
21		public ?string $host = null;
22
23		public string\|int\|null $port = null;
		0 ignored issues – show Bug introduced 2021-04-26 20:09 UTC by Report Bug Copy Issue Report The type `ArangoClient\Http\null` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
24
25		public int\|float $version = 1.1;
26
27		public string $connection = 'Keep-Alive';
28
29		/**
30		* @var array<mixed>\|false
31		*/
32		public $allow_redirects = false;
33
34		public float $connect_timeout = 0;
35
36		public ?string $username = null;
37
38		public ?string $password = null;
39
40		public string $database = '_system';
41
42		/**
43		* @return array<array<mixed>\|string\|numeric\|bool\|null>
44		*/
45	104	public function mapGuzzleHttpClientConfig(): array
46		{
47	104	$config = [];
48	104	$config['base_uri'] = $this->endpoint;
49	104	$config['version'] = $this->version;
50	104	$config['allow_redirects'] = $this->allow_redirects;
		0 ignored issues – show Documentation Bug introduced 2021-03-30 11:24 UTC by Report Bug Copy Issue Report It seems like `$this->allow_redirects` can also be of type `boolean`. However, the property `$allow_redirects` is declared as type `array<mixed,mixed>\|false`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
51	104	$config['connect_timeout'] = $this->connect_timeout;
52
53	104	$config['auth'] = [
54	104	$this->username,
55	104	$this->password,
56		];
57	104	$config['headers'] = [
58	104	'Connection' => $this->connection
59		];
60	104	return $config;
61		}
62		}
63

LaravelFreelancerNL / arangodb-php-client

Push — remanufacture/json-object-deco... ( 07d964...ba9553 )

HttpClientConfig A

Complexity

Size/Duplication

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like