Backpack\PermissionManager\app\Http\Controllers\PermissionCrudController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	82
Duplicated Lines	31.71 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	setup()	15	56	6
A	getGuardTypes()	11	11	2

<?php

namespace Backpack\PermissionManager\app\Http\Controllers;

use Backpack\CRUD\app\Http\Controllers\CrudController;
// VALIDATION

class PermissionCrudController extends CrudController
{
    use \Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\DeleteOperation;

    public function setup()
    {
        $role_model = config('backpack.permissionmanager.models.role');

$role_model is not used, you could remove the assignment.

        $permission_model = config('backpack.permissionmanager.models.permission');

        $this->crud->setModel($permission_model);
        $this->crud->setEntityNameStrings(trans('backpack::permissionmanager.permission_singular'), trans('backpack::permissionmanager.permission_plural'));
        $this->crud->setRoute(backpack_url('permission'));

It seems like backpack_url('permission') targeting backpack_url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Backpack\CRUD\CrudPanel::setRoute() does only seem to accept string, maybe add an additional type check?

        // deny access according to configuration file
        if (config('backpack.permissionmanager.allow_permission_create') == false) {
            $this->crud->denyAccess('create');
        }
        if (config('backpack.permissionmanager.allow_permission_update') == false) {
            $this->crud->denyAccess('update');
        }
        if (config('backpack.permissionmanager.allow_permission_delete') == false) {
            $this->crud->denyAccess('delete');
        }

        $this->crud->operation('list', function () {

The method operation() does not exist on Backpack\CRUD\CrudPanel. Did you maybe mean doingListOperation()?

            $this->crud->addColumn([
                'name'  => 'name',
                'label' => trans('backpack::permissionmanager.name'),
                'type'  => 'text',
            ]);

            if (config('backpack.permissionmanager.multiple_guards')) {

This code seems to be duplicated across your project.

                $this->crud->addColumn([
                    'name'  => 'guard_name',
                    'label' => trans('backpack::permissionmanager.guard_type'),
                    'type'  => 'text',
                ]);
            }
        });

        $this->crud->operation(['create', 'update'], function () {

The method operation() does not exist on Backpack\CRUD\CrudPanel. Did you maybe mean doingListOperation()?

            $this->crud->addField([
                'name'  => 'name',
                'label' => trans('backpack::permissionmanager.name'),
                'type'  => 'text',
            ]);

            if (config('backpack.permissionmanager.multiple_guards')) {

This code seems to be duplicated across your project.

                $this->crud->addField([
                    'name'    => 'guard_name',
                    'label'   => trans('backpack::permissionmanager.guard_type'),
                    'type'    => 'select_from_array',
                    'options' => $this->getGuardTypes(),
                ]);
            }

            //otherwise, changes won't have effect
            \Cache::forget('spatie.permission.cache');
        });
    }

    /*
     * Get an array list of all available guard types
     * that have been defined in app/config/auth.php
     *
     * @return array
     **/
    private function getGuardTypes()

This method seems to be duplicated in your project.

    {
        $guards = config('auth.guards');

        $returnable = [];
        foreach ($guards as $key => $details) {
            $returnable[$key] = $key;
        }

        return $returnable;
    }
}