RoleCrudController::setup() - Code Metrics - Inspection of "composer requirement" - Laravel-Backpack/PermissionManager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d1373b...643f9e )

by Cristian

created 2018-12-12 08:48 UTC

RoleCrudController::setup() B

↳ Parent: RoleCrudController

Complexity

Conditions	6
Paths	32

Size

Total Lines

Duplication

Lines	15
Ratio	21.74 %

Importance

Changes

Metric	Value
dl	15
loc	69
rs	8.0541
c	0
b	0
f	0
cc	6
nc	32
nop	0

How to fix Long Method

<?php

namespace Backpack\PermissionManager\app\Http\Controllers;

use Backpack\CRUD\app\Http\Controllers\CrudController;
// VALIDATION
use Backpack\PermissionManager\app\Http\Requests\RoleCrudRequest as StoreRequest;
use Backpack\PermissionManager\app\Http\Requests\RoleCrudRequest as UpdateRequest;

class RoleCrudController extends CrudController
{
    public function setup()
    {
        $role_model = config('backpack.permissionmanager.models.role');
        $permission_model = config('backpack.permissionmanager.models.permission');

        $this->crud->setModel($role_model);
        $this->crud->setEntityNameStrings(trans('backpack::permissionmanager.role'), trans('backpack::permissionmanager.roles'));

        $this->crud->setRoute(backpack_url('role'));

        $this->crud->addColumn([
            'name'  => 'name',
            'label' => trans('backpack::permissionmanager.name'),
            'type'  => 'text',
        ]);

        if (config('backpack.permissionmanager.multiple_guards')) {

            $this->crud->addColumn([
                'name'  => 'guard_name',
                'label' => trans('backpack::permissionmanager.guard_type'),
                'type'  => 'text',
            ]);
        }

        $this->crud->addColumn([
            // n-n relationship (with pivot table)
            'label'     => ucfirst(trans('backpack::permissionmanager.permission_plural')),
            'type'      => 'select_multiple',
            'name'      => 'permissions', // the method that defines the relationship in your Model
            'entity'    => 'permissions', // the method that defines the relationship in your Model
            'attribute' => 'name', // foreign key attribute that is shown to user
            'model'     => $permission_model, // foreign key model
            'pivot'     => true, // on create&update, do you need to add/delete pivot table entries?
        ]);

        $this->crud->addField([
            'name'  => 'name',
            'label' => trans('backpack::permissionmanager.name'),
            'type'  => 'text',
        ]);

        if (config('backpack.permissionmanager.multiple_guards')) {

            $this->crud->addField([
                'name'    => 'guard_name',
                'label'   => trans('backpack::permissionmanager.guard_type'),
                'type'    => 'select_from_array',
                'options' => $this->getGuardTypes(),
            ]);
        }

        $this->crud->addField([
            'label'     => ucfirst(trans('backpack::permissionmanager.permission_plural')),
            'type'      => 'checklist',
            'name'      => 'permissions',
            'entity'    => 'permissions',
            'attribute' => 'name',
            'model'     => $permission_model,
            'pivot'     => true,
        ]);

        if (config('backpack.permissionmanager.allow_role_create') == false) {
            $this->crud->denyAccess('create');
        }
        if (config('backpack.permissionmanager.allow_role_update') == false) {
            $this->crud->denyAccess('update');
        }
        if (config('backpack.permissionmanager.allow_role_delete') == false) {
            $this->crud->denyAccess('delete');
        }
    }

    public function store(StoreRequest $request)
    {
        //otherwise, changes won't have effect
        \Cache::forget('spatie.permission.cache');

        return parent::storeCrud();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    public function update(UpdateRequest $request)
    {
        //otherwise, changes won't have effect
        \Cache::forget('spatie.permission.cache');

        return parent::updateCrud();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /*
     * Get an array list of all available guard types
     * that have been defined in app/config/auth.php
     *
     * @return array
     **/
    private function getGuardTypes()

    {
        $guards = config('auth.guards');

        $returnable = [];
        foreach ($guards as $key => $details) {
            $returnable[$key] = $key;
        }

        return $returnable;
    }
}


1		<?php
2
3		namespace Backpack\PermissionManager\app\Http\Controllers;
4
5		use Backpack\CRUD\app\Http\Controllers\CrudController;
6		// VALIDATION
7		use Backpack\PermissionManager\app\Http\Requests\RoleCrudRequest as StoreRequest;
8		use Backpack\PermissionManager\app\Http\Requests\RoleCrudRequest as UpdateRequest;
9
10		class RoleCrudController extends CrudController
11		{
12		public function setup()
13		{
14		$role_model = config('backpack.permissionmanager.models.role');
15		$permission_model = config('backpack.permissionmanager.models.permission');
16
17		$this->crud->setModel($role_model);
18		$this->crud->setEntityNameStrings(trans('backpack::permissionmanager.role'), trans('backpack::permissionmanager.roles'));
		0 ignored issues – show Coding Style introduced 2016-10-19 22:53 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 129 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
19		$this->crud->setRoute(backpack_url('role'));
20
21		$this->crud->addColumn([
22		'name' => 'name',
23		'label' => trans('backpack::permissionmanager.name'),
24		'type' => 'text',
25		]);
26
27	View Code Duplication	if (config('backpack.permissionmanager.multiple_guards')) {
		0 ignored issues – show Duplication introduced 2018-12-12 08:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		$this->crud->addColumn([
29		'name' => 'guard_name',
30		'label' => trans('backpack::permissionmanager.guard_type'),
31		'type' => 'text',
32		]);
33		}
34
35		$this->crud->addColumn([
36		// n-n relationship (with pivot table)
37		'label' => ucfirst(trans('backpack::permissionmanager.permission_plural')),
38		'type' => 'select_multiple',
39		'name' => 'permissions', // the method that defines the relationship in your Model
40		'entity' => 'permissions', // the method that defines the relationship in your Model
41		'attribute' => 'name', // foreign key attribute that is shown to user
42		'model' => $permission_model, // foreign key model
43		'pivot' => true, // on create&update, do you need to add/delete pivot table entries?
44		]);
45
46		$this->crud->addField([
47		'name' => 'name',
48		'label' => trans('backpack::permissionmanager.name'),
49		'type' => 'text',
50		]);
51
52	View Code Duplication	if (config('backpack.permissionmanager.multiple_guards')) {
		0 ignored issues – show Duplication introduced 2018-12-12 08:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		$this->crud->addField([
54		'name' => 'guard_name',
55		'label' => trans('backpack::permissionmanager.guard_type'),
56		'type' => 'select_from_array',
57		'options' => $this->getGuardTypes(),
58		]);
59		}
60
61		$this->crud->addField([
62		'label' => ucfirst(trans('backpack::permissionmanager.permission_plural')),
63		'type' => 'checklist',
64		'name' => 'permissions',
65		'entity' => 'permissions',
66		'attribute' => 'name',
67		'model' => $permission_model,
68		'pivot' => true,
69		]);
70
71		if (config('backpack.permissionmanager.allow_role_create') == false) {
72		$this->crud->denyAccess('create');
73		}
74		if (config('backpack.permissionmanager.allow_role_update') == false) {
75		$this->crud->denyAccess('update');
76		}
77		if (config('backpack.permissionmanager.allow_role_delete') == false) {
78		$this->crud->denyAccess('delete');
79		}
80		}
81
82		public function store(StoreRequest $request)
83		{
84		//otherwise, changes won't have effect
85		\Cache::forget('spatie.permission.cache');
86
87		return parent::storeCrud();
		0 ignored issues – show Comprehensibility Bug introduced 2017-08-04 17:38 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`storeCrud()` instead of `store()`). Are you sure this is correct? If so, you might want to change this to `$this->storeCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
88		}
89
90		public function update(UpdateRequest $request)
91		{
92		//otherwise, changes won't have effect
93		\Cache::forget('spatie.permission.cache');
94
95		return parent::updateCrud();
		0 ignored issues – show Comprehensibility Bug introduced 2017-09-02 19:26 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`updateCrud()` instead of `update()`). Are you sure this is correct? If so, you might want to change this to `$this->updateCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
96		}
97
98		/*
99		* Get an array list of all available guard types
100		* that have been defined in app/config/auth.php
101		*
102		* @return array
103		**/
104	View Code Duplication	private function getGuardTypes()
		0 ignored issues – show Duplication introduced 2018-12-12 08:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
105		{
106		$guards = config('auth.guards');
107
108		$returnable = [];
109		foreach ($guards as $key => $details) {
110		$returnable[$key] = $key;
111		}
112
113		return $returnable;
114		}
115		}
116

Laravel-Backpack / PermissionManager

Scrutinizer GitHub App not installed

Push — master ( d1373b...643f9e )

RoleCrudController::setup() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like