PermissionCrudController::setup() - Code Metrics - Inspection of "Made it work on bp v4" - Laravel-Backpack/PermissionManager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#199)

by Cristian

created 2019-09-06 08:59 UTC

PermissionCrudController::setup() B

↳ Parent: PermissionCrudController

Complexity

Conditions	6
Paths	8

Size

Total Lines

Duplication

Lines	15
Ratio	26.79 %

Importance

Changes

Metric	Value
dl	15
loc	56
rs	8.3377
c	0
b	0
f	0
cc	6
nc	8
nop	0

How to fix Long Method

<?php

namespace Backpack\PermissionManager\app\Http\Controllers;

use Backpack\CRUD\app\Http\Controllers\CrudController;

// VALIDATION

class PermissionCrudController extends CrudController
{
    use \Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\DeleteOperation;

    public function setup()
    {
        $role_model = config('backpack.permissionmanager.models.role');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $permission_model = config('backpack.permissionmanager.models.permission');

        $this->crud->setModel($permission_model);
        $this->crud->setEntityNameStrings(trans('backpack::permissionmanager.permission_singular'), trans('backpack::permissionmanager.permission_plural'));
        $this->crud->setRoute(backpack_url('permission'));

        // deny access according to configuration file
        if (config('backpack.permissionmanager.allow_permission_create') == false) {
            $this->crud->denyAccess('create');
        }
        if (config('backpack.permissionmanager.allow_permission_update') == false) {
            $this->crud->denyAccess('update');
        }
        if (config('backpack.permissionmanager.allow_permission_delete') == false) {
            $this->crud->denyAccess('delete');
        }

        $this->crud->operation('list', function () {
            $this->crud->addColumn([
                'name'  => 'name',
                'label' => trans('backpack::permissionmanager.name'),
                'type'  => 'text',
            ]);

            if (config('backpack.permissionmanager.multiple_guards')) {

                $this->crud->addColumn([
                    'name'  => 'guard_name',
                    'label' => trans('backpack::permissionmanager.guard_type'),
                    'type'  => 'text',
                ]);
            }
        });

        $this->crud->operation(['create', 'update'], function () {
            $this->crud->addField([
                'name'  => 'name',
                'label' => trans('backpack::permissionmanager.name'),
                'type'  => 'text',
            ]);

            if (config('backpack.permissionmanager.multiple_guards')) {

                $this->crud->addField([
                    'name'    => 'guard_name',
                    'label'   => trans('backpack::permissionmanager.guard_type'),
                    'type'    => 'select_from_array',
                    'options' => $this->getGuardTypes(),
                ]);
            }

            //otherwise, changes won't have effect
            \Cache::forget('spatie.permission.cache');
        });
    }

    /*
     * Get an array list of all available guard types
     * that have been defined in app/config/auth.php
     *
     * @return array
     **/
    private function getGuardTypes()

    {
        $guards = config('auth.guards');

        $returnable = [];
        foreach ($guards as $key => $details) {
            $returnable[$key] = $key;
        }

        return $returnable;
    }
}


1		<?php
2
3		namespace Backpack\PermissionManager\app\Http\Controllers;
4
5		use Backpack\CRUD\app\Http\Controllers\CrudController;
6
7		// VALIDATION
8
9		class PermissionCrudController extends CrudController
10		{
11		use \Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;
12		use \Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation;
13		use \Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;
14		use \Backpack\CRUD\app\Http\Controllers\Operations\DeleteOperation;
15
16		public function setup()
17		{
18		$role_model = config('backpack.permissionmanager.models.role');
		0 ignored issues – show Unused Code introduced 2018-12-12 08:55 UTC by Report Bug Copy Issue Report `$role_model` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
19		$permission_model = config('backpack.permissionmanager.models.permission');
20
21		$this->crud->setModel($permission_model);
22		$this->crud->setEntityNameStrings(trans('backpack::permissionmanager.permission_singular'), trans('backpack::permissionmanager.permission_plural'));
23		$this->crud->setRoute(backpack_url('permission'));
24
25		// deny access according to configuration file
26		if (config('backpack.permissionmanager.allow_permission_create') == false) {
27		$this->crud->denyAccess('create');
28		}
29		if (config('backpack.permissionmanager.allow_permission_update') == false) {
30		$this->crud->denyAccess('update');
31		}
32		if (config('backpack.permissionmanager.allow_permission_delete') == false) {
33		$this->crud->denyAccess('delete');
34		}
35
36		$this->crud->operation('list', function () {
37		$this->crud->addColumn([
38		'name' => 'name',
39		'label' => trans('backpack::permissionmanager.name'),
40		'type' => 'text',
41		]);
42
43	View Code Duplication	if (config('backpack.permissionmanager.multiple_guards')) {
		0 ignored issues – show Duplication introduced 2018-12-12 08:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		$this->crud->addColumn([
45		'name' => 'guard_name',
46		'label' => trans('backpack::permissionmanager.guard_type'),
47		'type' => 'text',
48		]);
49		}
50		});
51
52		$this->crud->operation(['create', 'update'], function () {
53		$this->crud->addField([
54		'name' => 'name',
55		'label' => trans('backpack::permissionmanager.name'),
56		'type' => 'text',
57		]);
58
59	View Code Duplication	if (config('backpack.permissionmanager.multiple_guards')) {
		0 ignored issues – show Duplication introduced 2018-12-12 08:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		$this->crud->addField([
61		'name' => 'guard_name',
62		'label' => trans('backpack::permissionmanager.guard_type'),
63		'type' => 'select_from_array',
64		'options' => $this->getGuardTypes(),
65		]);
66		}
67
68		//otherwise, changes won't have effect
69		\Cache::forget('spatie.permission.cache');
70		});
71		}
72
73		/*
74		* Get an array list of all available guard types
75		* that have been defined in app/config/auth.php
76		*
77		* @return array
78		**/
79	View Code Duplication	private function getGuardTypes()
		0 ignored issues – show Duplication introduced 2018-12-12 08:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80		{
81		$guards = config('auth.guards');
82
83		$returnable = [];
84		foreach ($guards as $key => $details) {
85		$returnable[$key] = $key;
86		}
87
88		return $returnable;
89		}
90		}
91

Laravel-Backpack / PermissionManager

Scrutinizer GitHub App not installed

Pull Request — master (#199)

PermissionCrudController::setup() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like