CreatePermissionTables::up() - Code Metrics - Inspection of "Fix for Issue #161" - Laravel-Backpack/PermissionManager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#162)

unknown

created 2018-06-24 21:59 UTC

CreatePermissionTables::up() B

↳ Parent: CreatePermissionTables

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	22
Ratio	36.07 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	22
loc	61
rs	8.8509
cc	1
nc	1
nop	0

How to fix Long Method

<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;

class CreatePermissionTables extends Migration
namespace YourVendor;

class YourClass { }
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        $tableNames = config('permission.table_names');

        Schema::create($tableNames['permissions'], function (Blueprint $table) {
            $table->increments('id');
            $table->string('name');
            $table->string('guard_name');
            $table->timestamps();
        });

        Schema::create($tableNames['roles'], function (Blueprint $table) {
            $table->increments('id');
            $table->string('name');
            $table->string('guard_name');
            $table->timestamps();
        });

        Schema::create($tableNames['model_has_permissions'], function (Blueprint $table) use ($tableNames) {

            $table->integer('permission_id')->unsigned();
            $table->morphs('model');

            $table->foreign('permission_id')
                ->references('id')
                ->on($tableNames['permissions'])
                ->onDelete('cascade');

            $table->primary(['permission_id', 'model_id', 'model_type']);
        });

        Schema::create($tableNames['model_has_roles'], function (Blueprint $table) use ($tableNames) {

            $table->integer('role_id')->unsigned();
            $table->morphs('model');

            $table->foreign('role_id')
                ->references('id')
                ->on($tableNames['roles'])
                ->onDelete('cascade');

            $table->primary(['role_id', 'model_id', 'model_type']);
        });

        Schema::create($tableNames['role_has_permissions'], function (Blueprint $table) use ($tableNames) {
            $table->integer('permission_id')->unsigned();
            $table->integer('role_id')->unsigned();

            $table->foreign('permission_id')
                ->references('id')
                ->on($tableNames['permissions'])
                ->onDelete('cascade');

            $table->foreign('role_id')
                ->references('id')
                ->on($tableNames['roles'])
                ->onDelete('cascade');

            $table->primary(['permission_id', 'role_id']);

            Cache::forget('spatie.permission.cache');
        });
    }

    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        $tableNames = config('permission.table_names');

        Schema::drop($tableNames['role_has_permissions']);
        Schema::drop($tableNames['model_has_roles']);
        Schema::drop($tableNames['model_has_permissions']);
        Schema::drop($tableNames['roles']);
        Schema::drop($tableNames['permissions']);
    }
}


1		<?php
2
3		use Illuminate\Database\Migrations\Migration;
4		use Illuminate\Database\Schema\Blueprint;
5
6		class CreatePermissionTables extends Migration
		0 ignored issues – show Coding Style Compatibility introduced 2016-05-18 14:25 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		/**
9		* Run the migrations.
10		*
11		* @return void
12		*/
13		public function up()
14		{
15		$tableNames = config('permission.table_names');
16
17		Schema::create($tableNames['permissions'], function (Blueprint $table) {
18		$table->increments('id');
19		$table->string('name');
20		$table->string('guard_name');
21		$table->timestamps();
22		});
23
24		Schema::create($tableNames['roles'], function (Blueprint $table) {
25		$table->increments('id');
26		$table->string('name');
27		$table->string('guard_name');
28		$table->timestamps();
29		});
30
31	View Code Duplication	Schema::create($tableNames['model_has_permissions'], function (Blueprint $table) use ($tableNames) {
		0 ignored issues – show Duplication introduced 2017-09-06 12:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		$table->integer('permission_id')->unsigned();
33		$table->morphs('model');
34
35		$table->foreign('permission_id')
36		->references('id')
37		->on($tableNames['permissions'])
38		->onDelete('cascade');
39
40		$table->primary(['permission_id', 'model_id', 'model_type']);
41		});
42
43	View Code Duplication	Schema::create($tableNames['model_has_roles'], function (Blueprint $table) use ($tableNames) {
		0 ignored issues – show Duplication introduced 2017-09-06 12:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		$table->integer('role_id')->unsigned();
45		$table->morphs('model');
46
47		$table->foreign('role_id')
48		->references('id')
49		->on($tableNames['roles'])
50		->onDelete('cascade');
51
52		$table->primary(['role_id', 'model_id', 'model_type']);
53		});
54
55		Schema::create($tableNames['role_has_permissions'], function (Blueprint $table) use ($tableNames) {
56		$table->integer('permission_id')->unsigned();
57		$table->integer('role_id')->unsigned();
58
59		$table->foreign('permission_id')
60		->references('id')
61		->on($tableNames['permissions'])
62		->onDelete('cascade');
63
64		$table->foreign('role_id')
65		->references('id')
66		->on($tableNames['roles'])
67		->onDelete('cascade');
68
69		$table->primary(['permission_id', 'role_id']);
70
71		Cache::forget('spatie.permission.cache');
72		});
73		}
74
75		/**
76		* Reverse the migrations.
77		*
78		* @return void
79		*/
80		public function down()
81		{
82		$tableNames = config('permission.table_names');
83
84		Schema::drop($tableNames['role_has_permissions']);
85		Schema::drop($tableNames['model_has_roles']);
86		Schema::drop($tableNames['model_has_permissions']);
87		Schema::drop($tableNames['roles']);
88		Schema::drop($tableNames['permissions']);
89		}
90		}
91

Laravel-Backpack / PermissionManager

Scrutinizer GitHub App not installed

Pull Request — master (#162)

CreatePermissionTables::up() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like