RoleCrudController::__construct() - Code Metrics - Inspection of "updated controllers" - Laravel-Backpack/PermissionManager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 766727...7a5d19 )

by Cristian

created 2016-12-03 05:44 UTC

RoleCrudController::__construct() A

↳ Parent: RoleCrudController

Complexity

Conditions	3
Paths	4

Size

Total Lines	48
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	48
rs	9.125
c	0
b	0
f	0
cc	3
eloc	32
nc	4
nop	0

<?php

namespace Backpack\PermissionManager\app\Http\Controllers;

use Backpack\CRUD\app\Http\Controllers\CrudController;
// VALIDATION
use Backpack\PermissionManager\app\Http\Requests\RoleCrudRequest as StoreRequest;
use Backpack\PermissionManager\app\Http\Requests\RoleCrudRequest as UpdateRequest;

class RoleCrudController extends CrudController
{
    public function setup()
    {
        $this->crud->setModel(config('laravel-permission.models.role'));
        $this->crud->setEntityNameStrings(trans('backpack::permissionmanager.role'), trans('backpack::permissionmanager.roles'));

        $this->crud->setRoute(config('backpack.base.route_prefix').'/role');

        $this->crud->setColumns([
            [
                'name'  => 'name',
                'label' => trans('backpack::permissionmanager.name'),
                'type'  => 'text',
            ],
            [
                // n-n relationship (with pivot table)
                'label'     => ucfirst(trans('backpack::permissionmanager.permission_plural')),
                'type'      => 'select_multiple',
                'name'      => 'permissions', // the method that defines the relationship in your Model
                'entity'    => 'permissions', // the method that defines the relationship in your Model
                'attribute' => 'name', // foreign key attribute that is shown to user
                'model'     => "Backpack\PermissionManager\app\Models\Permission", // foreign key model
                'pivot'     => true, // on create&update, do you need to add/delete pivot table entries?
            ],
        ]);

        $this->crud->addField([
            'name'  => 'name',
            'label' => trans('backpack::permissionmanager.name'),
            'type'  => 'text',
        ]);
        $this->crud->addField([
            'label'     => ucfirst(trans('backpack::permissionmanager.permission_plural')),
            'type'      => 'checklist',
            'name'      => 'permissions',
            'entity'    => 'permissions',
            'attribute' => 'name',
            'model'     => "Backpack\PermissionManager\app\Models\Permission",
            'pivot'     => true,
        ]);

        if (config('backpack.permissionmanager.allow_role_create') == false) {
            $this->crud->denyAccess('create');
        }
        if (config('backpack.permissionmanager.allow_role_update') == false) {
            $this->crud->denyAccess('update');
        }
    }

    public function store(StoreRequest $request)

    {
        return parent::storeCrud();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    public function update(UpdateRequest $request)

    {
        return parent::updateCrud();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2
3			namespace Backpack\PermissionManager\app\Http\Controllers;
4
5			use Backpack\CRUD\app\Http\Controllers\CrudController;
6			// VALIDATION
7			use Backpack\PermissionManager\app\Http\Requests\RoleCrudRequest as StoreRequest;
8			use Backpack\PermissionManager\app\Http\Requests\RoleCrudRequest as UpdateRequest;
9
10			class RoleCrudController extends CrudController
11			{
12			public function setup()
13			{
14			$this->crud->setModel(config('laravel-permission.models.role'));
15			$this->crud->setEntityNameStrings(trans('backpack::permissionmanager.role'), trans('backpack::permissionmanager.roles'));
			0 ignored issues – show Coding Style introduced 2016-10-19 22:53 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 129 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
16			$this->crud->setRoute(config('backpack.base.route_prefix').'/role');
17
18			$this->crud->setColumns([
19			[
20			'name' => 'name',
21			'label' => trans('backpack::permissionmanager.name'),
22			'type' => 'text',
23			],
24			[
25			// n-n relationship (with pivot table)
26			'label' => ucfirst(trans('backpack::permissionmanager.permission_plural')),
27			'type' => 'select_multiple',
28			'name' => 'permissions', // the method that defines the relationship in your Model
29			'entity' => 'permissions', // the method that defines the relationship in your Model
30			'attribute' => 'name', // foreign key attribute that is shown to user
31			'model' => "Backpack\PermissionManager\app\Models\Permission", // foreign key model
32			'pivot' => true, // on create&update, do you need to add/delete pivot table entries?
33			],
34			]);
35
36			$this->crud->addField([
37			'name' => 'name',
38			'label' => trans('backpack::permissionmanager.name'),
39			'type' => 'text',
40			]);
41			$this->crud->addField([
42			'label' => ucfirst(trans('backpack::permissionmanager.permission_plural')),
43			'type' => 'checklist',
44			'name' => 'permissions',
45			'entity' => 'permissions',
46			'attribute' => 'name',
47			'model' => "Backpack\PermissionManager\app\Models\Permission",
48			'pivot' => true,
49			]);
50
51			if (config('backpack.permissionmanager.allow_role_create') == false) {
52			$this->crud->denyAccess('create');
53			}
54			if (config('backpack.permissionmanager.allow_role_update') == false) {
55			$this->crud->denyAccess('update');
56			}
57			}
58
59			public function store(StoreRequest $request)
			0 ignored issues – show Unused Code introduced 2016-05-18 14:25 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
60			{
61			return parent::storeCrud();
			0 ignored issues – show Comprehensibility Bug introduced 2016-05-18 14:25 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`storeCrud()` instead of `store()`). Are you sure this is correct? If so, you might want to change this to `$this->storeCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
62			}
63
64			public function update(UpdateRequest $request)
			0 ignored issues – show Unused Code introduced 2016-05-18 14:25 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
65			{
66			return parent::updateCrud();
			0 ignored issues – show Comprehensibility Bug introduced 2016-05-18 14:25 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`updateCrud()` instead of `update()`). Are you sure this is correct? If so, you might want to change this to `$this->updateCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
67			}
68			}
69

Laravel-Backpack / PermissionManager

Scrutinizer GitHub App not installed

Push — master ( 766727...7a5d19 )

RoleCrudController::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like