Backpack\PermissionManager\PermissionManagerServiceProvider

Complexity

Total Complexity

3

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	boot()	0	12	1
A	setupRoutes()	0	7	1
A	register()	0	10	1

<?php
namespace Backpack\PermissionManager;

use Illuminate\Routing\Router;
use Illuminate\Support\ServiceProvider;
use Illuminate\Support\Facades\DB;
use Illuminate\Database\Eloquent\Model as Eloquent;
use Config;

class PermissionManagerServiceProvider extends ServiceProvider
{
    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = false;
    /**
     * Perform post-registration booting of services.
     *
     * @return void
     */
    public function boot()
    {
        // use the vendor configuration file as fallback
        echo '<pre>'; var_dump( __DIR__.'/config/laravel-permission.php'); echo '</pre>'; die();

var_dump(__DIR__ . '/config/laravel-permission.php'); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

The method boot() contains an exit expression.

It is generally recommended to place each PHP statement on a line by itself.

        $this->mergeConfigFrom(

$this->mergeConfigFrom(__DIR__ . '/config/laravel-permission.php', 'laravel-permission'); does not seem to be reachable.

            __DIR__.'/config/laravel-permission.php', 'laravel-permission'
        );

        // publish config file
        $this->publishes([ __DIR__.'/config/laravel-permission.php' => config_path('laravel-permission.php'), ], 'config');

This line exceeds maximum limit of 120 characters; contains 123 characters

    }
    /**
     * Define the routes for the application.
     *
     * @param  \Illuminate\Routing\Router  $router
     * @return void
     */
    public function setupRoutes(Router $router)
    {
        $router->group(['namespace' => 'Backpack\PermissionManager\app\Http\Controllers'], function($router)
        {
            require __DIR__.'/app/Http/routes.php';
        });
    }
    /**
     * Register any package services.
     *
     * @return void
     */
    public function register()
    {
        //$this->registerPermissions();

84% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->setupRoutes($this->app->router);

Accessing router on the interface Illuminate\Contracts\Foundation\Application suggest that you code against a concrete implementation. How about adding an instanceof check?

        // use this if your package has a config file
         // config([
         //         'config/laravel-permission.php',
         // ]);
    }

}