Backpack\PageManager\PageManagerServiceProvider

Complexity

Total Complexity

3

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	boot()	0	13	1
B	setupRoutes()	0	24	1
A	register()	0	4	1

<?php

namespace Backpack\PageManager;

use Route;
use Illuminate\Routing\Router;
use Illuminate\Support\ServiceProvider;

class PageManagerServiceProvider extends ServiceProvider
{
    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = false;

    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var string
     */
    protected $adminControllerClass = 'Backpack\PageManager\App\Http\Controllers\Admin\PageCrudController';

    /**
     * Perform post-registration booting of services.
     *
     * @return void
     */
    public function boot()
    {
        // publish views
        $this->publishes([__DIR__.'/resources/views' => base_path('resources/views')], 'views');
        // publish PageTemplates trait
        $this->publishes([__DIR__.'/app/PageTemplates.php' => app_path('PageTemplates.php')], 'trait');
        // publish migrations
        $this->publishes([__DIR__.'/database/migrations' => database_path('migrations')], 'migrations');
        // public config
        $this->publishes([__DIR__.'/config/pagemanager.php' => config_path('pagemanager.php')]);

        $this->mergeConfigFrom(__DIR__.'/config/pagemanager.php', 'pagemanager');
    }

    /**
     * Define the routes for the application.
     *
     * @param  \Illuminate\Routing\Router  $router
     * @return void
     */
    public function setupRoutes(Router $router)

The parameter $router is not used and could be removed.

    {
        // Admin Interface Routes
        Route::group(['middleware' => ['web', 'admin'], 'prefix' => config('backpack.base.route_prefix', 'admin')], function () {

This line exceeds maximum limit of 120 characters; contains 129 characters

            $controller = config('pagemanager.admin_controller_class', $this->adminControllerClass);

            // Backpack\PageManager routes
            Route::get('page/create/{template}', $controller . '@create');
            Route::get('page/{id}/edit/{template}', $controller . '@edit');

            // This triggered an error before publishing the PageTemplates trait, when calling Route::controller();
            // CRUD::resource('page', $controller . '');

54% of this comment could be valid code. Did you maybe forget this after debugging?

            // So for PageCrudController all routes are explicitly defined:
            Route::get('page/reorder', $controller . '@reorder');
            Route::get('page/reorder/{lang}', $controller . '@reorder');
            Route::post('page/reorder', $controller . '@saveReorder');
            Route::post('page/reorder/{lang}', $controller . '@saveReorder');
            Route::get('page/{id}/details', $controller . '@showDetailsRow');
            Route::get('page/{id}/translate/{lang}', $controller . '@translateItem');
            Route::resource('page', $controller);
        });
    }

    /**
     * Register any package services.
     *
     * @return void
     */
    public function register()
    {
        $this->setupRoutes($this->app->router);
    }
}