Backpack\PageManager\app\TraitReflections

Complexity

Total Complexity

9

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	2
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	checkForTemplatesAndUniquePagesNotDistinct()	0	13	3
A	getUniquePages()	0	7	1
A	getUniquePageNames()	0	4	1
A	getUniqueSlugs()	0	6	1
A	getTemplates()	0	13	2
A	getTemplateNames()	0	4	1

<?php

namespace Backpack\PageManager\app;

use Illuminate\Support\Collection;

trait TraitReflections
{

    /**
     * Check for equal named templates and unique pages
     *
     * As the method name of a unique page will also be the template name in the database,
     * we must ensure that there are not any equal names defined.
     * If different Models (and so different tables in the database) are used, this condition must not hold any more.
     *
     * @throws \Exception
     */
    public function checkForTemplatesAndUniquePagesNotDistinct()
    {
        if (config('backpack.pagemanager.page_model_class') !== config('backpack.pagemanager.unique_page_model_class')) {

This line exceeds maximum limit of 120 characters; contains 121 characters

            return;
        }

        $uniquePages = $this->getUniquePageNames();
        $templates = $this->getTemplateNames();

        if ($uniquePages->intersect($templates)->isNotEmpty()) {
            throw new \Exception('Templates and unique pages must not have the same function names when same model class is used.');

This line exceeds maximum limit of 120 characters; contains 132 characters

        }
    }

    /**
     * Get all defined unique pages.
     *
     * @return Collection
     */
    public function getUniquePages()
    {
        $pages_trait = new \ReflectionClass('App\UniquePages');
        $pages = $pages_trait->getMethods(\ReflectionMethod::IS_PRIVATE);

        return collect($pages);
    }

    /**
     * Get all defined unique page names.
     *
     * @return Collection
     */
    public function getUniquePageNames()
    {
        return $this->getUniquePages()->pluck('name');
    }

    /**
     * Get the page names keyed with slugs.
     *
     * @return Collection
     */
    public function getUniqueSlugs()
    {
        return $this->getUniquePageNames()->mapWithKeys(function ($name) {
            return [str_slug($name) => $name];
        });
    }

    /**
     * Get all defined templates.
     *
     * @return Collection
     */
    public function getTemplates($template_name = false)

The parameter $template_name is not used and could be removed.

The parameter $template_name is not named in camelCase.

    {
        $templates_array = [];

$templates_array is not used, you could remove the assignment.

        $templates_trait = new \ReflectionClass('App\PageTemplates');
        $templates = $templates_trait->getMethods(\ReflectionMethod::IS_PRIVATE);

        if (! count($templates)) {
            abort(503, trans('backpack::pagemanager.template_not_found'));
        }

        return collect($templates);
    }

    /**
     * Get all defined template names
     *
     * @return Collection
     */
    public function getTemplateNames()
    {
        return $this->getTemplates()->pluck('name');
    }
}