Backpack\PageManager\app\TraitReflections

Complexity

Total Complexity

6

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	checkForTemplatesAndUniquePagesNotDistinct()	0	13	3
A	getUniquePages()	0	7	1
A	getTemplates()	0	13	2

<?php

namespace Backpack\PageManager\app;


trait TraitReflections
{

    public function checkForTemplatesAndUniquePagesNotDistinct()
    {
        if (config('backpack.pagemanager.page_model_class') != config('backpack.pagemanager.unique_page_model_class')) {
            return;
        }

        $uniquePages = collect($this->getUniquePages())->pluck('name');
        $templates = collect($this->getTemplates())->pluck('name');

        if ($uniquePages->intersect($templates)->isNotEmpty()) {
            throw new \Exception('Templates and unique pages should not have the same function names when same model class is used.');

This line exceeds maximum limit of 120 characters; contains 134 characters

        }
    }

    /**
     * Get all defined unique pages
     */
    public function getUniquePages()
    {
        $pages_trait = new \ReflectionClass('App\UniquePages');
        $pages = $pages_trait->getMethods(\ReflectionMethod::IS_PRIVATE);

        return $pages;
    }

    /**
     * Get all defined templates.
     */
    public function getTemplates($template_name = false)

The parameter $template_name is not used and could be removed.

The parameter $template_name is not named in camelCase.

    {
        $templates_array = [];

$templates_array is not used, you could remove the assignment.

        $templates_trait = new \ReflectionClass('App\PageTemplates');
        $templates = $templates_trait->getMethods(\ReflectionMethod::IS_PRIVATE);

        if (! count($templates)) {
            abort(503, trans('backpack::pagemanager.template_not_found'));
        }

        return $templates;
    }
}