MenuCrudController::setupListOperation() - Code Metrics - Inspection of "Revamp MenuCRUD" - Laravel-Backpack/MenuCRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#60)

by Agus

created 2020-12-30 07:14 UTC

MenuCrudController::setupListOperation() A

↳ Parent: MenuCrudController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Backpack\CRUD\app\Http\Controllers\Admin;

use Backpack\CRUD\app\Http\Controllers\CrudController;
use Backpack\CRUD\app\Http\Requests\MenuRequest;
use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade as CRUD;

/**
 * Class MenuCrudController.
 * @package Backpack\CRUD\app\Http\Controllers\Admin
 * @property-read \Backpack\CRUD\app\Library\CrudPanel\CrudPanel $crud
 */
class MenuCrudController extends CrudController
{
    use \Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\DeleteOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\ShowOperation;

    /**
     * Configure the CrudPanel object. Apply settings to all operations.
     *
     * @return void
     */
    public function setup()
    {
        $this->crud->setModel(\Backpack\CRUD\app\Models\Menu::class);
        $this->crud->setRoute(config('backpack.base.route_prefix').'/menu');
        $this->crud->setEntityNameStrings('menu', 'menus');
    }

    /**
     * Define what happens when the List operation is loaded.
     *
     * @see  https://backpackforlaravel.com/docs/crud-operation-list-entries
     * @return void
     */
    protected function setupListOperation()
    {
        $this->setupColumns(false);

        /**
         * Columns can be defined using the fluent syntax or array syntax:
         * - $this->crud->column('price')->type('number');
         * - $this->crud->addColumn(['name' => 'price', 'type' => 'number']);.
         */
    }

    protected function setupShowOperation()
    {
        $this->crud->set('show.setFromDb', false);
        $this->setupColumns(true);
    }

    /**
     * Define what happens when the Create operation is loaded.
     *
     * @see https://backpackforlaravel.com/docs/crud-operation-create
     * @return void
     */
    protected function setupCreateOperation()
    {
        $this->crud->setValidation(MenuRequest::class);

        $this->setupFields();

        /**
         * Fields can be defined using the fluent syntax or array syntax:
         * - $this->crud->field('price')->type('number');
         * - $this->crud->addField(['name' => 'price', 'type' => 'number']));.
         */
    }

    /**
     * Define what happens when the Update operation is loaded.
     *
     * @see https://backpackforlaravel.com/docs/crud-operation-update
     * @return void
     */
    protected function setupUpdateOperation()
    {
        $this->setupCreateOperation();
    }

    private function setupColumns($isShowing = false)

    {
        $this->crud->addButtonFromModelFunction('line', 'custom_actions', 'customActions', 'beginning');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->crud->addColumn([
            'name'  => 'name',
            'label' => 'Name',
            'type'  => 'text',
        ]);
        $this->crud->addColumn([
            'name'    => 'placement',
            'label'   => 'Placement',
            'type'    => 'select_from_array',
            'options' => config('backpack.menu.placement'),
        ]);
    }

    private function setupFields()
    {
        $this->crud->addField([
            'name'  => 'name',
            'label' => 'Name',
            'type'  => 'text',
        ]);
        $this->crud->addField([
            'name'        => 'placement',
            'label'       => 'Placement',
            'type'        => 'select2_from_array',
            'options'     => config('backpack.menu.placement'),
            'allows_null' => true,
            'default'     => null,
        ]);
    }
}


1			<?php
2
3			namespace Backpack\CRUD\app\Http\Controllers\Admin;
4
5			use Backpack\CRUD\app\Http\Controllers\CrudController;
6			use Backpack\CRUD\app\Http\Requests\MenuRequest;
7			use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade as CRUD;
8
9			/**
10			* Class MenuCrudController.
11			* @package Backpack\CRUD\app\Http\Controllers\Admin
12			* @property-read \Backpack\CRUD\app\Library\CrudPanel\CrudPanel $crud
13			*/
14			class MenuCrudController extends CrudController
15			{
16			use \Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;
17			use \Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation;
18			use \Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;
19			use \Backpack\CRUD\app\Http\Controllers\Operations\DeleteOperation;
20			use \Backpack\CRUD\app\Http\Controllers\Operations\ShowOperation;
21
22			/**
23			* Configure the CrudPanel object. Apply settings to all operations.
24			*
25			* @return void
26			*/
27			public function setup()
28			{
29			$this->crud->setModel(\Backpack\CRUD\app\Models\Menu::class);
30			$this->crud->setRoute(config('backpack.base.route_prefix').'/menu');
31			$this->crud->setEntityNameStrings('menu', 'menus');
32			}
33
34			/**
35			* Define what happens when the List operation is loaded.
36			*
37			* @see https://backpackforlaravel.com/docs/crud-operation-list-entries
38			* @return void
39			*/
40			protected function setupListOperation()
41			{
42			$this->setupColumns(false);
43
44			/**
45			* Columns can be defined using the fluent syntax or array syntax:
46			* - $this->crud->column('price')->type('number');
47			* - $this->crud->addColumn(['name' => 'price', 'type' => 'number']);.
48			*/
49			}
50
51			protected function setupShowOperation()
52			{
53			$this->crud->set('show.setFromDb', false);
54			$this->setupColumns(true);
55			}
56
57			/**
58			* Define what happens when the Create operation is loaded.
59			*
60			* @see https://backpackforlaravel.com/docs/crud-operation-create
61			* @return void
62			*/
63			protected function setupCreateOperation()
64			{
65			$this->crud->setValidation(MenuRequest::class);
66
67			$this->setupFields();
68
69			/**
70			* Fields can be defined using the fluent syntax or array syntax:
71			* - $this->crud->field('price')->type('number');
72			* - $this->crud->addField(['name' => 'price', 'type' => 'number']));.
73			*/
74			}
75
76			/**
77			* Define what happens when the Update operation is loaded.
78			*
79			* @see https://backpackforlaravel.com/docs/crud-operation-update
80			* @return void
81			*/
82			protected function setupUpdateOperation()
83			{
84			$this->setupCreateOperation();
85			}
86
87			private function setupColumns($isShowing = false)
			0 ignored issues – show Unused Code introduced 2020-12-30 07:06 UTC by Report Bug Copy Issue Report The parameter `$isShowing` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
88			{
89			$this->crud->addButtonFromModelFunction('line', 'custom_actions', 'customActions', 'beginning');
			0 ignored issues – show Documentation introduced 2020-12-30 07:06 UTC by Report Bug Copy Issue Report `'beginning'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
90
91			$this->crud->addColumn([
92			'name' => 'name',
93			'label' => 'Name',
94			'type' => 'text',
95			]);
96			$this->crud->addColumn([
97			'name' => 'placement',
98			'label' => 'Placement',
99			'type' => 'select_from_array',
100			'options' => config('backpack.menu.placement'),
101			]);
102			}
103
104			private function setupFields()
105			{
106			$this->crud->addField([
107			'name' => 'name',
108			'label' => 'Name',
109			'type' => 'text',
110			]);
111			$this->crud->addField([
112			'name' => 'placement',
113			'label' => 'Placement',
114			'type' => 'select2_from_array',
115			'options' => config('backpack.menu.placement'),
116			'allows_null' => true,
117			'default' => null,
118			]);
119			}
120			}
121

Laravel-Backpack / MenuCRUD

Scrutinizer GitHub App not installed

Pull Request — master (#60)

MenuCrudController::setupListOperation() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like