MenuItemCrudController::__construct() - Code Metrics - Inspection of "Menu sections" - Laravel-Backpack/MenuCRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#23)

unknown

created 2017-04-09 11:20 UTC

MenuItemCrudController::__construct() A

↳ Parent: MenuItemCrudController

Complexity

Conditions	1
Paths	1

Size

Total Lines	60
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	60
rs	9.5555
cc	1
eloc	46
nc	1
nop	0

How to fix Long Method

<?php

namespace Backpack\MenuCRUD\app\Http\Controllers\Admin;

use App\Http\Requests;
use Backpack\CRUD\app\Http\Controllers\CrudController;
// VALIDATION: change the requests to match your own file names if you need form validation
use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;

class MenuItemCrudController extends CrudController
{
    public function __construct()
    {
        parent::__construct();

        $this->crud->setModel("Backpack\MenuCRUD\app\Models\MenuItem");
        $this->crud->setRoute(config('backpack.base.route_prefix').'/menu-item');
        $this->crud->setEntityNameStrings('menu item', 'menu items');

        $this->crud->allowAccess('reorder');
        $this->crud->enableReorder('name', 2);

        $this->crud->addColumn([
                                'name' => 'name',
                                'label' => 'Label',
                            ]);
        $this->crud->addColumn([
                                'label' => 'Parent',
                                'type' => 'select',
                                'name' => 'parent_id',
                                'entity' => 'parent',
                                'attribute' => 'name',
                                'model' => "\Backpack\MenuCRUD\app\Models\MenuItem",
                            ]);

        $this->crud->addColumn([
                                'label' => 'Menu Label',
                                'type' => 'select',
                                'name' => 'menu_id',
                                'entity' => 'menu',
                                'attribute' => 'name',
                                'model' => "\Backpack\MenuCRUD\app\Models\Menu",
                            ]);

        $this->crud->addField([
                                'name' => 'name',
                                'label' => 'Label',
                            ]);
        $this->crud->addField([
                                'label' => 'Parent',
                                'type' => 'select',
                                'name' => 'parent_id',
                                'entity' => 'parent',
                                'attribute' => 'name',
                                'model' => "\Backpack\MenuCRUD\app\Models\MenuItem",
                            ]);
        $this->crud->addField([
                                'label' => 'Menu',
                                'type' => 'select',
                                'name' => 'menu_id',
                                'entity' => 'parent',
                                'attribute' => 'name',
                                'model' => "\Backpack\MenuCRUD\app\Models\Menu",
                            ]);
        $this->crud->addField([
                                'name' => 'type',
                                'label' => 'Type',
                                'type' => 'page_or_link',
                                'page_model' => '\Backpack\PageManager\app\Models\Page',
                            ]);
    }

    public function store(StoreRequest $request)
    {
        return parent::storeCrud($request);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    public function update(UpdateRequest $request)
    {
        return parent::updateCrud($request);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2
3			namespace Backpack\MenuCRUD\app\Http\Controllers\Admin;
4
5			use App\Http\Requests;
6			use Backpack\CRUD\app\Http\Controllers\CrudController;
7			// VALIDATION: change the requests to match your own file names if you need form validation
8			use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
9			use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
10
11			class MenuItemCrudController extends CrudController
12			{
13			public function __construct()
14			{
15			parent::__construct();
16
17			$this->crud->setModel("Backpack\MenuCRUD\app\Models\MenuItem");
18			$this->crud->setRoute(config('backpack.base.route_prefix').'/menu-item');
19			$this->crud->setEntityNameStrings('menu item', 'menu items');
20
21			$this->crud->allowAccess('reorder');
22			$this->crud->enableReorder('name', 2);
23
24			$this->crud->addColumn([
25			'name' => 'name',
26			'label' => 'Label',
27			]);
28			$this->crud->addColumn([
29			'label' => 'Parent',
30			'type' => 'select',
31			'name' => 'parent_id',
32			'entity' => 'parent',
33			'attribute' => 'name',
34			'model' => "\Backpack\MenuCRUD\app\Models\MenuItem",
35			]);
36
37			$this->crud->addColumn([
38			'label' => 'Menu Label',
39			'type' => 'select',
40			'name' => 'menu_id',
41			'entity' => 'menu',
42			'attribute' => 'name',
43			'model' => "\Backpack\MenuCRUD\app\Models\Menu",
44			]);
45
46			$this->crud->addField([
47			'name' => 'name',
48			'label' => 'Label',
49			]);
50			$this->crud->addField([
51			'label' => 'Parent',
52			'type' => 'select',
53			'name' => 'parent_id',
54			'entity' => 'parent',
55			'attribute' => 'name',
56			'model' => "\Backpack\MenuCRUD\app\Models\MenuItem",
57			]);
58			$this->crud->addField([
59			'label' => 'Menu',
60			'type' => 'select',
61			'name' => 'menu_id',
62			'entity' => 'parent',
63			'attribute' => 'name',
64			'model' => "\Backpack\MenuCRUD\app\Models\Menu",
65			]);
66			$this->crud->addField([
67			'name' => 'type',
68			'label' => 'Type',
69			'type' => 'page_or_link',
70			'page_model' => '\Backpack\PageManager\app\Models\Page',
71			]);
72			}
73
74			public function store(StoreRequest $request)
75			{
76			return parent::storeCrud($request);
			0 ignored issues – show Comprehensibility Bug introduced 2016-05-27 11:47 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`storeCrud()` instead of `store()`). Are you sure this is correct? If so, you might want to change this to `$this->storeCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
77			}
78
79			public function update(UpdateRequest $request)
80			{
81			return parent::updateCrud($request);
			0 ignored issues – show Comprehensibility Bug introduced 2016-05-27 11:47 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`updateCrud()` instead of `update()`). Are you sure this is correct? If so, you might want to change this to `$this->updateCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
82			}
83			}
84

Laravel-Backpack / MenuCRUD

Scrutinizer GitHub App not installed

Pull Request — master (#23)

MenuItemCrudController::__construct() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like