MenuCRUDServiceProvider::setupRoutes() - Code Metrics - Laravel-Backpack/MenuCRUD - Measure and Improve Code Quality continuously with Scrutinizer

MenuCRUDServiceProvider::setupRoutes() A
last analyzed 2021-05-07 06:53 UTC

↳ Parent: MenuCRUDServiceProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace Backpack\MenuCRUD;

use Illuminate\Routing\Router;
use Illuminate\Support\ServiceProvider;

class MenuCRUDServiceProvider extends ServiceProvider
{
    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = false;

    /**
     * Where the route file lives, both inside the package and in the app (if overwritten).
     *
     * @var string
     */
    public $routeFilePath = '/routes/backpack/menucrud.php';

    /**
     * Perform post-registration booting of services.
     *
     * @return void
     */
    public function boot()
    {
        // publish migrations
        $this->publishes([__DIR__.'/database/migrations' => database_path('migrations')], 'migrations');
    }

    /**
     * Define the routes for the application.
     *
     * @param  \Illuminate\Routing\Router  $router
     * @return void
     */
    public function setupRoutes(Router $router)

    {
        // by default, use the routes file provided in vendor
        $routeFilePathInUse = __DIR__.$this->routeFilePath;

        // but if there's a file with the same name in routes/backpack, use that one
        if (file_exists(base_path().$this->routeFilePath)) {
            $routeFilePathInUse = base_path().$this->routeFilePath;
        }

        $this->loadRoutesFrom($routeFilePathInUse);
    }

    /**
     * Register any package services.
     *
     * @return void
     */
    public function register()
    {
        $this->setupRoutes($this->app->router);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }
}


1			<?php
2
3			namespace Backpack\MenuCRUD;
4
5			use Illuminate\Routing\Router;
6			use Illuminate\Support\ServiceProvider;
7
8			class MenuCRUDServiceProvider extends ServiceProvider
9			{
10			/**
11			* Indicates if loading of the provider is deferred.
12			*
13			* @var bool
14			*/
15			protected $defer = false;
16
17			/**
18			* Where the route file lives, both inside the package and in the app (if overwritten).
19			*
20			* @var string
21			*/
22			public $routeFilePath = '/routes/backpack/menucrud.php';
23
24			/**
25			* Perform post-registration booting of services.
26			*
27			* @return void
28			*/
29			public function boot()
30			{
31			// publish migrations
32			$this->publishes([__DIR__.'/database/migrations' => database_path('migrations')], 'migrations');
33			}
34
35			/**
36			* Define the routes for the application.
37			*
38			* @param \Illuminate\Routing\Router $router
39			* @return void
40			*/
41			public function setupRoutes(Router $router)
			0 ignored issues – show Unused Code introduced 2017-08-16 08:14 UTC by Report Bug Copy Issue Report The parameter `$router` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
42			{
43			// by default, use the routes file provided in vendor
44			$routeFilePathInUse = __DIR__.$this->routeFilePath;
45
46			// but if there's a file with the same name in routes/backpack, use that one
47			if (file_exists(base_path().$this->routeFilePath)) {
48			$routeFilePathInUse = base_path().$this->routeFilePath;
49			}
50
51			$this->loadRoutesFrom($routeFilePathInUse);
52			}
53
54			/**
55			* Register any package services.
56			*
57			* @return void
58			*/
59			public function register()
60			{
61			$this->setupRoutes($this->app->router);
			0 ignored issues – show Bug introduced 2016-05-27 11:47 UTC by Report Bug Copy Issue Report Accessing `router` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
62			}
63			}
64

Laravel-Backpack / MenuCRUD

Scrutinizer GitHub App not installed

MenuCRUDServiceProvider::setupRoutes() A last analyzed 2021-05-07 06:53 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

MenuCRUDServiceProvider::setupRoutes() A
last analyzed 2021-05-07 06:53 UTC