LanguageCrudController::__construct() - Code Metrics - Inspection of "Update LanguageCrudController.php" - Laravel-Backpack/LangFileManager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d32009...399c68 )

by Ghitu

created 2016-06-07 23:24 UTC

LanguageCrudController::__construct() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	49
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	49
rs	9.2258
cc	1
eloc	34
nc	1
nop	0

<?php

namespace Backpack\LangFileManager\app\Http\Controllers;

use App\Http\Requests;
use Backpack\CRUD\app\Http\Controllers\CrudController;
use Backpack\LangFileManager\app\Services\LangFiles;
use Backpack\LangFileManager\app\Models\Language;
use Illuminate\Http\Request;
// VALIDATION: change the requests to match your own file names if you need form validation
use Backpack\LangFileManager\app\Http\Requests\LanguageRequest as StoreRequest;
use Backpack\LangFileManager\app\Http\Requests\LanguageRequest as UpdateRequest;

class LanguageCrudController extends CrudController
{
    public function __construct() {
        parent::__construct();

        $this->crud->setModel("Backpack\LangFileManager\app\Models\Language");
        $this->crud->setRoute("admin/language");
        $this->crud->setEntityNameStrings('language', 'languages');

        $this->crud->setColumns([
            [
                'name' => 'name',
                'label' => 'Language name',
            ],
            [
                'name' => 'active',
                'label' => 'Active',
                'type' => 'boolean',
            ],
            [
                'name' => 'default',
                'label' => 'Default',
                'type' => 'boolean',
            ],
        ]);
        $this->crud->addField([
            'name' => 'name',
            'label' => 'Language Name',
            'type' => 'text',
        ]);
        $this->crud->addField([
            'name' => 'abbr',
            'label' => 'Code (ISO 639-1)',
            'type' => 'text',
        ]);
        $this->crud->addField([
            'name' => 'flag',
            'label' => 'Flag image',
            'type' => 'browse',
        ]);
        $this->crud->addField([
            'name' => 'active',
            'label' => 'Active',
            'type' => 'checkbox',
        ]);
        $this->crud->addField([
            'name' => 'default',
            'label' => 'Default',
            'type' => 'checkbox',
        ]);
    }

    public function store(StoreRequest $request)

    {
        return parent::storeCrud();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    public function update(UpdateRequest $request)

    {
        return parent::updateCrud();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    public function showTexts(LangFiles $langfile, Language $languages, $lang = '', $file = 'site')

    {
        // SECURITY
        // check if that file isn't forbidden in the config file
        if (in_array($file, config('langfilemanager.language_ignore'))) {
            abort('403', 'This language file cannot be edited online.');
        }

        if ($lang) {
            $langfile->setLanguage($lang);
        }

        $langfile->setFile($file);
        $this->data['crud'] = $this->crud;
        $this->data['currentFile'] = $file;
        $this->data['currentLang'] = $lang ?: config('app.locale');
        $this->data['currentLangObj'] = Language::where('abbr', '=', $this->data['currentLang'])->first();
        $this->data['browsingLangObj'] = Language::where('abbr', '=', config('app.locale'))->first();
        $this->data['languages'] = $languages->orderBy('name')->get();
        $this->data['langFiles'] = $langfile->getlangFiles();
        $this->data['fileArray'] = $langfile->getFileContent();
        $this->data['langfile'] = $langfile;
        $this->data['title'] = 'Translations';

        return view('langfilemanager::translations', $this->data);
    }

    public function updateTexts(LangFiles $langfile, Request $request, $lang = '', $file = 'site')

    {
        // SECURITY
        // check if that file isn't forbidden in the config file
        if (in_array($file, config('langfilemanager.language_ignore'))) {
            abort('403', 'This language file cannot be edited online.');
        }

        $message = trans('error.error_general');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $status = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($lang) {
            $langfile->setLanguage($lang);
        }

        $langfile->setFile($file);

        $fields = $langfile->testFields($request->all());
        if (empty($fields)) {
            if ($langfile->setFileContent($request->all())) {
                \Alert::success('Saved')->flash();
                $status = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            }
        } else {
            $message = trans('admin.language.fields_required');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            \Alert::error('Please fill all fields')->flash();
        }

        return redirect()->back();
    }
}


1			<?php
2
3			namespace Backpack\LangFileManager\app\Http\Controllers;
4
5			use App\Http\Requests;
6			use Backpack\CRUD\app\Http\Controllers\CrudController;
7			use Backpack\LangFileManager\app\Services\LangFiles;
8			use Backpack\LangFileManager\app\Models\Language;
9			use Illuminate\Http\Request;
10			// VALIDATION: change the requests to match your own file names if you need form validation
11			use Backpack\LangFileManager\app\Http\Requests\LanguageRequest as StoreRequest;
12			use Backpack\LangFileManager\app\Http\Requests\LanguageRequest as UpdateRequest;
13
14			class LanguageCrudController extends CrudController
15			{
16			public function __construct() {
17			parent::__construct();
18
19			$this->crud->setModel("Backpack\LangFileManager\app\Models\Language");
20			$this->crud->setRoute("admin/language");
21			$this->crud->setEntityNameStrings('language', 'languages');
22
23			$this->crud->setColumns([
24			[
25			'name' => 'name',
26			'label' => 'Language name',
27			],
28			[
29			'name' => 'active',
30			'label' => 'Active',
31			'type' => 'boolean',
32			],
33			[
34			'name' => 'default',
35			'label' => 'Default',
36			'type' => 'boolean',
37			],
38			]);
39			$this->crud->addField([
40			'name' => 'name',
41			'label' => 'Language Name',
42			'type' => 'text',
43			]);
44			$this->crud->addField([
45			'name' => 'abbr',
46			'label' => 'Code (ISO 639-1)',
47			'type' => 'text',
48			]);
49			$this->crud->addField([
50			'name' => 'flag',
51			'label' => 'Flag image',
52			'type' => 'browse',
53			]);
54			$this->crud->addField([
55			'name' => 'active',
56			'label' => 'Active',
57			'type' => 'checkbox',
58			]);
59			$this->crud->addField([
60			'name' => 'default',
61			'label' => 'Default',
62			'type' => 'checkbox',
63			]);
64			}
65
66			public function store(StoreRequest $request)
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
67			{
68			return parent::storeCrud();
			0 ignored issues – show Comprehensibility Bug introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`storeCrud()` instead of `store()`). Are you sure this is correct? If so, you might want to change this to `$this->storeCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
69			}
70
71			public function update(UpdateRequest $request)
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
72			{
73			return parent::updateCrud();
			0 ignored issues – show Comprehensibility Bug introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`updateCrud()` instead of `update()`). Are you sure this is correct? If so, you might want to change this to `$this->updateCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
74			}
75
76			public function showTexts(LangFiles $langfile, Language $languages, $lang = '', $file = 'site')
			0 ignored issues – show Documentation introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
77			{
78			// SECURITY
79			// check if that file isn't forbidden in the config file
80			if (in_array($file, config('langfilemanager.language_ignore'))) {
81			abort('403', 'This language file cannot be edited online.');
82			}
83
84			if ($lang) {
85			$langfile->setLanguage($lang);
86			}
87
88			$langfile->setFile($file);
89			$this->data['crud'] = $this->crud;
90			$this->data['currentFile'] = $file;
91			$this->data['currentLang'] = $lang ?: config('app.locale');
92			$this->data['currentLangObj'] = Language::where('abbr', '=', $this->data['currentLang'])->first();
93			$this->data['browsingLangObj'] = Language::where('abbr', '=', config('app.locale'))->first();
94			$this->data['languages'] = $languages->orderBy('name')->get();
95			$this->data['langFiles'] = $langfile->getlangFiles();
96			$this->data['fileArray'] = $langfile->getFileContent();
97			$this->data['langfile'] = $langfile;
98			$this->data['title'] = 'Translations';
99
100			return view('langfilemanager::translations', $this->data);
101			}
102
103			public function updateTexts(LangFiles $langfile, Request $request, $lang = '', $file = 'site')
			0 ignored issues – show Documentation introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
104			{
105			// SECURITY
106			// check if that file isn't forbidden in the config file
107			if (in_array($file, config('langfilemanager.language_ignore'))) {
108			abort('403', 'This language file cannot be edited online.');
109			}
110
111			$message = trans('error.error_general');
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report `$message` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
112			$status = false;
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report `$status` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
113
114			if ($lang) {
115			$langfile->setLanguage($lang);
116			}
117
118			$langfile->setFile($file);
119
120			$fields = $langfile->testFields($request->all());
121			if (empty($fields)) {
122			if ($langfile->setFileContent($request->all())) {
123			\Alert::success('Saved')->flash();
124			$status = true;
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report `$status` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
125			}
126			} else {
127			$message = trans('admin.language.fields_required');
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report `$message` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
128			\Alert::error('Please fill all fields')->flash();
129			}
130
131			return redirect()->back();
132			}
133			}
134

Laravel-Backpack / LangFileManager

Scrutinizer GitHub App not installed

Push — master ( d32009...399c68 )

LanguageCrudController::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like