LanguageCrudController::destroy() - Code Metrics - Inspection of "Sort file list alphabetically for better readabili..." - Laravel-Backpack/LangFileManager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#19)

unknown

created 2016-07-07 10:21 UTC

LanguageCrudController::destroy() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	0
loc	11
rs	9.4285
cc	2
eloc	6
nc	2
nop	1

<?php

namespace Backpack\LangFileManager\app\Http\Controllers;

use App\Http\Requests;
use Backpack\CRUD\app\Http\Controllers\CrudController;
use Backpack\LangFileManager\app\Services\LangFiles;
use Backpack\LangFileManager\app\Models\Language;
use Illuminate\Http\Request;
// VALIDATION: change the requests to match your own file names if you need form validation
use Backpack\LangFileManager\app\Http\Requests\LanguageRequest as StoreRequest;
use Backpack\LangFileManager\app\Http\Requests\LanguageRequest as UpdateRequest;

class LanguageCrudController extends CrudController
{
    public function __construct()
    {
        parent::__construct();

        $this->crud->setModel("Backpack\LangFileManager\app\Models\Language");
        $this->crud->setRoute('admin/language');
        $this->crud->setEntityNameStrings(trans('backpack::langfilemanager.language'), trans('backpack::langfilemanager.languages'));


        $this->crud->setColumns([
            [
                'name' => 'name',
                'label' => trans('backpack::langfilemanager.language_name'),
            ],
            [
                'name' => 'active',
                'label' => trans('backpack::langfilemanager.active'),
                'type' => 'boolean',
            ],
            [
                'name' => 'default',
                'label' => trans('backpack::langfilemanager.default'),
                'type' => 'boolean',
            ],
        ]);
        $this->crud->addField([
            'name' => 'name',
            'label' => trans('backpack::langfilemanager.language_name'),
            'type' => 'text',
        ]);
        $this->crud->addField([
            'name' => 'native',
            'label' => trans('backpack::langfilemanager.native_name'),
            'type' => 'text',
        ]);
        $this->crud->addField([
            'name' => 'abbr',
            'label' => trans('backpack::langfilemanager.code_iso639-1'),
            'type' => 'text',
        ]);
        $this->crud->addField([
            'name' => 'flag',
            'label' => trans('backpack::langfilemanager.flag_image'),
            'type' => 'browse',
        ]);
        $this->crud->addField([
            'name' => 'active',
            'label' => trans('backpack::langfilemanager.active'),
            'type' => 'checkbox',
        ]);
        $this->crud->addField([
            'name' => 'default',
            'label' => trans('backpack::langfilemanager.default'),
            'type' => 'checkbox',
        ]);
    }

    public function store(StoreRequest $request)
    {
        $defaultLang = Language::where('default', 1)->first();

        // Copy the default language folder to the new language folder
        \File::copyDirectory(resource_path('lang/'.$defaultLang->abbr), resource_path('lang/'.$request->input('abbr')));

        return parent::storeCrud();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    public function update(UpdateRequest $request)

    {
        return parent::updateCrud();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * After delete remove also the language folder.
     *
     * @param int $id
     *
     * @return string
     */
    public function destroy($id)
    {
        $language = Language::find($id);
        $destroyResult = parent::destroy($id);

        if ($destroyResult) {
            \File::deleteDirectory(resource_path('lang/'.$language->abbr));
        }

        return $destroyResult;
    }

    public function showTexts(LangFiles $langfile, Language $languages, $lang = '', $file = 'site')

    {
        // SECURITY
        // check if that file isn't forbidden in the config file
        if (in_array($file, config('backpack.langfilemanager.language_ignore'))) {
            abort('403', trans('backpack::langfilemanager.cant_edit_online'));
        }

        if ($lang) {
            $langfile->setLanguage($lang);
        }

        $langfile->setFile($file);
        $this->data['crud'] = $this->crud;
        $this->data['currentFile'] = $file;
        $this->data['currentLang'] = $lang ?: config('app.locale');
        $this->data['currentLangObj'] = Language::where('abbr', '=', $this->data['currentLang'])->first();
        $this->data['browsingLangObj'] = Language::where('abbr', '=', config('app.locale'))->first();
        $this->data['languages'] = $languages->orderBy('name')->get();
        $this->data['langFiles'] = $langfile->getlangFiles();
        $this->data['fileArray'] = $langfile->getFileContent();
        $this->data['langfile'] = $langfile;
        $this->data['title'] = trans('backpack::langfilemanager.translations');

        return view('langfilemanager::translations', $this->data);
    }

    public function updateTexts(LangFiles $langfile, Request $request, $lang = '', $file = 'site')

    {
        // SECURITY
        // check if that file isn't forbidden in the config file
        if (in_array($file, config('backpack.langfilemanager.language_ignore'))) {
            abort('403', trans('backpack::langfilemanager.cant_edit_online'));
        }

        $message = trans('error.error_general');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $status = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($lang) {
            $langfile->setLanguage($lang);
        }

        $langfile->setFile($file);

        $fields = $langfile->testFields($request->all());
        if (empty($fields)) {
            if ($langfile->setFileContent($request->all())) {
                \Alert::success(trans('backpack::langfilemanager.saved'))->flash();
                $status = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            }
        } else {
            $message = trans('admin.language.fields_required');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            \Alert::error(trans('backpack::langfilemanager.please_fill_all_fields'))->flash();
        }

        return redirect()->back();
    }
}


1			<?php
2
3			namespace Backpack\LangFileManager\app\Http\Controllers;
4
5			use App\Http\Requests;
6			use Backpack\CRUD\app\Http\Controllers\CrudController;
7			use Backpack\LangFileManager\app\Services\LangFiles;
8			use Backpack\LangFileManager\app\Models\Language;
9			use Illuminate\Http\Request;
10			// VALIDATION: change the requests to match your own file names if you need form validation
11			use Backpack\LangFileManager\app\Http\Requests\LanguageRequest as StoreRequest;
12			use Backpack\LangFileManager\app\Http\Requests\LanguageRequest as UpdateRequest;
13
14			class LanguageCrudController extends CrudController
15			{
16			public function __construct()
17			{
18			parent::__construct();
19
20			$this->crud->setModel("Backpack\LangFileManager\app\Models\Language");
21			$this->crud->setRoute('admin/language');
22			$this->crud->setEntityNameStrings(trans('backpack::langfilemanager.language'), trans('backpack::langfilemanager.languages'));
			0 ignored issues – show Coding Style introduced 2016-06-08 09:26 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 133 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
23
24			$this->crud->setColumns([
25			[
26			'name' => 'name',
27			'label' => trans('backpack::langfilemanager.language_name'),
28			],
29			[
30			'name' => 'active',
31			'label' => trans('backpack::langfilemanager.active'),
32			'type' => 'boolean',
33			],
34			[
35			'name' => 'default',
36			'label' => trans('backpack::langfilemanager.default'),
37			'type' => 'boolean',
38			],
39			]);
40			$this->crud->addField([
41			'name' => 'name',
42			'label' => trans('backpack::langfilemanager.language_name'),
43			'type' => 'text',
44			]);
45			$this->crud->addField([
46			'name' => 'native',
47			'label' => trans('backpack::langfilemanager.native_name'),
48			'type' => 'text',
49			]);
50			$this->crud->addField([
51			'name' => 'abbr',
52			'label' => trans('backpack::langfilemanager.code_iso639-1'),
53			'type' => 'text',
54			]);
55			$this->crud->addField([
56			'name' => 'flag',
57			'label' => trans('backpack::langfilemanager.flag_image'),
58			'type' => 'browse',
59			]);
60			$this->crud->addField([
61			'name' => 'active',
62			'label' => trans('backpack::langfilemanager.active'),
63			'type' => 'checkbox',
64			]);
65			$this->crud->addField([
66			'name' => 'default',
67			'label' => trans('backpack::langfilemanager.default'),
68			'type' => 'checkbox',
69			]);
70			}
71
72			public function store(StoreRequest $request)
73			{
74			$defaultLang = Language::where('default', 1)->first();
75
76			// Copy the default language folder to the new language folder
77			\File::copyDirectory(resource_path('lang/'.$defaultLang->abbr), resource_path('lang/'.$request->input('abbr')));
78
79			return parent::storeCrud();
			0 ignored issues – show Comprehensibility Bug introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`storeCrud()` instead of `store()`). Are you sure this is correct? If so, you might want to change this to `$this->storeCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
80			}
81
82			public function update(UpdateRequest $request)
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
83			{
84			return parent::updateCrud();
			0 ignored issues – show Comprehensibility Bug introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`updateCrud()` instead of `update()`). Are you sure this is correct? If so, you might want to change this to `$this->updateCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
85			}
86
87			/**
88			* After delete remove also the language folder.
89			*
90			* @param int $id
91			*
92			* @return string
93			*/
94			public function destroy($id)
95			{
96			$language = Language::find($id);
97			$destroyResult = parent::destroy($id);
98
99			if ($destroyResult) {
100			\File::deleteDirectory(resource_path('lang/'.$language->abbr));
101			}
102
103			return $destroyResult;
104			}
105
106			public function showTexts(LangFiles $langfile, Language $languages, $lang = '', $file = 'site')
			0 ignored issues – show Documentation introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
107			{
108			// SECURITY
109			// check if that file isn't forbidden in the config file
110			if (in_array($file, config('backpack.langfilemanager.language_ignore'))) {
111			abort('403', trans('backpack::langfilemanager.cant_edit_online'));
112			}
113
114			if ($lang) {
115			$langfile->setLanguage($lang);
116			}
117
118			$langfile->setFile($file);
119			$this->data['crud'] = $this->crud;
120			$this->data['currentFile'] = $file;
121			$this->data['currentLang'] = $lang ?: config('app.locale');
122			$this->data['currentLangObj'] = Language::where('abbr', '=', $this->data['currentLang'])->first();
123			$this->data['browsingLangObj'] = Language::where('abbr', '=', config('app.locale'))->first();
124			$this->data['languages'] = $languages->orderBy('name')->get();
125			$this->data['langFiles'] = $langfile->getlangFiles();
126			$this->data['fileArray'] = $langfile->getFileContent();
127			$this->data['langfile'] = $langfile;
128			$this->data['title'] = trans('backpack::langfilemanager.translations');
129
130			return view('langfilemanager::translations', $this->data);
131			}
132
133			public function updateTexts(LangFiles $langfile, Request $request, $lang = '', $file = 'site')
			0 ignored issues – show Documentation introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
134			{
135			// SECURITY
136			// check if that file isn't forbidden in the config file
137			if (in_array($file, config('backpack.langfilemanager.language_ignore'))) {
138			abort('403', trans('backpack::langfilemanager.cant_edit_online'));
139			}
140
141			$message = trans('error.error_general');
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report `$message` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
142			$status = false;
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report `$status` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
143
144			if ($lang) {
145			$langfile->setLanguage($lang);
146			}
147
148			$langfile->setFile($file);
149
150			$fields = $langfile->testFields($request->all());
151			if (empty($fields)) {
152			if ($langfile->setFileContent($request->all())) {
153			\Alert::success(trans('backpack::langfilemanager.saved'))->flash();
154			$status = true;
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report `$status` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
155			}
156			} else {
157			$message = trans('admin.language.fields_required');
			0 ignored issues – show Unused Code introduced 2016-03-16 16:48 UTC by Report Bug Copy Issue Report `$message` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
158			\Alert::error(trans('backpack::langfilemanager.please_fill_all_fields'))->flash();
159			}
160
161			return redirect()->back();
162			}
163			}
164

Laravel-Backpack / LangFileManager

Scrutinizer GitHub App not installed

Pull Request — master (#19)

LanguageCrudController::destroy() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like