CrudOverwrite::handle() - Code Metrics - Inspection of "Fixes #13 - Allows you to publish buttons/fields/c..." - Laravel-Backpack/Generators - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#15)

by Owen

created 2016-12-05 15:16 UTC

CrudOverwrite::handle() C

↳ Parent: CrudOverwrite

Complexity

Conditions	7
Paths	7

Size

Total Lines	23
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	23
rs	6.7272
cc	7
eloc	19
nc	7
nop	0

<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;

class CrudOverwrite extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'backpack:overwrite';

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'backpack:overwrite
                            {type : what are you overwriting? field/column/button}
                            {name : name of the field}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Publishes a built in field/column/button for modification';

    public $packageDir = 'vendor/backpack/crud/src/resources/views/';
    public $appDir = 'resources/views/vendor/backpack/crud/';

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $this->type = strtolower($this->argument('type'));
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->name = strtolower($this->argument('name'));

        switch ($this->type) {
            case 'field':
            case 'fields':
                return $this->publishField();
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'button':
            case 'buttons':
                return $this->publishButton();
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'column':
            case 'columns':
                return $this->publishColumn();
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                return $this->error('Please pick from field, column or button');
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }

    protected function processPublish($file, $label)
    {
        $sourceFile = $this->packageDir.$file.'.blade.php';
        $copiedFile = $this->appDir.$file.'.blade.php';

        if (! file_exists($sourceFile)) {
            return $this->error(
                'Cannot find source '.$label.' at '
                .$sourceFile.
                ' - make sure you\'ve picked a real '.$label.' type'
            );
        } else {
            $canCopy = true;

            if (file_exists($copiedFile)) {
                $canCopy = $this->confirm(
                    'File already exists at '
                    .$copiedFile.
                    ' - do you want to overwrite it?'
                );
            }

            if ($canCopy) {
                $path = pathinfo($copiedFile);

                if (! file_exists($path['dirname'])) {
                    mkdir($path['dirname'], 0755, true);
                }

                if (copy($sourceFile, $copiedFile)) {
                    $this->info('Copied to '.$copiedFile);
                } else {
                    return $this->error(
                        'Failed to copy '
                        .$sourceFile.
                        ' to '
                        .$copiedFile.
                        ' for unknown reason'
                    );
                }
            }
        }
    }

    protected function publishField()
    {
        return $this->processPublish('fields/'.$this->name, 'field');
    }

    protected function publishColumn()
    {
        return $this->processPublish('columns/'.$this->name, 'column');
    }

    protected function publishButton()
    {
        return $this->processPublish('buttons/'.$this->name, 'button');
    }
}


1			<?php
2
3			namespace App\Console\Commands;
4
5			use Illuminate\Console\Command;
6
7			class CrudOverwrite extends Command
8			{
9			/**
10			* The console command name.
11			*
12			* @var string
13			*/
14			protected $name = 'backpack:overwrite';
15
16			/**
17			* The name and signature of the console command.
18			*
19			* @var string
20			*/
21			protected $signature = 'backpack:overwrite
22			{type : what are you overwriting? field/column/button}
23			{name : name of the field}';
24
25			/**
26			* The console command description.
27			*
28			* @var string
29			*/
30			protected $description = 'Publishes a built in field/column/button for modification';
31
32			public $packageDir = 'vendor/backpack/crud/src/resources/views/';
33			public $appDir = 'resources/views/vendor/backpack/crud/';
34
35			/**
36			* Create a new command instance.
37			*
38			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-12-05 15:18 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
39			*/
40			public function __construct()
41			{
42			parent::__construct();
43			}
44
45			/**
46			* Execute the console command.
47			*
48			* @return mixed
49			*/
50			public function handle()
51			{
52			$this->type = strtolower($this->argument('type'));
			0 ignored issues – show Bug introduced 2016-12-05 15:18 UTC by Report Bug Copy Issue Report The property `type` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
53			$this->name = strtolower($this->argument('name'));
54
55			switch ($this->type) {
56			case 'field':
57			case 'fields':
58			return $this->publishField();
59			break;
			0 ignored issues – show Unused Code introduced 2016-12-05 15:18 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
60			case 'button':
61			case 'buttons':
62			return $this->publishButton();
63			break;
			0 ignored issues – show Unused Code introduced 2016-12-05 15:18 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
64			case 'column':
65			case 'columns':
66			return $this->publishColumn();
67			break;
			0 ignored issues – show Unused Code introduced 2016-12-05 15:18 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
68			default:
69			return $this->error('Please pick from field, column or button');
70			break;
			0 ignored issues – show Unused Code introduced 2016-12-05 15:18 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
71			}
72			}
73
74			protected function processPublish($file, $label)
75			{
76			$sourceFile = $this->packageDir.$file.'.blade.php';
77			$copiedFile = $this->appDir.$file.'.blade.php';
78
79			if (! file_exists($sourceFile)) {
80			return $this->error(
81			'Cannot find source '.$label.' at '
82			.$sourceFile.
83			' - make sure you\'ve picked a real '.$label.' type'
84			);
85			} else {
86			$canCopy = true;
87
88			if (file_exists($copiedFile)) {
89			$canCopy = $this->confirm(
90			'File already exists at '
91			.$copiedFile.
92			' - do you want to overwrite it?'
93			);
94			}
95
96			if ($canCopy) {
97			$path = pathinfo($copiedFile);
98
99			if (! file_exists($path['dirname'])) {
100			mkdir($path['dirname'], 0755, true);
101			}
102
103			if (copy($sourceFile, $copiedFile)) {
104			$this->info('Copied to '.$copiedFile);
105			} else {
106			return $this->error(
107			'Failed to copy '
108			.$sourceFile.
109			' to '
110			.$copiedFile.
111			' for unknown reason'
112			);
113			}
114			}
115			}
116			}
117
118			protected function publishField()
119			{
120			return $this->processPublish('fields/'.$this->name, 'field');
121			}
122
123			protected function publishColumn()
124			{
125			return $this->processPublish('columns/'.$this->name, 'column');
126			}
127
128			protected function publishButton()
129			{
130			return $this->processPublish('buttons/'.$this->name, 'button');
131			}
132			}
133

Laravel-Backpack / Generators

Scrutinizer GitHub App not installed

Pull Request — master (#15)

CrudOverwrite::handle() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like