PermissionGeneratorBackpackCommand::handle() - Code Metrics - Inspection of "Permission generator" - Laravel-Backpack/Generators - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

unknown

created 2016-09-11 12:01 UTC

PermissionGeneratorBackpackCommand::handle() B

↳ Parent: PermissionGeneratorBackpackCommand

Complexity

Conditions	6
Paths	10

Size

Total Lines	53
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	53
rs	8.7155
c	0
b	0
f	0
cc	6
eloc	33
nc	10
nop	0

How to fix Long Method

<?php

namespace Backpack\Generators\Console\Commands;

use Artisan;
use Illuminate\Console\Command;
use Spatie\Permission\Models\Permission;

class PermissionGeneratorBackpackCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
     protected $signature = 'backpack:permissions {route : Name of the route e.g admin/teams} {--P|permission=* : A permission you wish to add, can accept multiple instances of -P|permission}';


    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Will generate permissions for routes and save to the database';

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $routeName         = $this->argument('route');
        $permissions       = ['list', 'create', 'update', 'reorder', 'delete'];
        $permissionsAdded  = 0;
        $customPermissions = $this->option('permission');

        if( count($customPermissions) > 0 ){
            $permissions = $customPermissions;
        }

        $bar = $this->output->createProgressBar(count($permissions));

        foreach($permissions as $permission){
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }

            $permissionName = trim($routeName, '/') . '/' . trim($permission, '/');
            $permissionName = strtolower($permissionName);

            $existingPermission = Permission::where(['name' => $permissionName])->first();

            if( $existingPermission ){

                $continueAdding = $this->confirm("$permissionName already exists, do you want to carry on? [y|N]");

                if( $continueAdding ){
                    $bar->setMessage("Skipping $permissionName");
                    $bar->advance();
                    continue;
                }
                else {
                    $bar->finish();
                    return $this->error("\nCancelled adding any more permissions.");
                }
            }
            else {
                $newPermission = Permission::create(['name' => $permissionName]);
                $newPermission->save();

                if( $newPermission->id ){
                    $permissionsAdded++;
                    $bar->setMessage("$newPermission->name added with ID: $newPermission->id");
                    $bar->advance();
                }
                else {
                    $bar->setMessage("$permissionName could not be created.");
                    $bar->advance();
                }
            }
        }

        $bar->finish();
        $this->info("\nFinished adding $permissionsAdded new permissions");
    }
}


1			<?php
2
3			namespace Backpack\Generators\Console\Commands;
4
5			use Artisan;
6			use Illuminate\Console\Command;
7			use Spatie\Permission\Models\Permission;
8
9			class PermissionGeneratorBackpackCommand extends Command
10			{
11			/**
12			* The name and signature of the console command.
13			*
14			* @var string
15			*/
16			protected $signature = 'backpack:permissions {route : Name of the route e.g admin/teams} {--P\|permission=* : A permission you wish to add, can accept multiple instances of -P\|permission}';
			0 ignored issues – show Coding Style introduced 2016-09-11 12:04 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 193 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'Will generate permissions for routes and save to the database';
24
25			/**
26			* Execute the console command.
27			*
28			* @return mixed
29			*/
30			public function handle()
31			{
32			$routeName = $this->argument('route');
33			$permissions = ['list', 'create', 'update', 'reorder', 'delete'];
34			$permissionsAdded = 0;
35			$customPermissions = $this->option('permission');
36
37			if( count($customPermissions) > 0 ){
38			$permissions = $customPermissions;
39			}
40
41			$bar = $this->output->createProgressBar(count($permissions));
42
43			foreach($permissions as $permission){
			0 ignored issues – show Bug introduced 2016-09-11 12:04 UTC by Report Bug Copy Issue Report The expression `$permissions` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
44
45			$permissionName = trim($routeName, '/') . '/' . trim($permission, '/');
46			$permissionName = strtolower($permissionName);
47
48			$existingPermission = Permission::where(['name' => $permissionName])->first();
49
50			if( $existingPermission ){
51
52			$continueAdding = $this->confirm("$permissionName already exists, do you want to carry on? [y\|N]");
53
54			if( $continueAdding ){
55			$bar->setMessage("Skipping $permissionName");
56			$bar->advance();
57			continue;
58			}
59			else {
60			$bar->finish();
61			return $this->error("\nCancelled adding any more permissions.");
62			}
63			}
64			else {
65			$newPermission = Permission::create(['name' => $permissionName]);
66			$newPermission->save();
67
68			if( $newPermission->id ){
69			$permissionsAdded++;
70			$bar->setMessage("$newPermission->name added with ID: $newPermission->id");
71			$bar->advance();
72			}
73			else {
74			$bar->setMessage("$permissionName could not be created.");
75			$bar->advance();
76			}
77			}
78			}
79
80			$bar->finish();
81			$this->info("\nFinished adding $permissionsAdded new permissions");
82			}
83			}
84

Laravel-Backpack / Generators

Scrutinizer GitHub App not installed

Pull Request — master (#7)

PermissionGeneratorBackpackCommand::handle() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like